All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Cc: Sebastian Reichel <sre@kernel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	Courtney Cavin <courtney.cavin@sonymobile.com>
Subject: Re: [PATCH 3/4] power: Add Qualcomm SMBB driver
Date: Fri, 19 Jun 2015 19:01:28 +0200	[thread overview]
Message-ID: <1434733288.2385.173.camel@x220> (raw)
In-Reply-To: <1434662025-9485-4-git-send-email-bjorn.andersson@sonymobile.com>

On Thu, 2015-06-18 at 14:13 -0700, Bjorn Andersson wrote:
> --- /dev/null
> +++ b/drivers/power/qcom_smbb.c

> +MODULE_ALIAS("platform:qcom_smbb");

(The day before yesterday and yesterday I had a, well, lively
conversation regarding this macro. The interesting bits start at
https://lkml.org/lkml/2015/6/17/383 . 

But in a converstaion today things were rather silent. See
https://lkml.org/lkml/2015/6/19/68 and the reply, of sorts, in
https://lkml.org/lkml/2015/6/19/117. Let's see what happens here.)

As I understand it, this alias is only useful if there's a corresponding
struct platform_device, somewhere. Ie, this alias implies a
platform_device that will fire of a "MODALIAS=platform:qcom_smbb" uevent
when it's created. That would be a platform_device using a "qcom_smbb"
name.

If that's correct, then I think this MODULE_ALIAS macro isn't needed
here, as I couldn't find a platform_device using that name. (But perhaps
a patch that adds it is pending, somewhere.)

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in

WARNING: multiple messages have this Message-ID (diff)
From: Paul Bolle <pebolle@tiscali.nl>
To: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Cc: Sebastian Reichel <sre@kernel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	Courtney Cavin <courtney.cavin@sonymobile.com>
Subject: Re: [PATCH 3/4] power: Add Qualcomm SMBB driver
Date: Fri, 19 Jun 2015 19:01:28 +0200	[thread overview]
Message-ID: <1434733288.2385.173.camel@x220> (raw)
In-Reply-To: <1434662025-9485-4-git-send-email-bjorn.andersson@sonymobile.com>

On Thu, 2015-06-18 at 14:13 -0700, Bjorn Andersson wrote:
> --- /dev/null
> +++ b/drivers/power/qcom_smbb.c

> +MODULE_ALIAS("platform:qcom_smbb");

(The day before yesterday and yesterday I had a, well, lively
conversation regarding this macro. The interesting bits start at
https://lkml.org/lkml/2015/6/17/383 . 

But in a converstaion today things were rather silent. See
https://lkml.org/lkml/2015/6/19/68 and the reply, of sorts, in
https://lkml.org/lkml/2015/6/19/117. Let's see what happens here.)

As I understand it, this alias is only useful if there's a corresponding
struct platform_device, somewhere. Ie, this alias implies a
platform_device that will fire of a "MODALIAS=platform:qcom_smbb" uevent
when it's created. That would be a platform_device using a "qcom_smbb"
name.

If that's correct, then I think this MODULE_ALIAS macro isn't needed
here, as I couldn't find a platform_device using that name. (But perhaps
a patch that adds it is pending, somewhere.)

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

  reply	other threads:[~2015-06-19 17:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-18 21:13 [PATCH 0/4] Qualcomm Switch-Mode Battery Charger and Boost Bjorn Andersson
2015-06-18 21:13 ` Bjorn Andersson
2015-06-18 21:13 ` Bjorn Andersson
2015-06-18 21:13 ` [PATCH 1/4] spmi: pmic-arb: add irq_get_irqchip_state implementation Bjorn Andersson
2015-06-18 21:13   ` Bjorn Andersson
2015-07-27  5:34   ` Andy Gross
2015-06-18 21:13 ` [PATCH 2/4] dt-binding: power: Add Qualcomm SMBB binding Bjorn Andersson
2015-06-18 21:13   ` Bjorn Andersson
2015-06-18 21:13 ` [PATCH 3/4] power: Add Qualcomm SMBB driver Bjorn Andersson
2015-06-18 21:13   ` Bjorn Andersson
2015-06-19 17:01   ` Paul Bolle [this message]
2015-06-19 17:01     ` Paul Bolle
2015-06-22  5:06     ` Bjorn Andersson
2015-06-22  5:06       ` Bjorn Andersson
2015-07-25 15:42   ` Sebastian Reichel
2015-07-26  1:04     ` Bjorn Andersson
2015-07-27 14:06       ` Sebastian Reichel
2015-07-30 17:17         ` Bjorn Andersson
2015-06-18 21:13 ` [PATCH 4/4] ARM: dts: qcom-pm8941: Add charger node Bjorn Andersson
2015-06-18 21:13   ` Bjorn Andersson
2015-06-18 21:13   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434733288.2385.173.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=bjorn.andersson@sonymobile.com \
    --cc=courtney.cavin@sonymobile.com \
    --cc=dbaryshkov@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.