From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"brcm80211 development" <brcm80211-dev-list@broadcom.com>
Subject: Re: brcmfmac: one faulty "iw interface add" command breaks in-firmware BSS state
Date: Mon, 22 Jun 2015 10:03:26 +0200 [thread overview]
Message-ID: <1434960206.19597.6.camel@sipsolutions.net> (raw)
In-Reply-To: <5587BDA9.5000107@broadcom.com> (sfid-20150622_094800_795721_2E996996)
On Mon, 2015-06-22 at 09:47 +0200, Arend van Spriel wrote:
> > # iw phy phy0 interface add wlan0 type __ap
>
> Now this is a pretty silly scenario as there already is a wlan0
> interface. Admittedly, this should be rejected as such. This clearly is
> a user mistake (not sure why you quoted that :-p ) and it might be good
> to catch this in cfg80211 as it probably applies to other drivers as
> well. This probably explains why register_netdev fails.
I don't think that's easy to catch - but the driver really should just
see that register_netdev fails and do nothing (except for reporting the
error back), no?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
next prev parent reply other threads:[~2015-06-22 8:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-21 19:59 brcmfmac: one faulty "iw interface add" command breaks in-firmware BSS state Rafał Miłecki
2015-06-22 7:47 ` Arend van Spriel
2015-06-22 8:03 ` Johannes Berg [this message]
2015-06-22 8:20 ` Arend van Spriel
2015-06-22 8:23 ` Johannes Berg
2015-06-22 8:06 ` Rafał Miłecki
2015-07-07 21:24 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434960206.19597.6.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.