Re: brcmfmac: one faulty "iw interface add" command breaks in-firmware BSS state

[Arend van Spriel <arend@broadcom.com>]

On 06/22/15 10:03, Johannes Berg wrote:
> On Mon, 2015-06-22 at 09:47 +0200, Arend van Spriel wrote:
>
>>> # iw phy phy0 interface add wlan0 type __ap
>>
>> Now this is a pretty silly scenario as there already is a wlan0
>> interface. Admittedly, this should be rejected as such. This clearly is
>> a user mistake (not sure why you quoted that :-p ) and it might be good
>> to catch this in cfg80211 as it probably applies to other drivers as
>> well. This probably explains why register_netdev fails.
>
> I don't think that's easy to catch - but the driver really should just
> see that register_netdev fails and do nothing (except for reporting the
> error back), no?

Indeed there is an issue with error handling here, but as this was a 
user fault I was looking for early detection. If as you say that will 
not be easy from cfg80211 we will need to rework brcmfmac code. 
Currently, we create interface in firmware and upon receiving 'ifc 
created' event we do the register_netdev. I think we do that to avoid 
getting start_xmit calls as we do not use netif carrier calls.

Regards,
Arend
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in