From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Dilger, Andreas" <andreas.dilger@intel.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
"Drokin, Oleg" <oleg.drokin@intel.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lustre-devel@lists.lustre.org" <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure
Date: Tue, 23 Jun 2015 22:11:23 +0000 [thread overview]
Message-ID: <1435097483.2504.10.camel@perches.com> (raw)
In-Reply-To: <20150623092303.GN28762@mwanda>
On Tue, 2015-06-23 at 12:23 +0300, Dan Carpenter wrote:
> people decided that
> Yoda code was a good idea based on their gut instead of using statistics
> and measurements and science.
I think that style exists because compilers
disallow CONST = val assignment typos.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure
Date: Tue, 23 Jun 2015 15:11:23 -0700 [thread overview]
Message-ID: <1435097483.2504.10.camel@perches.com> (raw)
In-Reply-To: <20150623092303.GN28762@mwanda>
On Tue, 2015-06-23 at 12:23 +0300, Dan Carpenter wrote:
> people decided that
> Yoda code was a good idea based on their gut instead of using statistics
> and measurements and science.
I think that style exists because compilers
disallow CONST = val assignment typos.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Dilger, Andreas" <andreas.dilger@intel.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
"Drokin, Oleg" <oleg.drokin@intel.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lustre-devel@lists.lustre.org" <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure
Date: Tue, 23 Jun 2015 15:11:23 -0700 [thread overview]
Message-ID: <1435097483.2504.10.camel@perches.com> (raw)
In-Reply-To: <20150623092303.GN28762@mwanda>
On Tue, 2015-06-23 at 12:23 +0300, Dan Carpenter wrote:
> people decided that
> Yoda code was a good idea based on their gut instead of using statistics
> and measurements and science.
I think that style exists because compilers
disallow CONST = val assignment typos.
next prev parent reply other threads:[~2015-06-23 22:11 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 16:58 [PATCH 00/12] Use !x to check for kzalloc failure Julia Lawall
2015-06-20 16:58 ` Julia Lawall
2015-06-20 16:58 ` [PATCH 01/12] staging: lustre: fid: " Julia Lawall
2015-06-20 16:58 ` Julia Lawall
2015-06-22 15:46 ` [lustre-devel] Fwd: [HPDD-discuss] " Patrick Farrell
2015-06-22 17:18 ` Simmons, James A.
2015-06-23 8:05 ` Dilger, Andreas
2015-06-23 8:25 ` Dilger, Andreas
2015-06-23 8:25 ` Dilger, Andreas
2015-06-23 8:25 ` [lustre-devel] " Dilger, Andreas
2015-06-23 9:23 ` Dan Carpenter
2015-06-23 9:23 ` Dan Carpenter
2015-06-23 9:23 ` [lustre-devel] " Dan Carpenter
2015-06-23 9:35 ` Julia Lawall
2015-06-23 9:35 ` Julia Lawall
2015-06-23 9:35 ` [lustre-devel] " Julia Lawall
2015-06-23 9:57 ` Dan Carpenter
2015-06-23 9:57 ` Dan Carpenter
2015-06-23 9:57 ` [lustre-devel] " Dan Carpenter
2015-06-23 10:51 ` Julia Lawall
2015-06-23 10:51 ` Julia Lawall
2015-06-23 10:51 ` [lustre-devel] " Julia Lawall
2015-06-24 20:14 ` Simmons, James A.
2015-06-24 20:14 ` Simmons, James A.
2015-06-24 20:14 ` Simmons, James A.
2015-06-23 22:03 ` Joe Perches
2015-06-23 22:03 ` Joe Perches
2015-06-23 22:03 ` [lustre-devel] " Joe Perches
2015-06-23 22:11 ` Joe Perches [this message]
2015-06-23 22:11 ` Joe Perches
2015-06-23 22:11 ` [lustre-devel] " Joe Perches
2015-06-28 6:52 ` LIBCFS_ALLOC Julia Lawall
2015-06-28 6:52 ` LIBCFS_ALLOC Julia Lawall
2015-06-28 6:52 ` [lustre-devel] LIBCFS_ALLOC Julia Lawall
2015-06-28 21:54 ` LIBCFS_ALLOC Dan Carpenter
2015-06-28 21:54 ` LIBCFS_ALLOC Dan Carpenter
2015-06-28 21:54 ` [lustre-devel] LIBCFS_ALLOC Dan Carpenter
2015-06-30 14:56 ` LIBCFS_ALLOC Simmons, James A.
2015-06-30 14:56 ` [lustre-devel] LIBCFS_ALLOC Simmons, James A.
2015-06-30 15:01 ` LIBCFS_ALLOC Julia Lawall
2015-06-30 15:01 ` LIBCFS_ALLOC Julia Lawall
2015-06-30 15:01 ` [lustre-devel] LIBCFS_ALLOC Julia Lawall
2015-07-02 22:25 ` Simmons, James A.
2015-07-02 22:25 ` Simmons, James A.
2015-07-02 22:25 ` Simmons, James A.
2015-07-03 11:52 ` Dilger, Andreas
2015-07-03 11:52 ` Dilger, Andreas
2015-07-03 11:52 ` Dilger, Andreas
2015-06-30 17:38 ` LIBCFS_ALLOC Dan Carpenter
2015-06-30 17:38 ` LIBCFS_ALLOC Dan Carpenter
2015-06-30 17:38 ` [lustre-devel] LIBCFS_ALLOC Dan Carpenter
2015-06-30 21:26 ` Dilger, Andreas
2015-06-30 21:26 ` Dilger, Andreas
2015-06-20 16:59 ` [PATCH 02/12] staging: lustre: fld: Use !x to check for kzalloc failure Julia Lawall
2015-06-20 16:59 ` Julia Lawall
2015-06-20 16:59 ` [PATCH 03/12] staging: lustre: lclient: " Julia Lawall
2015-06-20 16:59 ` Julia Lawall
2015-06-20 16:59 ` [PATCH 04/12] staging: lustre: ldlm: " Julia Lawall
2015-06-20 16:59 ` Julia Lawall
2015-06-20 16:59 ` [PATCH 05/12] staging: lustre: lmv: " Julia Lawall
2015-06-20 16:59 ` Julia Lawall
2015-06-20 16:59 ` [PATCH 06/12] staging: lustre: lov: " Julia Lawall
2015-06-20 16:59 ` Julia Lawall
2015-06-20 16:59 ` [PATCH 07/12] staging: lustre: mdc: " Julia Lawall
2015-06-20 16:59 ` Julia Lawall
2015-06-20 16:59 ` [PATCH 08/12] staging: lustre: mgc: " Julia Lawall
2015-06-20 16:59 ` Julia Lawall
2015-06-20 16:59 ` [PATCH 09/12] staging: lustre: obdclass: " Julia Lawall
2015-06-20 16:59 ` Julia Lawall
2015-06-21 10:02 ` walter harms
2015-06-21 10:02 ` walter harms
2015-06-21 10:29 ` Julia Lawall
2015-06-21 10:29 ` Julia Lawall
2015-06-21 11:58 ` walter harms
2015-06-20 16:59 ` [PATCH 10/12] staging: lustre: obdecho: " Julia Lawall
2015-06-20 16:59 ` Julia Lawall
2015-06-20 16:59 ` [PATCH 11/12] staging: lustre: osc: " Julia Lawall
2015-06-20 16:59 ` Julia Lawall
2015-06-20 16:59 ` [PATCH 12/12] staging: lustre: ptlrpc: " Julia Lawall
2015-06-20 16:59 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435097483.2504.10.camel@perches.com \
--to=joe@perches.com \
--cc=Julia.Lawall@lip6.fr \
--cc=andreas.dilger@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.