All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	Greg Donald <gdonald@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH -next] checkpatch: Fix long line messages about patch context
Date: Wed, 24 Jun 2015 07:55:20 -0700	[thread overview]
Message-ID: <1435157720.9377.11.camel@perches.com> (raw)
In-Reply-To: <20150624144325.GL30834@mwanda>

Changes in ("checkpatch: categorize some long line length checks")
now erroneously reports long line defects in patch context.

Fix it.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Joe Perches <joe@perches.com>
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 90e1edc..d5c8e9a 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2599,7 +2599,7 @@ sub process {
 # if LONG_LINE is ignored, the other 2 types are also ignored
 #
 
-		if ($length > $max_line_length) {
+		if ($line =~ /^\+/ && $length > $max_line_length) {
 			my $msg_type = "LONG_LINE";
 
 			# Check the allowed long line types first



  parent reply	other threads:[~2015-06-24 14:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-20 20:56 [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors Greg Donald
2015-06-22 11:10 ` Sudip Mukherjee
2015-06-22 11:25   ` Greg Donald
2015-06-23  8:01     ` Dan Carpenter
2015-06-23 22:52       ` Greg Donald
     [not found]         ` <1435100814.2504.23.camel@perches.com>
     [not found]           ` <20150624093722.GK30834@mwanda>
     [not found]             ` <1435156387.9377.3.camel@perches.com>
     [not found]               ` <20150624144325.GL30834@mwanda>
2015-06-24 14:55                 ` Joe Perches [this message]
2015-07-15  2:42 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435157720.9377.11.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=gdonald@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.