From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Greg Donald <gdonald@gmail.com>
Cc: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors
Date: Tue, 14 Jul 2015 19:42:54 -0700 [thread overview]
Message-ID: <20150715024254.GA12308@kroah.com> (raw)
In-Reply-To: <1434833768-8336-1-git-send-email-gdonald@gmail.com>
On Sat, Jun 20, 2015 at 03:56:08PM -0500, Greg Donald wrote:
> Fix checkpatch.pl "space required before the open parenthesis '('" errors
>
> Signed-off-by: Greg Donald <gdonald@gmail.com>
> ---
> .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 97 ++++++++++------------
> 1 file changed, 44 insertions(+), 53 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> index c2588f8..df20979 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> @@ -66,7 +66,7 @@ void HTUpdateDefaultSetting(struct ieee80211_device *ieee)
> pHTInfo->bRegBW40MHz = 1;
>
> // CCK rate support in 40MHz channel
> - if(pHTInfo->bRegBW40MHz)
> + if (pHTInfo->bRegBW40MHz)
> pHTInfo->bRegSuppCCK = 1;
> else
> pHTInfo->bRegSuppCCK = true;
> @@ -82,7 +82,7 @@ void HTUpdateDefaultSetting(struct ieee80211_device *ieee)
>
> // MIMO Power Save
> pHTInfo->SelfMimoPs = 3;// 0: Static Mimo Ps, 1: Dynamic Mimo Ps, 3: No Limitation, 2: Reserved(Set to 3 automatically.)
> - if(pHTInfo->SelfMimoPs == 2)
> + if (pHTInfo->SelfMimoPs == 2)
> pHTInfo->SelfMimoPs = 3;
> // 8190 only. Assign rate operation mode to firmware
> ieee->bTxDisableRateFallBack = 0;
> @@ -127,8 +127,7 @@ void HTDebugHTCapability(u8 *CapIE, u8 *TitleString )
> static u8 EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33}; // For 11n EWC definition, 2007.07.17, by Emily
> PHT_CAPABILITY_ELE pCapELE;
>
> - if(!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap)))
> - {
> + if (!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap))) {
Like others have pointed out, this is something different than what you
are saying you are doing, please break this up into different patches.
thanks,
greg k-h
prev parent reply other threads:[~2015-07-15 2:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 20:56 [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors Greg Donald
2015-06-22 11:10 ` Sudip Mukherjee
2015-06-22 11:25 ` Greg Donald
2015-06-23 8:01 ` Dan Carpenter
2015-06-23 22:52 ` Greg Donald
[not found] ` <1435100814.2504.23.camel@perches.com>
[not found] ` <20150624093722.GK30834@mwanda>
[not found] ` <1435156387.9377.3.camel@perches.com>
[not found] ` <20150624144325.GL30834@mwanda>
2015-06-24 14:55 ` [PATCH -next] checkpatch: Fix long line messages about patch context Joe Perches
2015-07-15 2:42 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715024254.GA12308@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cristina.opriceana@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=hamohammed.sa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mahfouz.saif.elyazal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.