All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] OSSTest: some more info when capturing logs
Date: Thu, 25 Jun 2015 10:27:21 +0100	[thread overview]
Message-ID: <1435224441.32500.4.camel@citrix.com> (raw)
In-Reply-To: <1435223479.25170.146.camel@citrix.com>

On Thu, 2015-06-25 at 11:11 +0200, Dario Faggioli wrote:
> On Thu, 2015-06-25 at 09:48 +0100, Ian Campbell wrote:
> > On Wed, 2015-06-24 at 18:11 +0200, Dario Faggioli wrote:
> > > more specifically:
> > > 
> > >  * '-n' switch to xl info, to show the topology
> > >    of the host,
> > 
> > Is the information from "xl info -n" a superset of that from "xl info"?
> >
> Yes.
> 
> > IOW could we just collect xl info -n and be done with it?
> > 
> That's what the patch is doing:
> 
> > > @@ -153,9 +153,10 @@ sub fetch_logs_host_guests () {
> > >  
> > >      foreach my $cmd
> > >          (
> > > -         'xl info',
> > > +         'xl info -n',
> >
> Perhaps the changelog was not so clear... in this case, "more info"
> applies right because adding '-n' adds information, wrt not using it, or
> at least that was what I meant.
> 
> Should I clarify and resend?

No need, I should just learn to read a diff properly, sorry.

Acked-by: Ian Campbell <ian.campbell@citrix.com>

      reply	other threads:[~2015-06-25  9:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-24 16:11 [PATCH] OSSTest: some more info when capturing logs Dario Faggioli
2015-06-25  8:48 ` Ian Campbell
2015-06-25  9:11   ` Dario Faggioli
2015-06-25  9:27     ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435224441.32500.4.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=dario.faggioli@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.