From: Ian Campbell <ian.campbell@citrix.com>
To: Rob Hoes <rob.hoes@citrix.com>
Cc: xen-devel@lists.xenproject.org, euan.harris@citrix.com,
Ian.Jackson@eu.citrix.com
Subject: Re: [PATCH RFC 1/9] libxl idl: add comments to error enum
Date: Thu, 25 Jun 2015 16:58:10 +0100 [thread overview]
Message-ID: <1435247890.32500.100.camel@citrix.com> (raw)
In-Reply-To: <1435153656-19485-2-git-send-email-rob.hoes@citrix.com>
On Wed, 2015-06-24 at 14:47 +0100, Rob Hoes wrote:
> Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
> ---
> tools/libxl/libxl_types.idl | 41 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index 65d479f..6dc18fa 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libxl/libxl_types.idl
> @@ -44,26 +44,67 @@ MemKB = UInt(64, init_val = "LIBXL_MEMKB_DEFAULT", json_gen_fn = "libxl__uint64_
> #
>
> libxl_error = Enumeration("error", [
> + # Generic failure; code should be avoided (often seen as "rc = -1")
> (-1, "NONSPECIFIC"),
I wonder if we should extend the Enumeration IDL support to have an
optional 3rd field (or a named param) containing a textual description,
which could then be used to autogenerate an analogue of sterrror(3) for
enums which include such things?
next prev parent reply other threads:[~2015-06-25 15:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 13:47 [PATCH RFC 0/9] libxl error reporting Rob Hoes
2015-06-24 13:47 ` [PATCH RFC 1/9] libxl idl: add comments to error enum Rob Hoes
2015-06-24 15:06 ` Ian Jackson
2015-06-26 14:12 ` Rob Hoes
2015-06-26 14:26 ` Ian Campbell
2015-06-26 14:33 ` Ian Jackson
2015-06-30 12:19 ` Ian Campbell
2015-06-25 15:58 ` Ian Campbell [this message]
2015-06-25 16:36 ` Ian Jackson
2015-06-24 13:47 ` [PATCH RFC 2/9] libxl idl: allow implicit enum values Rob Hoes
2015-06-24 15:08 ` Ian Jackson
2015-06-25 15:59 ` Ian Campbell
2015-06-26 14:20 ` Rob Hoes
2015-06-24 13:47 ` [PATCH RFC 3/9] libxl: introduce specific xenstore error codes Rob Hoes
2015-06-24 15:10 ` Ian Jackson
2015-06-26 14:36 ` Rob Hoes
2015-06-26 14:42 ` Rob Hoes
2015-06-24 13:47 ` [PATCH RFC 4/9] libxl: use explicit error codes in libxl_ctx_alloc Rob Hoes
2015-06-24 15:18 ` Ian Jackson
2015-06-24 13:47 ` [PATCH RFC 5/9] libxl: introduce specific JSON error codes Rob Hoes
2015-06-24 15:20 ` Ian Jackson
2015-06-24 13:47 ` [PATCH RFC 6/9] libxl: introduce specific error code for libxl__wait_device_connection Rob Hoes
2015-06-24 15:30 ` Ian Jackson
2015-06-24 13:47 ` [PATCH RFC 7/9] libxl: introduce specific error codes in libxl_device_disk_add Rob Hoes
2015-06-24 15:28 ` Ian Jackson
2015-06-26 16:49 ` Rob Hoes
2015-06-24 13:47 ` [PATCH RFC 8/9] libxl: introduce specific error codes in libxl_device_cdrom_insert Rob Hoes
2015-06-24 15:26 ` Ian Jackson
2015-06-26 16:27 ` Rob Hoes
2015-06-24 13:47 ` [PATCH RFC 9/9] libxl: introduce specific error codes in libxl_device_nic_add Rob Hoes
2015-06-24 15:11 ` Ian Jackson
2015-06-26 16:36 ` Rob Hoes
2015-06-24 15:16 ` [PATCH RFC 0/9] libxl error reporting Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435247890.32500.100.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=euan.harris@citrix.com \
--cc=rob.hoes@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.