All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Yang Hongyang <yanghy@cn.fujitsu.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	xen devel <xen-devel@lists.xen.org>
Subject: Re: fix building error
Date: Tue, 30 Jun 2015 09:26:35 +0100	[thread overview]
Message-ID: <1435652795.21469.2.camel@citrix.com> (raw)
In-Reply-To: <559232B9.3060403@cn.fujitsu.com>

On Tue, 2015-06-30 at 14:10 +0800, Wen Congyang wrote:

It would be usual do describe here which commit caused the breakage
(i.e. removed the parameter). Also please make the subject something
more descriptive such as "remove now unnecessary gc from
libxl__async_exec_start calls" e.g.

Subject: remove now unnecessary gc from libxl__async_exec_start calls

These were removed in commit XXXXXX.

> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> ---
>  tools/libxl/libxl_netbuffer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/libxl/libxl_netbuffer.c b/tools/libxl/libxl_netbuffer.c
> index ff2d6c7..107e867 100644
> --- a/tools/libxl/libxl_netbuffer.c
> +++ b/tools/libxl/libxl_netbuffer.c
> @@ -310,7 +310,7 @@ static void nic_setup(libxl__egc *egc, libxl__remus_device *dev)
>      }
>  
>      setup_async_exec(dev, "setup");
> -    rc = libxl__async_exec_start(gc, &dev->aodev.aes);
> +    rc = libxl__async_exec_start(&dev->aodev.aes);
>      if (rc)
>          goto out;
>  
> @@ -402,7 +402,7 @@ static void nic_teardown(libxl__egc *egc, libxl__remus_device *dev)
>  
>      setup_async_exec(dev, "teardown");
>  
> -    rc = libxl__async_exec_start(gc, &dev->aodev.aes);
> +    rc = libxl__async_exec_start(&dev->aodev.aes);
>      if (rc)
>          goto out;
>  

  reply	other threads:[~2015-06-30  8:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30  6:10 fix building error Wen Congyang
2015-06-30  8:26 ` Ian Campbell [this message]
2015-06-30  8:55   ` Wen Congyang
2015-06-30  8:56     ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435652795.21469.2.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=wency@cn.fujitsu.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yanghy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.