* fix building error
@ 2015-06-30 6:10 Wen Congyang
2015-06-30 8:26 ` Ian Campbell
0 siblings, 1 reply; 4+ messages in thread
From: Wen Congyang @ 2015-06-30 6:10 UTC (permalink / raw)
To: Ian Campbell, Ian Jackson, Yang Hongyang, xen devel
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
---
tools/libxl/libxl_netbuffer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/libxl_netbuffer.c b/tools/libxl/libxl_netbuffer.c
index ff2d6c7..107e867 100644
--- a/tools/libxl/libxl_netbuffer.c
+++ b/tools/libxl/libxl_netbuffer.c
@@ -310,7 +310,7 @@ static void nic_setup(libxl__egc *egc, libxl__remus_device *dev)
}
setup_async_exec(dev, "setup");
- rc = libxl__async_exec_start(gc, &dev->aodev.aes);
+ rc = libxl__async_exec_start(&dev->aodev.aes);
if (rc)
goto out;
@@ -402,7 +402,7 @@ static void nic_teardown(libxl__egc *egc, libxl__remus_device *dev)
setup_async_exec(dev, "teardown");
- rc = libxl__async_exec_start(gc, &dev->aodev.aes);
+ rc = libxl__async_exec_start(&dev->aodev.aes);
if (rc)
goto out;
--
2.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: fix building error
2015-06-30 6:10 fix building error Wen Congyang
@ 2015-06-30 8:26 ` Ian Campbell
2015-06-30 8:55 ` Wen Congyang
0 siblings, 1 reply; 4+ messages in thread
From: Ian Campbell @ 2015-06-30 8:26 UTC (permalink / raw)
To: Wen Congyang; +Cc: Yang Hongyang, Ian Jackson, xen devel
On Tue, 2015-06-30 at 14:10 +0800, Wen Congyang wrote:
It would be usual do describe here which commit caused the breakage
(i.e. removed the parameter). Also please make the subject something
more descriptive such as "remove now unnecessary gc from
libxl__async_exec_start calls" e.g.
Subject: remove now unnecessary gc from libxl__async_exec_start calls
These were removed in commit XXXXXX.
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> ---
> tools/libxl/libxl_netbuffer.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/libxl/libxl_netbuffer.c b/tools/libxl/libxl_netbuffer.c
> index ff2d6c7..107e867 100644
> --- a/tools/libxl/libxl_netbuffer.c
> +++ b/tools/libxl/libxl_netbuffer.c
> @@ -310,7 +310,7 @@ static void nic_setup(libxl__egc *egc, libxl__remus_device *dev)
> }
>
> setup_async_exec(dev, "setup");
> - rc = libxl__async_exec_start(gc, &dev->aodev.aes);
> + rc = libxl__async_exec_start(&dev->aodev.aes);
> if (rc)
> goto out;
>
> @@ -402,7 +402,7 @@ static void nic_teardown(libxl__egc *egc, libxl__remus_device *dev)
>
> setup_async_exec(dev, "teardown");
>
> - rc = libxl__async_exec_start(gc, &dev->aodev.aes);
> + rc = libxl__async_exec_start(&dev->aodev.aes);
> if (rc)
> goto out;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: fix building error
2015-06-30 8:26 ` Ian Campbell
@ 2015-06-30 8:55 ` Wen Congyang
2015-06-30 8:56 ` Ian Jackson
0 siblings, 1 reply; 4+ messages in thread
From: Wen Congyang @ 2015-06-30 8:55 UTC (permalink / raw)
To: Ian Campbell; +Cc: Yang Hongyang, Ian Jackson, xen devel
On 06/30/2015 04:26 PM, Ian Campbell wrote:
> On Tue, 2015-06-30 at 14:10 +0800, Wen Congyang wrote:
>
> It would be usual do describe here which commit caused the breakage
> (i.e. removed the parameter). Also please make the subject something
> more descriptive such as "remove now unnecessary gc from
> libxl__async_exec_start calls" e.g.
>
> Subject: remove now unnecessary gc from libxl__async_exec_start calls
>
> These were removed in commit XXXXXX.
OK, I will repost it.
Thanks
Wen Congyang
>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>> ---
>> tools/libxl/libxl_netbuffer.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/libxl/libxl_netbuffer.c b/tools/libxl/libxl_netbuffer.c
>> index ff2d6c7..107e867 100644
>> --- a/tools/libxl/libxl_netbuffer.c
>> +++ b/tools/libxl/libxl_netbuffer.c
>> @@ -310,7 +310,7 @@ static void nic_setup(libxl__egc *egc, libxl__remus_device *dev)
>> }
>>
>> setup_async_exec(dev, "setup");
>> - rc = libxl__async_exec_start(gc, &dev->aodev.aes);
>> + rc = libxl__async_exec_start(&dev->aodev.aes);
>> if (rc)
>> goto out;
>>
>> @@ -402,7 +402,7 @@ static void nic_teardown(libxl__egc *egc, libxl__remus_device *dev)
>>
>> setup_async_exec(dev, "teardown");
>>
>> - rc = libxl__async_exec_start(gc, &dev->aodev.aes);
>> + rc = libxl__async_exec_start(&dev->aodev.aes);
>> if (rc)
>> goto out;
>>
>
>
> .
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: fix building error
2015-06-30 8:55 ` Wen Congyang
@ 2015-06-30 8:56 ` Ian Jackson
0 siblings, 0 replies; 4+ messages in thread
From: Ian Jackson @ 2015-06-30 8:56 UTC (permalink / raw)
To: Wen Congyang; +Cc: Yang Hongyang, Ian Campbell, xen devel
Wen Congyang writes ("Re: fix building error"):
> On 06/30/2015 04:26 PM, Ian Campbell wrote:
> > On Tue, 2015-06-30 at 14:10 +0800, Wen Congyang wrote:
> >
> > It would be usual do describe here which commit caused the breakage
> > (i.e. removed the parameter). Also please make the subject something
> > more descriptive such as "remove now unnecessary gc from
> > libxl__async_exec_start calls" e.g.
> >
> > Subject: remove now unnecessary gc from libxl__async_exec_start calls
> >
> > These were removed in commit XXXXXX.
This is my fault, in f5f8400f
"libxl: events: Make timeout and async exec setup take an ao, not a gc"
> OK, I will repost it.
Thanks. Sorry for breaking the build.
Ian.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-30 8:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-30 6:10 fix building error Wen Congyang
2015-06-30 8:26 ` Ian Campbell
2015-06-30 8:55 ` Wen Congyang
2015-06-30 8:56 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.