All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Yang Hongyang <yanghy@cn.fujitsu.com>,
	Wen Congyang <wency@cn.fujitsu.com>,
	xen devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2] remove now unnecessary gc from libxl__async_exec_start calls
Date: Tue, 30 Jun 2015 10:47:24 +0100	[thread overview]
Message-ID: <1435657644.21469.54.camel@citrix.com> (raw)
In-Reply-To: <21906.25633.308879.107153@mariner.uk.xensource.com>

On Tue, 2015-06-30 at 10:40 +0100, Ian Jackson wrote:
> Andrew Cooper writes ("Re: [Xen-devel] [PATCH v2] remove now unnecessary gc from libxl__async_exec_start calls"):
> > On 30/06/15 09:55, Wen Congyang wrote:
> > > These were removed in commit f5f8400f.
> ...
> > > -    rc = libxl__async_exec_start(gc, &dev->aodev.aes);
> > > +    rc = libxl__async_exec_start(&dev->aodev.aes);
> > 
> > Can OSS test be updated to build the remus bits of libxl?  This failure
> > should not have been able to pass the push gate.
> 
> I haven't investigated why this is disabled in osstest's builds.

Roger was jsut asking about libnl-dev and ts-xen-build-prep on IRC. I
suspect he may be investigating...

> Did you check one of its build logs ?  They contain the `configure'
> output.

Roger pointed at 
http://logs.test-lab.xenproject.org/osstest/logs/58974/build-amd64/5.ts-xen-build.log

Which has:
        Checking for LIBNL3... no
        configure: WARNING: Disabling support for Remus network buffering.
            Please install libnl3 libraries, command line tools and devel
            headers - version 3.2.8 or higher
        
But Wheezy has libnl-dev 1.1-7, which I think it might just be too old.
It also has libnl-3-dev which is 3.2.7 in Wheezy, i.e. still not quite
new enough.

Jessie has 3.2.24 which will be more than sufficient.

I think the upshot is that it is pointless installing libnl-dev on
Wheezy, at least for current Xen maybe older branches worked with older
libnl, I didn't check...

Ian.

      reply	other threads:[~2015-06-30  9:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30  8:55 [PATCH v2] remove now unnecessary gc from libxl__async_exec_start calls Wen Congyang
2015-06-30  9:16 ` Ian Jackson
2015-06-30  9:19 ` Andrew Cooper
2015-06-30  9:40   ` Ian Jackson
2015-06-30  9:47     ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435657644.21469.54.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=wency@cn.fujitsu.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yanghy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.