Re: [PATCH v2 1/7] libxl: get rid of the SEDF scheduler

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1040 bytes --]

On Fri, 2015-07-03 at 15:23 +0100, Ian Campbell wrote:
> On Fri, 2015-07-03 at 12:24 +0200, Dario Faggioli wrote:
> 
> > @@ -5932,7 +5865,8 @@ int libxl_domain_sched_params_set(libxl_ctx *ctx, uint32_t domid,
> >  
> >      switch (sched) {
> >      case LIBXL_SCHEDULER_SEDF:
> > -        ret=sched_sedf_domain_set(gc, domid, scinfo);
> > +        LOG(ERROR, "SEDF scheduler no longer available");
> > +        ret=ERROR_INVAL;
> 
> Should we have a specific error code for removed functionality?
> 
Good point: shall I introduce it? If yes, how should it be called?

ERROR_REMOVED
ERROR_DEPRECATED
ERROR_GONE

I think I'd go for _REMOVED, as deprecated suggests (to me at least)
that it's still there but nshould not be used.

Any other ideas?

Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel