All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Mike Rapoport <rppt@kernel.org>
Cc: linux-mm <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	anton ivanov <anton.ivanov@cambridgegreys.com>,
	Arnd Bergmann <arnd@arndb.de>, davem <davem@davemloft.net>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greentime Hu <green.hu@gmail.com>,
	Greg Ungerer <gerg@linux-m68k.org>, Helge Deller <deller@gmx.de>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Jeff Dike <jdike@addtoit.com>,
	"Kirill A. Shutemov" <kirill@shutemov.name>,
	torvalds <torvalds@linux-foundation.org>,
	Mark Salter <msalter@redhat.com>,
	Matt Turner <mattst88@gmail.com>, Michal Simek <monstr@monstr.eu>,
	Peter Rosin <peda@axentia.se>,
	Rolf Eike Beer <eike-kernel@sf-tec.de>,
	Russell King <linux@armlinux.org.uk>,
	Sam Creasey <sammy@sammy.net>,
	Vin
Subject: Re: [PATCH v2 12/13] um: add support for folded p4d page tables
Date: Fri, 1 Nov 2019 10:20:09 +0100 (CET)	[thread overview]
Message-ID: <1435962204.69872.1572600009245.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <1572597584-6390-13-git-send-email-rppt@kernel.org>

----- Ursprüngliche Mail -----
> Von: "Mike Rapoport" <rppt@kernel.org>

[...]

> #define pte_page(x) pfn_to_page(pte_pfn(x))
> diff --git a/arch/um/kernel/mem.c b/arch/um/kernel/mem.c
> index 417ff64..6fd17bc 100644
> --- a/arch/um/kernel/mem.c
> +++ b/arch/um/kernel/mem.c
> @@ -92,10 +92,26 @@ static void __init one_md_table_init(pud_t *pud)
> #endif
> }
> 
> +static void __init one_pud_table_init(p4d_t *p4d)
> +{
> +#if CONFIG_PGTABLE_LEVELS > 3

Isn't this dead code?

For uml we have:
config PGTABLE_LEVELS
        int
        default 3 if 3_LEVEL_PGTABLES
        default 2

Thanks,
//richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Mike Rapoport <rppt@kernel.org>
Cc: linux-mm <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	anton ivanov <anton.ivanov@cambridgegreys.com>,
	Arnd Bergmann <arnd@arndb.de>, davem <davem@davemloft.net>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greentime Hu <green.hu@gmail.com>,
	Greg Ungerer <gerg@linux-m68k.org>, Helge Deller <deller@gmx.de>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Jeff Dike <jdike@addtoit.com>,
	"Kirill A. Shutemov" <kirill@shutemov.name>,
	torvalds <torvalds@linux-foundation.org>,
	Mark Salter <msalter@redhat.com>,
	Matt Turner <mattst88@gmail.com>, Michal Simek <monstr@monstr.eu>,
	Peter Rosin <peda@axentia.se>,
	Rolf Eike Beer <eike-kernel@sf-tec.de>,
	Russell King <linux@armlinux.org.uk>,
	Sam Creasey <sammy@sammy.net>,
	Vin
Subject: Re: [PATCH v2 12/13] um: add support for folded p4d page tables
Date: Fri, 1 Nov 2019 10:20:09 +0100 (CET)	[thread overview]
Message-ID: <1435962204.69872.1572600009245.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <1572597584-6390-13-git-send-email-rppt@kernel.org>

----- Ursprüngliche Mail -----
> Von: "Mike Rapoport" <rppt@kernel.org>

[...]

> #define pte_page(x) pfn_to_page(pte_pfn(x))
> diff --git a/arch/um/kernel/mem.c b/arch/um/kernel/mem.c
> index 417ff64..6fd17bc 100644
> --- a/arch/um/kernel/mem.c
> +++ b/arch/um/kernel/mem.c
> @@ -92,10 +92,26 @@ static void __init one_md_table_init(pud_t *pud)
> #endif
> }
> 
> +static void __init one_pud_table_init(p4d_t *p4d)
> +{
> +#if CONFIG_PGTABLE_LEVELS > 3

Isn't this dead code?

For uml we have:
config PGTABLE_LEVELS
        int
        default 3 if 3_LEVEL_PGTABLES
        default 2

Thanks,
//richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Mike Rapoport <rppt@kernel.org>
Cc: linux-mm <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	anton ivanov <anton.ivanov@cambridgegreys.com>,
	Arnd Bergmann <arnd@arndb.de>, davem <davem@davemloft.net>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greentime Hu <green.hu@gmail.com>,
	Greg Ungerer <gerg@linux-m68k.org>, Helge Deller <deller@gmx.de>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Jeff Dike <jdike@addtoit.com>,
	"Kirill A. Shutemov" <kirill@shutemov.name>,
	torvalds <torvalds@linux-foundation.org>,
	Mark Salter <msalter@redhat.com>,
	Matt Turner <mattst88@gmail.com>, Michal Simek <monstr@monstr.eu>,
	Peter Rosin <peda@axentia.se>,
	Rolf Eike Beer <eike-kernel@sf-tec.de>,
	Russell King <linux@armlinux.org.uk>,
	Sam Creasey <sammy@sammy.net>, Vincent Chen <deanbo422@gmail.com>,
	Vineet Gupta <Vineet.Gupta1@synopsys.com>,
	linux-alpha <linux-alpha@vger.kernel.org>,
	linux-arch <linux-arch@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-c6x-dev <linux-c6x-dev@linux-c6x.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-m68k <linux-m68k@lists.linux-m68k.org>,
	linux-parisc <linux-parisc@vger.kernel.org>,
	linux-um <linux-um@lists.infradead.org>,
	sparclinux <sparclinux@vger.kernel.org>,
	Mike Rapoport <rppt@linux.ibm.com>
Subject: Re: [PATCH v2 12/13] um: add support for folded p4d page tables
Date: Fri, 1 Nov 2019 10:20:09 +0100 (CET)	[thread overview]
Message-ID: <1435962204.69872.1572600009245.JavaMail.zimbra@nod.at> (raw)
Message-ID: <20191101092009.y4i0kLXXE37QG3XxVzq0UvB3KMCbDnxPODFUXKpijOY@z> (raw)
In-Reply-To: <1572597584-6390-13-git-send-email-rppt@kernel.org>

----- Ursprüngliche Mail -----
> Von: "Mike Rapoport" <rppt@kernel.org>

[...]

> #define pte_page(x) pfn_to_page(pte_pfn(x))
> diff --git a/arch/um/kernel/mem.c b/arch/um/kernel/mem.c
> index 417ff64..6fd17bc 100644
> --- a/arch/um/kernel/mem.c
> +++ b/arch/um/kernel/mem.c
> @@ -92,10 +92,26 @@ static void __init one_md_table_init(pud_t *pud)
> #endif
> }
> 
> +static void __init one_pud_table_init(p4d_t *p4d)
> +{
> +#if CONFIG_PGTABLE_LEVELS > 3

Isn't this dead code?

For uml we have:
config PGTABLE_LEVELS
        int
        default 3 if 3_LEVEL_PGTABLES
        default 2

Thanks,
//richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Mike Rapoport <rppt@kernel.org>
Cc: linux-mm <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	anton ivanov <anton.ivanov@cambridgegreys.com>,
	Arnd Bergmann <arnd@arndb.de>, davem <davem@davemloft.net>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greentime Hu <green.hu@gmail.com>,
	Greg Ungerer <gerg@linux-m68k.org>, Helge Deller <deller@gmx.de>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Jeff Dike <jdike@addtoit.com>,
	"Kirill A. Shutemov" <kirill@shutemov.name>,
	torvalds <torvalds@linux-foundation.org>,
	Mark Salter <msalter@redhat.com>,
	Matt Turner <mattst88@gmail.com>, Michal Simek <monstr@monstr.eu>,
	Peter Rosin <peda@axentia.se>,
	Rolf Eike Beer <eike-kernel@sf-tec.de>,
	Russell King <linux@armlinux.org.uk>,
	Sam Creasey <sammy@sammy.net>,
	Vin
Subject: Re: [PATCH v2 12/13] um: add support for folded p4d page tables
Date: Fri, 01 Nov 2019 09:20:09 +0000	[thread overview]
Message-ID: <1435962204.69872.1572600009245.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <1572597584-6390-13-git-send-email-rppt@kernel.org>

----- Ursprüngliche Mail -----
> Von: "Mike Rapoport" <rppt@kernel.org>

[...]

> #define pte_page(x) pfn_to_page(pte_pfn(x))
> diff --git a/arch/um/kernel/mem.c b/arch/um/kernel/mem.c
> index 417ff64..6fd17bc 100644
> --- a/arch/um/kernel/mem.c
> +++ b/arch/um/kernel/mem.c
> @@ -92,10 +92,26 @@ static void __init one_md_table_init(pud_t *pud)
> #endif
> }
> 
> +static void __init one_pud_table_init(p4d_t *p4d)
> +{
> +#if CONFIG_PGTABLE_LEVELS > 3

Isn't this dead code?

For uml we have:
config PGTABLE_LEVELS
        int
        default 3 if 3_LEVEL_PGTABLES
        default 2

Thanks,
//richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Mike Rapoport <rppt@kernel.org>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	linux-mm <linux-mm@kvack.org>,
	sparclinux <sparclinux@vger.kernel.org>,
	Rolf Eike Beer <eike-kernel@sf-tec.de>,
	Vincent Chen <deanbo422@gmail.com>,
	Greg Ungerer <gerg@linux-m68k.org>,
	anton ivanov <anton.ivanov@cambridgegreys.com>,
	linux-arch <linux-arch@vger.kernel.org>,
	linux-c6x-dev <linux-c6x-dev@linux-c6x.org>,
	Helge Deller <deller@gmx.de>,
	Russell King <linux@armlinux.org.uk>,
	Mike Rapoport <rppt@linux.ibm.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Mark Salter <msalter@redhat.com>,
	Matt Turner <mattst88@gmail.com>, Jeff Dike <jdike@addtoit.com>,
	Sam Creasey <sammy@sammy.net>, Arnd Bergmann <arnd@arndb.de>,
	Vineet Gupta <Vineet.Gupta1@synopsys.com>,
	linux-um <linux-um@lists.infradead.org>,
	linux-m68k <linux-m68k@lists.linux-m68k.org>,
	Greentime Hu <green.hu@gmail.com>,
	"Kirill A. Shutemov" <kirill@shutemov.name>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Michal Simek <monstr@monstr.eu>,
	linux-parisc <linux-parisc@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	davem <davem@davemloft.net>,
	linux-alpha <linux-alpha@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	torvalds <torvalds@linux-foundation.org>,
	Peter Rosin <peda@axentia.se>
Subject: Re: [PATCH v2 12/13] um: add support for folded p4d page tables
Date: Fri, 1 Nov 2019 10:20:09 +0100 (CET)	[thread overview]
Message-ID: <1435962204.69872.1572600009245.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <1572597584-6390-13-git-send-email-rppt@kernel.org>

----- Ursprüngliche Mail -----
> Von: "Mike Rapoport" <rppt@kernel.org>

[...]

> #define pte_page(x) pfn_to_page(pte_pfn(x))
> diff --git a/arch/um/kernel/mem.c b/arch/um/kernel/mem.c
> index 417ff64..6fd17bc 100644
> --- a/arch/um/kernel/mem.c
> +++ b/arch/um/kernel/mem.c
> @@ -92,10 +92,26 @@ static void __init one_md_table_init(pud_t *pud)
> #endif
> }
> 
> +static void __init one_pud_table_init(p4d_t *p4d)
> +{
> +#if CONFIG_PGTABLE_LEVELS > 3

Isn't this dead code?

For uml we have:
config PGTABLE_LEVELS
        int
        default 3 if 3_LEVEL_PGTABLES
        default 2

Thanks,
//richard

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-11-01  9:20 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-01  8:39 [PATCH v2 00/13] mm: remove __ARCH_HAS_4LEVEL_HACK Mike Rapoport
2019-11-01  8:39 ` Mike Rapoport
2019-11-01  8:39 ` Mike Rapoport
2019-11-01  8:39 ` Mike Rapoport
2019-11-01  8:39 ` [PATCH v2 01/13] alpha: use pgtable-nop4d instead of 4level-fixup Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  9:11   ` Kirill A. Shutemov
2019-11-01  9:11     ` Kirill A. Shutemov
2019-11-01  9:11     ` Kirill A. Shutemov
2019-11-01  9:11     ` Kirill A. Shutemov
2019-11-01 21:59     ` Mike Rapoport
2019-11-01 21:59       ` Mike Rapoport
2019-11-01 21:59       ` Mike Rapoport
2019-11-01 21:59       ` Mike Rapoport
2019-11-01  8:39 ` [PATCH v2 02/13] arm: nommu: use pgtable-nopud " Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39 ` [PATCH v2 03/13] c6x: " Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39 ` [PATCH v2 04/13] m68k: nommu: " Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39 ` [PATCH v2 05/13] m68k: mm: use pgtable-nopXd " Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39 ` [PATCH v2 06/13] microblaze: use pgtable-nopmd " Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39 ` [PATCH v2 07/13] nds32: " Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39 ` [PATCH v2 08/13] parisc: use pgtable-nopXd " Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39 ` [PATCH v2 09/13] parisc/hugetlb: " Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39 ` [PATCH v2 10/13] sparc32: use pgtable-nopud " Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39 ` [PATCH v2 11/13] um: remove unused pxx_offset_proc() and addr_pte() functions Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  9:12   ` Richard Weinberger
2019-11-01  9:12     ` Richard Weinberger
2019-11-01  9:12     ` Richard Weinberger
2019-11-01  9:12     ` Richard Weinberger
2019-11-01  9:12     ` Richard Weinberger
2019-11-01  8:39 ` [PATCH v2 12/13] um: add support for folded p4d page tables Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  9:20   ` Richard Weinberger [this message]
2019-11-01  9:20     ` Richard Weinberger
2019-11-01  9:20     ` Richard Weinberger
2019-11-01  9:20     ` Richard Weinberger
2019-11-01  9:20     ` Richard Weinberger
2019-11-01 10:14     ` rppt
2019-11-01 10:14       ` rppt
2019-11-01 10:14       ` rppt
2019-11-01 10:14       ` rppt
2019-11-01 10:14       ` rppt
2019-11-01  8:39 ` [PATCH v2 13/13] mm: remove __ARCH_HAS_4LEVEL_HACK and include/asm-generic/4level-fixup.h Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport
2019-11-01  8:39   ` Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435962204.69872.1572600009245.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=deller@gmx.de \
    --cc=eike-kernel@sf-tec.de \
    --cc=geert@linux-m68k.org \
    --cc=gerg@linux-m68k.org \
    --cc=green.hu@gmail.com \
    --cc=jdike@addtoit.com \
    --cc=kirill@shutemov.name \
    --cc=linux-mm@kvack.org \
    --cc=linux@armlinux.org.uk \
    --cc=mattst88@gmail.com \
    --cc=monstr@monstr.eu \
    --cc=msalter@redhat.com \
    --cc=peda@axentia.se \
    --cc=rppt@kernel.org \
    --cc=sammy@sammy.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.