All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dario Faggioli <dario.faggioli@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2] libxc: fix PV vNUMA guest memory allocation
Date: Mon, 6 Jul 2015 18:11:43 +0200	[thread overview]
Message-ID: <1436199103.10763.5.camel@citrix.com> (raw)
In-Reply-To: <1436190460-1354-1-git-send-email-wei.liu2@citrix.com>


[-- Attachment #1.1: Type: text/plain, Size: 1193 bytes --]

On Mon, 2015-07-06 at 14:47 +0100, Wei Liu wrote:
> In 415b58c1 (tools/libxc: Batch memory allocations for PV guests) the
> number of super pages is calculated with the number of total pages. That
> is wrong. It breaks PV guest vNUMA. The correct number of super pages
> should be derived from the number of pages within that virtual NUMA
> node.
> 
> Also change the name and type of super page variable to match the naming
> convention and type of normal page variable. Make the necessary
> adjustment to make code compile.
> 
> Reported-by: Dario Faggioli <dario.faggioli@citrix.com>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>
> ---
> v2: uint64_t for count variable for consistency, no functional changes wrt v1
>     so I retain the Reviewed-by tag.
> ---
>
Reviewed-and-Tested-by: Dario Faggioli <dario.faggioli@citrix.com>

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2015-07-06 16:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06 13:17 [PATCH 0/2] Two PV vNUMA patches Wei Liu
2015-07-06 13:17 ` [PATCH 1/2] libxc: remove trailing newline in xc_dom_panic format string Wei Liu
2015-07-06 15:38   ` Dario Faggioli
2015-07-06 13:17 ` [PATCH 2/2] libxc: fix PV vNUMA guest memory allocation Wei Liu
2015-07-06 13:22   ` Ross Lagerwall
2015-07-06 13:26   ` Andrew Cooper
2015-07-06 13:30     ` Wei Liu
2015-07-06 13:33       ` Ross Lagerwall
2015-07-06 13:39         ` Wei Liu
2015-07-06 13:47   ` [PATCH v2] " Wei Liu
2015-07-06 16:11     ` Dario Faggioli [this message]
2015-07-06 13:53   ` [PATCH 2/2] " Dario Faggioli
2015-07-07 15:19 ` [PATCH 0/2] Two PV vNUMA patches Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436199103.10763.5.camel@citrix.com \
    --to=dario.faggioli@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.