From: Koro Chen <koro.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
"open list:OPEN FIRMWARE AND..."
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Nicolas Boichat
<drinkcat-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
srv_heupstream
<srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH] arm64: dts: mt8173: Add afe device node
Date: Tue, 7 Jul 2015 17:20:09 +0800 [thread overview]
Message-ID: <1436260809.4347.2.camel@mtksdaap41> (raw)
In-Reply-To: <25205102.t939MQMDBD@ubix>
On Tue, 2015-07-07 at 09:46 +0200, Matthias Brugger wrote:
> On Monday, July 06, 2015 09:02:38 PM Daniel Kurtz wrote:
> > On Mon, Jul 6, 2015 at 2:52 PM, Koro Chen <koro.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote:
> > > This adds afe (audio front end) device node to the MT8173 dtsi file.
> > >
> > > This patch is based on Matthias's tree:
> > > https://github.com/mbgg/linux-mediatek
> > > branch: v4.2-next/arm64
> > >
> > > Signed-off-by: Koro Chen <koro.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > > ---
> > >
> > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 32
> > > ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > > b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 0696f8f..f8afab4 100644
> > > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > > @@ -14,6 +14,7 @@
> > >
> > > #include <dt-bindings/clock/mt8173-clk.h>
> > > #include <dt-bindings/interrupt-controller/irq.h>
> > > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > >
> > > +#include <dt-bindings/power/mt8173-power.h>
> > >
> > > #include <dt-bindings/reset-controller/mt8173-resets.h>
> > > #include "mt8173-pinfunc.h"
> > >
> > > @@ -393,6 +394,37 @@
> > >
> > > #size-cells = <0>;
> > > status = "disabled";
> > >
> > > };
> > >
> > > +
> > > + afe: mt8173-afe-pcm@11220000 {
> >
> > I believe this should be something generic, like:
> >
> > afe: audio-controller@11220000
> >
>
> Yes, please find a name that better describes the component instead of just
> using the compatible string.
>
Thanks both, I will change the name to audio-controller.
> Thanks.
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: koro.chen@mediatek.com (Koro Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: mt8173: Add afe device node
Date: Tue, 7 Jul 2015 17:20:09 +0800 [thread overview]
Message-ID: <1436260809.4347.2.camel@mtksdaap41> (raw)
In-Reply-To: <25205102.t939MQMDBD@ubix>
On Tue, 2015-07-07 at 09:46 +0200, Matthias Brugger wrote:
> On Monday, July 06, 2015 09:02:38 PM Daniel Kurtz wrote:
> > On Mon, Jul 6, 2015 at 2:52 PM, Koro Chen <koro.chen@mediatek.com> wrote:
> > > This adds afe (audio front end) device node to the MT8173 dtsi file.
> > >
> > > This patch is based on Matthias's tree:
> > > https://github.com/mbgg/linux-mediatek
> > > branch: v4.2-next/arm64
> > >
> > > Signed-off-by: Koro Chen <koro.chen@mediatek.com>
> > > ---
> > >
> > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 32
> > > ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > > b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 0696f8f..f8afab4 100644
> > > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > > @@ -14,6 +14,7 @@
> > >
> > > #include <dt-bindings/clock/mt8173-clk.h>
> > > #include <dt-bindings/interrupt-controller/irq.h>
> > > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > >
> > > +#include <dt-bindings/power/mt8173-power.h>
> > >
> > > #include <dt-bindings/reset-controller/mt8173-resets.h>
> > > #include "mt8173-pinfunc.h"
> > >
> > > @@ -393,6 +394,37 @@
> > >
> > > #size-cells = <0>;
> > > status = "disabled";
> > >
> > > };
> > >
> > > +
> > > + afe: mt8173-afe-pcm at 11220000 {
> >
> > I believe this should be something generic, like:
> >
> > afe: audio-controller at 11220000
> >
>
> Yes, please find a name that better describes the component instead of just
> using the compatible string.
>
Thanks both, I will change the name to audio-controller.
> Thanks.
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Koro Chen <koro.chen@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Daniel Kurtz <djkurtz@chromium.org>,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
Nicolas Boichat <drinkcat@chromium.org>,
srv_heupstream <srv_heupstream@mediatek.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<alsa-devel@alsa-project.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: mt8173: Add afe device node
Date: Tue, 7 Jul 2015 17:20:09 +0800 [thread overview]
Message-ID: <1436260809.4347.2.camel@mtksdaap41> (raw)
In-Reply-To: <25205102.t939MQMDBD@ubix>
On Tue, 2015-07-07 at 09:46 +0200, Matthias Brugger wrote:
> On Monday, July 06, 2015 09:02:38 PM Daniel Kurtz wrote:
> > On Mon, Jul 6, 2015 at 2:52 PM, Koro Chen <koro.chen@mediatek.com> wrote:
> > > This adds afe (audio front end) device node to the MT8173 dtsi file.
> > >
> > > This patch is based on Matthias's tree:
> > > https://github.com/mbgg/linux-mediatek
> > > branch: v4.2-next/arm64
> > >
> > > Signed-off-by: Koro Chen <koro.chen@mediatek.com>
> > > ---
> > >
> > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 32
> > > ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > > b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 0696f8f..f8afab4 100644
> > > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > > @@ -14,6 +14,7 @@
> > >
> > > #include <dt-bindings/clock/mt8173-clk.h>
> > > #include <dt-bindings/interrupt-controller/irq.h>
> > > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > >
> > > +#include <dt-bindings/power/mt8173-power.h>
> > >
> > > #include <dt-bindings/reset-controller/mt8173-resets.h>
> > > #include "mt8173-pinfunc.h"
> > >
> > > @@ -393,6 +394,37 @@
> > >
> > > #size-cells = <0>;
> > > status = "disabled";
> > >
> > > };
> > >
> > > +
> > > + afe: mt8173-afe-pcm@11220000 {
> >
> > I believe this should be something generic, like:
> >
> > afe: audio-controller@11220000
> >
>
> Yes, please find a name that better describes the component instead of just
> using the compatible string.
>
Thanks both, I will change the name to audio-controller.
> Thanks.
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2015-07-07 9:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 6:52 [PATCH] arm64: dts: mt8173: Add afe device node Koro Chen
2015-07-06 6:52 ` Koro Chen
2015-07-06 6:52 ` Koro Chen
2015-07-06 13:00 ` Daniel Kurtz
2015-07-06 13:02 ` Daniel Kurtz
2015-07-06 13:02 ` Daniel Kurtz
[not found] ` <CAGS+omCOzJs=VWboU_7doUum6BEfmh1hV88HmJiin2c-A_n_Mw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-07 7:46 ` Matthias Brugger
2015-07-07 7:46 ` Matthias Brugger
2015-07-07 7:46 ` Matthias Brugger
2015-07-07 9:20 ` Koro Chen [this message]
2015-07-07 9:20 ` Koro Chen
2015-07-07 9:20 ` Koro Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436260809.4347.2.camel@mtksdaap41 \
--to=koro.chen-nus5lvnupcjwk0htik3j/w@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=drinkcat-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.