From: Ian Campbell <ian.campbell@citrix.com>
To: Ben Catterall <Ben.Catterall@citrix.com>
Cc: keir@xen.org, andrew.cooper3@citrix.com, tim@xen.org,
stefano.stabellini@citrix.com, jbeulich@suse.com,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t
Date: Tue, 7 Jul 2015 16:12:09 +0100 [thread overview]
Message-ID: <1436281929.25646.241.camel@citrix.com> (raw)
In-Reply-To: <1435838656-9219-1-git-send-email-Ben.Catterall@citrix.com>
On Thu, 2015-07-02 at 13:04 +0100, Ben Catterall wrote:
> From: Andrew Cooper <andrew.cooper3@citrix.com>
>
> The sh_map/unmap wrappers can be dropped, and take the opportunity to turn
> some #define's into static inlines, for added type saftey.
>
> As part of adding the type safety, GCC highlights an problematic include cycle
> with arm/mm.h including domain_page.h which includes xen/mm.h and falls over
> __page_to_mfn being used before being declared. Simply dropping the inclusion
> of domain_page.h fixes the compilation issue.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Tim Deegan <tim@xen.org>
For ARM:
Acked-by: Ian Campbell <ian.campbell@citrix.com>
prev parent reply other threads:[~2015-07-07 15:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 12:04 [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t Ben Catterall
2015-07-02 12:04 ` [PATCH v2 2/3] xen/domain_page: Convert copy/clear_domain_page() " Ben Catterall
2015-07-07 10:03 ` Jan Beulich
2015-07-02 12:04 ` [PATCH v2 3/3] Convert map_domain_page() to use the new mfn_t type Ben Catterall
2015-07-07 10:10 ` Jan Beulich
2015-07-09 10:29 ` Ben Catterall
2015-07-09 10:38 ` Jan Beulich
2015-07-07 10:01 ` [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t Jan Beulich
2015-07-07 10:07 ` Andrew Cooper
2015-07-07 10:50 ` Jan Beulich
2015-07-13 16:56 ` Ian Jackson
2015-07-14 9:56 ` Jan Beulich
2015-07-14 10:54 ` Ian Jackson
2015-07-14 11:38 ` Jan Beulich
2015-07-07 15:12 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436281929.25646.241.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ben.Catterall@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.