All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "ARM: mvebu: fix suspend to RAM on big-endian configurations" has been added to the 4.0-stable tree
@ 2015-07-08  7:23 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2015-07-08  7:23 UTC (permalink / raw)
  To: thomas.petazzoni, gregkh; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    ARM: mvebu: fix suspend to RAM on big-endian configurations

to the 4.0-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     arm-mvebu-fix-suspend-to-ram-on-big-endian-configurations.patch
and it can be found in the queue-4.0 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 2f5bc307be2480ba89e4c5d118f406f04a4a7299 Mon Sep 17 00:00:00 2001
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date: Tue, 16 Jun 2015 14:12:57 +0200
Subject: ARM: mvebu: fix suspend to RAM on big-endian configurations

From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

commit 2f5bc307be2480ba89e4c5d118f406f04a4a7299 upstream.

The current Armada XP suspend to RAM implementation, as added in
commit 27432825ae19f ("ARM: mvebu: Armada XP GP specific
suspend/resume code") does not handle big-endian configurations
properly: the small bit of assembly code putting the DRAM in
self-refresh and toggling the GPIOs to turn off power forgets to
convert the values to little-endian.

This commit fixes that by making sure the two values we will write to
the DRAM controller register and GPIO register are already in
little-endian before entering the critical assembly code.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Fixes: 27432825ae19f ("ARM: mvebu: Armada XP GP specific suspend/resume code")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 arch/arm/mach-mvebu/pm-board.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/arch/arm/mach-mvebu/pm-board.c
+++ b/arch/arm/mach-mvebu/pm-board.c
@@ -43,6 +43,9 @@ static void mvebu_armada_xp_gp_pm_enter(
 	for (i = 0; i < ARMADA_XP_GP_PIC_NR_GPIOS; i++)
 		ackcmd |= BIT(pic_raw_gpios[i]);
 
+	srcmd = cpu_to_le32(srcmd);
+	ackcmd = cpu_to_le32(ackcmd);
+
 	/*
 	 * Wait a while, the PIC needs quite a bit of time between the
 	 * two GPIO commands.


Patches currently in stable-queue which might be from thomas.petazzoni@free-electrons.com are

queue-4.0/net-mvneta-introduce-compatible-string-marvell-armada-xp-neta.patch
queue-4.0/arm-mvebu-fix-suspend-to-ram-on-big-endian-configurations.patch
queue-4.0/net-mvneta-disable-ip-checksum-with-jumbo-frames-for-armada-370.patch
queue-4.0/arm-mvebu-update-ethernet-compatible-string-for-armada-xp.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-07-08  7:23 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-08  7:23 Patch "ARM: mvebu: fix suspend to RAM on big-endian configurations" has been added to the 4.0-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.