From: Jiang Liu <jiang.liu@linux.intel.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Grant Likely <grant.likely@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Stuart Yoder <stuart.yoder@freescale.com>,
Yijing Wang <wangyijing@huawei.com>,
Borislav Petkov <bp@alien8.de>,
Jiang Liu <jiang.liu@linux.intel.com>,
Alexander Gordeev <agordeev@redhat.com>
Cc: Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [RFC Patch V1 10/12] genirq, PCI: Store 'struct device *' instead 'struct pci_dev *' in struct msi_desc
Date: Thu, 9 Jul 2015 16:00:45 +0800 [thread overview]
Message-ID: <1436428847-8886-11-git-send-email-jiang.liu@linux.intel.com> (raw)
In-Reply-To: <1436428847-8886-1-git-send-email-jiang.liu@linux.intel.com>
Store 'struct device *' instead 'struct pci_dev *' in struct msi_desc,
so struct msi_desc may be reused by generic MSI drivers.
Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
---
drivers/pci/msi.c | 7 ++++++-
include/linux/msi.h | 11 ++++-------
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 0050ad436718..260c1653701d 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -413,7 +413,7 @@ static struct msi_desc *alloc_msi_entry(struct pci_dev *dev)
return NULL;
INIT_LIST_HEAD(&desc->list);
- desc->dev = dev;
+ desc->dev = &dev->dev;
return desc;
}
@@ -1140,6 +1140,11 @@ int pci_enable_msix_range(struct pci_dev *dev, struct msix_entry *entries,
}
EXPORT_SYMBOL(pci_enable_msix_range);
+struct pci_dev *msi_desc_to_pci_dev(struct msi_desc *desc)
+{
+ return to_pci_dev(desc->dev);
+}
+
void *msi_desc_to_pci_sysdata(struct msi_desc *desc)
{
struct pci_dev *dev = msi_desc_to_pci_dev(desc);
diff --git a/include/linux/msi.h b/include/linux/msi.h
index 57fe766a14bf..5f77e231f515 100644
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -14,6 +14,7 @@ extern int pci_msi_ignore_mask;
/* Helper functions */
struct irq_data;
struct msi_desc;
+struct pci_dev;
void __get_cached_msi_msg(struct msi_desc *entry, struct msi_msg *msg);
void get_cached_msi_msg(unsigned int irq, struct msi_msg *msg);
@@ -37,14 +38,14 @@ struct msi_desc {
void __iomem *mask_base;
u8 mask_pos;
};
- struct pci_dev *dev;
+ struct device *dev;
/* Last set MSI message */
struct msi_msg msg;
};
/* Helpers to hide struct msi_desc implementation details */
-#define msi_desc_to_dev(desc) (&(desc)->dev.dev)
+#define msi_desc_to_dev(desc) ((desc)->dev)
#define dev_to_msi_list(dev) (&(dev)->msi_list)
#define first_msi_entry(dev) \
list_first_entry(dev_to_msi_list((dev)), struct msi_desc, list)
@@ -56,11 +57,7 @@ struct msi_desc {
#define for_each_pci_msi_entry(desc, pdev) \
for_each_msi_entry((desc), &(pdev)->dev)
-static inline struct pci_dev *msi_desc_to_pci_dev(struct msi_desc *desc)
-{
- return desc->dev;
-}
-
+struct pci_dev *msi_desc_to_pci_dev(struct msi_desc *desc);
void *msi_desc_to_pci_sysdata(struct msi_desc *desc);
#else /* CONFIG_PCI_MSI */
static inline void *msi_desc_to_pci_sysdata(struct msi_desc *desc)
--
1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: jiang.liu@linux.intel.com (Jiang Liu)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC Patch V1 10/12] genirq, PCI: Store 'struct device *' instead 'struct pci_dev *' in struct msi_desc
Date: Thu, 9 Jul 2015 16:00:45 +0800 [thread overview]
Message-ID: <1436428847-8886-11-git-send-email-jiang.liu@linux.intel.com> (raw)
In-Reply-To: <1436428847-8886-1-git-send-email-jiang.liu@linux.intel.com>
Store 'struct device *' instead 'struct pci_dev *' in struct msi_desc,
so struct msi_desc may be reused by generic MSI drivers.
Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
---
drivers/pci/msi.c | 7 ++++++-
include/linux/msi.h | 11 ++++-------
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index 0050ad436718..260c1653701d 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -413,7 +413,7 @@ static struct msi_desc *alloc_msi_entry(struct pci_dev *dev)
return NULL;
INIT_LIST_HEAD(&desc->list);
- desc->dev = dev;
+ desc->dev = &dev->dev;
return desc;
}
@@ -1140,6 +1140,11 @@ int pci_enable_msix_range(struct pci_dev *dev, struct msix_entry *entries,
}
EXPORT_SYMBOL(pci_enable_msix_range);
+struct pci_dev *msi_desc_to_pci_dev(struct msi_desc *desc)
+{
+ return to_pci_dev(desc->dev);
+}
+
void *msi_desc_to_pci_sysdata(struct msi_desc *desc)
{
struct pci_dev *dev = msi_desc_to_pci_dev(desc);
diff --git a/include/linux/msi.h b/include/linux/msi.h
index 57fe766a14bf..5f77e231f515 100644
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -14,6 +14,7 @@ extern int pci_msi_ignore_mask;
/* Helper functions */
struct irq_data;
struct msi_desc;
+struct pci_dev;
void __get_cached_msi_msg(struct msi_desc *entry, struct msi_msg *msg);
void get_cached_msi_msg(unsigned int irq, struct msi_msg *msg);
@@ -37,14 +38,14 @@ struct msi_desc {
void __iomem *mask_base;
u8 mask_pos;
};
- struct pci_dev *dev;
+ struct device *dev;
/* Last set MSI message */
struct msi_msg msg;
};
/* Helpers to hide struct msi_desc implementation details */
-#define msi_desc_to_dev(desc) (&(desc)->dev.dev)
+#define msi_desc_to_dev(desc) ((desc)->dev)
#define dev_to_msi_list(dev) (&(dev)->msi_list)
#define first_msi_entry(dev) \
list_first_entry(dev_to_msi_list((dev)), struct msi_desc, list)
@@ -56,11 +57,7 @@ struct msi_desc {
#define for_each_pci_msi_entry(desc, pdev) \
for_each_msi_entry((desc), &(pdev)->dev)
-static inline struct pci_dev *msi_desc_to_pci_dev(struct msi_desc *desc)
-{
- return desc->dev;
-}
-
+struct pci_dev *msi_desc_to_pci_dev(struct msi_desc *desc);
void *msi_desc_to_pci_sysdata(struct msi_desc *desc);
#else /* CONFIG_PCI_MSI */
static inline void *msi_desc_to_pci_sysdata(struct msi_desc *desc)
--
1.7.10.4
next prev parent reply other threads:[~2015-07-09 8:00 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 8:00 [RFC Patch V1 00/12] Reorganize struct msi_desc to prepare for support of generic MSI Jiang Liu
2015-07-09 8:00 ` Jiang Liu
2015-07-09 8:00 ` [RFC Patch V1 01/12] PCI: Add helper function msi_desc_to_pci_sysdata() Jiang Liu
2015-07-09 8:00 ` Jiang Liu
2015-07-22 20:37 ` [tip:irq/core] " tip-bot for Jiang Liu
2015-07-09 8:00 ` [RFC Patch V1 02/12] MIPS, PCI: Use for_pci_msi_entry() to access MSI device list Jiang Liu
2015-07-09 8:00 ` Jiang Liu
2015-07-09 11:03 ` Sergei Shtylyov
2015-07-09 11:03 ` Sergei Shtylyov
2015-07-22 20:37 ` [tip:irq/core] MIPS/PCI: " tip-bot for Jiang Liu
2015-07-09 8:00 ` [RFC Patch V1 03/12] PowerPC, PCI: " Jiang Liu
2015-07-09 8:00 ` Jiang Liu
2015-07-22 20:38 ` [tip:irq/core] powerpc/PCI: " tip-bot for Jiang Liu
2015-07-09 8:00 ` [RFC Patch V1 04/12] s390/pci: " Jiang Liu
2015-07-09 8:00 ` Jiang Liu
2015-07-13 12:47 ` Sebastian Ott
2015-07-13 12:47 ` Sebastian Ott
2015-07-22 20:38 ` [tip:irq/core] " tip-bot for Jiang Liu
2015-07-09 8:00 ` [RFC Patch V1 05/12] x86, PCI: " Jiang Liu
2015-07-09 8:00 ` Jiang Liu
2015-07-09 8:00 ` Jiang Liu
2015-07-09 19:07 ` Konrad Rzeszutek Wilk
2015-07-09 19:07 ` Konrad Rzeszutek Wilk
2015-07-09 19:07 ` Konrad Rzeszutek Wilk
2015-07-22 20:38 ` [tip:irq/core] x86/PCI: " tip-bot for Jiang Liu
2015-07-09 8:00 ` [RFC Patch V1 06/12] PCI: " Jiang Liu
2015-07-09 8:00 ` Jiang Liu
2015-07-09 8:00 ` Jiang Liu
2015-07-09 19:08 ` Konrad Rzeszutek Wilk
2015-07-09 19:08 ` Konrad Rzeszutek Wilk
2015-07-09 19:08 ` Konrad Rzeszutek Wilk
2015-07-22 20:39 ` [tip:irq/core] PCI: Use for_each_pci_msi_entry() " tip-bot for Jiang Liu
2015-07-09 8:00 ` [RFC Patch V1 07/12] sparc, PCI: Use helper functions to access fields in struct msi_desc Jiang Liu
2015-07-09 8:00 ` Jiang Liu
2015-07-09 8:00 ` Jiang Liu
2015-07-09 8:00 ` David Miller
2015-07-09 8:00 ` David Miller
2015-07-09 8:00 ` David Miller
2015-07-22 20:39 ` [tip:irq/core] sparc/PCI: " tip-bot for Jiang Liu
2015-07-09 8:00 ` [RFC Patch V1 08/12] PCI: " Jiang Liu
2015-07-09 8:00 ` Jiang Liu
2015-07-12 11:18 ` Jingoo Han
2015-07-12 11:18 ` Jingoo Han
2015-07-22 20:39 ` [tip:irq/core] " tip-bot for Jiang Liu
2015-07-09 8:00 ` [RFC Patch V1 09/12] genirq: Move msi_list from struct pci_dev to struct device Jiang Liu
2015-07-09 8:00 ` Jiang Liu
2015-07-10 0:19 ` Paul Gortmaker
2015-07-10 0:19 ` Paul Gortmaker
2015-07-21 22:02 ` Thomas Gleixner
2015-07-21 22:02 ` Thomas Gleixner
2015-07-22 20:40 ` [tip:irq/core] genirq/MSI: " tip-bot for Jiang Liu
2015-07-09 8:00 ` Jiang Liu [this message]
2015-07-09 8:00 ` [RFC Patch V1 10/12] genirq, PCI: Store 'struct device *' instead 'struct pci_dev *' in struct msi_desc Jiang Liu
2015-07-22 20:40 ` [tip:irq/core] genirq/MSI: Store 'struct device' instead of ' struct pci_dev' " tip-bot for Jiang Liu
2015-07-09 8:00 ` [RFC Patch V1 11/12] genirq, PCI: Reorginize struct msi_desc to prepare for support of generic MSI Jiang Liu
2015-07-09 8:00 ` Jiang Liu
2015-07-10 12:41 ` Marc Zyngier
2015-07-10 12:41 ` Marc Zyngier
2015-07-22 20:41 ` [tip:irq/core] genirq/MSI: " tip-bot for Jiang Liu
2015-07-09 8:00 ` [RFC Patch V1 12/12] genirq, PCI: Move alloc_msi_entry() from PCI MSI code into generic MSI code Jiang Liu
2015-07-09 8:00 ` Jiang Liu
2015-07-22 20:41 ` [tip:irq/core] genirq/MSI: Move alloc_msi_entry() from PCI " tip-bot for Jiang Liu
2015-07-10 1:41 ` [RFC Patch V1 00/12] Reorganize struct msi_desc to prepare for support of generic MSI Yijing Wang
2015-07-10 1:41 ` Yijing Wang
2015-07-10 12:54 ` Marc Zyngier
2015-07-10 12:54 ` Marc Zyngier
2015-07-21 8:31 ` Thomas Gleixner
2015-07-21 8:31 ` Thomas Gleixner
2015-07-21 13:30 ` Bjorn Helgaas
2015-07-21 13:30 ` Bjorn Helgaas
2015-07-21 15:51 ` Thomas Gleixner
2015-07-21 15:51 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436428847-8886-11-git-send-email-jiang.liu@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=agordeev@redhat.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mingo@redhat.com \
--cc=stuart.yoder@freescale.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.