All of lore.kernel.org
 help / color / mirror / Atom feed
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 12/13] ARM: remove ununsed set_irq_flags
Date: Sun, 12 Jul 2015 09:26:50 -0500	[thread overview]
Message-ID: <1436711211-18223-13-git-send-email-robh@kernel.org> (raw)
In-Reply-To: <1436711211-18223-1-git-send-email-robh@kernel.org>

Now that all users of set_irq_flags and custom flags are converted to
genirq functions, the ARM specific set_irq_flags can be removed.

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: linux-arm-kernel at lists.infradead.org
Tested-by: Kevin Hilman <khilman@linaro.org>
---
 arch/arm/include/asm/hw_irq.h |  6 ------
 arch/arm/kernel/irq.c         | 20 --------------------
 2 files changed, 26 deletions(-)

diff --git a/arch/arm/include/asm/hw_irq.h b/arch/arm/include/asm/hw_irq.h
index af79da4..9beb929 100644
--- a/arch/arm/include/asm/hw_irq.h
+++ b/arch/arm/include/asm/hw_irq.h
@@ -11,12 +11,6 @@ static inline void ack_bad_irq(int irq)
 	pr_crit("unexpected IRQ trap at vector %02x\n", irq);
 }
 
-void set_irq_flags(unsigned int irq, unsigned int flags);
-
-#define IRQF_VALID	(1 << 0)
-#define IRQF_PROBE	(1 << 1)
-#define IRQF_NOAUTOEN	(1 << 2)
-
 #define ARCH_IRQ_INIT_FLAGS	(IRQ_NOREQUEST | IRQ_NOPROBE)
 
 #endif
diff --git a/arch/arm/kernel/irq.c b/arch/arm/kernel/irq.c
index 350f188..4072266 100644
--- a/arch/arm/kernel/irq.c
+++ b/arch/arm/kernel/irq.c
@@ -78,26 +78,6 @@ asm_do_IRQ(unsigned int irq, struct pt_regs *regs)
 	handle_IRQ(irq, regs);
 }
 
-void set_irq_flags(unsigned int irq, unsigned int iflags)
-{
-	unsigned long clr = 0, set = IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN;
-
-	if (irq >= nr_irqs) {
-		pr_err("Trying to set irq flags for IRQ%d\n", irq);
-		return;
-	}
-
-	if (iflags & IRQF_VALID)
-		clr |= IRQ_NOREQUEST;
-	if (iflags & IRQF_PROBE)
-		clr |= IRQ_NOPROBE;
-	if (!(iflags & IRQF_NOAUTOEN))
-		clr |= IRQ_NOAUTOEN;
-	/* Order is clear bits in "clr" then set bits in "set" */
-	irq_modify_status(irq, clr, set & ~clr);
-}
-EXPORT_SYMBOL_GPL(set_irq_flags);
-
 void __init init_IRQ(void)
 {
 	int ret;
-- 
2.1.0

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: linux-arm-kernel@lists.infradead.org,
	Russell King <linux@arm.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, arm@kernel.org
Subject: [PATCH v2 12/13] ARM: remove ununsed set_irq_flags
Date: Sun, 12 Jul 2015 09:26:50 -0500	[thread overview]
Message-ID: <1436711211-18223-13-git-send-email-robh@kernel.org> (raw)
In-Reply-To: <1436711211-18223-1-git-send-email-robh@kernel.org>

Now that all users of set_irq_flags and custom flags are converted to
genirq functions, the ARM specific set_irq_flags can be removed.

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
Tested-by: Kevin Hilman <khilman@linaro.org>
---
 arch/arm/include/asm/hw_irq.h |  6 ------
 arch/arm/kernel/irq.c         | 20 --------------------
 2 files changed, 26 deletions(-)

diff --git a/arch/arm/include/asm/hw_irq.h b/arch/arm/include/asm/hw_irq.h
index af79da4..9beb929 100644
--- a/arch/arm/include/asm/hw_irq.h
+++ b/arch/arm/include/asm/hw_irq.h
@@ -11,12 +11,6 @@ static inline void ack_bad_irq(int irq)
 	pr_crit("unexpected IRQ trap at vector %02x\n", irq);
 }
 
-void set_irq_flags(unsigned int irq, unsigned int flags);
-
-#define IRQF_VALID	(1 << 0)
-#define IRQF_PROBE	(1 << 1)
-#define IRQF_NOAUTOEN	(1 << 2)
-
 #define ARCH_IRQ_INIT_FLAGS	(IRQ_NOREQUEST | IRQ_NOPROBE)
 
 #endif
diff --git a/arch/arm/kernel/irq.c b/arch/arm/kernel/irq.c
index 350f188..4072266 100644
--- a/arch/arm/kernel/irq.c
+++ b/arch/arm/kernel/irq.c
@@ -78,26 +78,6 @@ asm_do_IRQ(unsigned int irq, struct pt_regs *regs)
 	handle_IRQ(irq, regs);
 }
 
-void set_irq_flags(unsigned int irq, unsigned int iflags)
-{
-	unsigned long clr = 0, set = IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN;
-
-	if (irq >= nr_irqs) {
-		pr_err("Trying to set irq flags for IRQ%d\n", irq);
-		return;
-	}
-
-	if (iflags & IRQF_VALID)
-		clr |= IRQ_NOREQUEST;
-	if (iflags & IRQF_PROBE)
-		clr |= IRQ_NOPROBE;
-	if (!(iflags & IRQF_NOAUTOEN))
-		clr |= IRQ_NOAUTOEN;
-	/* Order is clear bits in "clr" then set bits in "set" */
-	irq_modify_status(irq, clr, set & ~clr);
-}
-EXPORT_SYMBOL_GPL(set_irq_flags);
-
 void __init init_IRQ(void)
 {
 	int ret;
-- 
2.1.0


  parent reply	other threads:[~2015-07-12 14:26 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-12 14:26 [PATCH v2 00/13] Kill off set_irq_flags Rob Herring
2015-07-12 14:26 ` Rob Herring
2015-07-12 14:26 ` [PATCH v2 01/13] ARM: kill off set_irq_flags usage Rob Herring
2015-07-12 14:26   ` Rob Herring
2015-07-12 14:26   ` Rob Herring
2015-07-13  3:19   ` Shawn Guo
2015-07-13  3:19     ` Shawn Guo
2015-07-14 21:14   ` Robert Jarzmik
2015-07-14 21:14     ` Robert Jarzmik
2015-07-12 14:26 ` [PATCH v2 02/13] clk: " Rob Herring
2015-07-12 14:26   ` Rob Herring
2015-07-12 14:26 ` [PATCH v2 03/13] dma: " Rob Herring
2015-07-12 14:26   ` Rob Herring
2015-07-12 14:26 ` [PATCH v2 04/13] gpio: " Rob Herring
2015-07-12 14:26   ` Rob Herring
2015-07-12 14:26 ` [PATCH v2 05/13] gpu/drm: " Rob Herring
2015-07-12 14:26   ` Rob Herring
2015-07-12 14:26 ` [PATCH v2 06/13] irqchip: " Rob Herring
2015-07-12 14:26   ` Rob Herring
2015-07-12 14:26   ` Rob Herring
2015-07-12 16:43   ` Thomas Gleixner
2015-07-12 16:43     ` Thomas Gleixner
2015-07-13 16:26     ` Rob Herring
2015-07-13 16:26       ` Rob Herring
2015-07-16 11:10       ` Thomas Gleixner
2015-07-16 11:10         ` Thomas Gleixner
2015-07-16 13:26     ` Russell King - ARM Linux
2015-07-16 13:26       ` Russell King - ARM Linux
2015-07-16 19:32       ` Robert Jarzmik
2015-07-16 19:32         ` Robert Jarzmik
2015-07-16 20:34         ` Russell King - ARM Linux
2015-07-16 20:34           ` Russell King - ARM Linux
2015-07-25 13:34   ` Gregory CLEMENT
2015-07-25 13:34     ` Gregory CLEMENT
2015-07-27 18:39     ` Rob Herring
2015-07-27 18:39       ` Rob Herring
2015-07-12 14:26 ` [PATCH v2 07/13] memory: " Rob Herring
2015-07-12 14:26   ` Rob Herring
2015-07-12 14:26   ` Rob Herring
2015-08-13  7:51   ` Tony Lindgren
2015-08-13  7:51     ` Tony Lindgren
2015-07-12 14:26 ` [PATCH v2 08/13] mfd: " Rob Herring
2015-07-12 14:26   ` Rob Herring
2015-07-12 14:26   ` Rob Herring
2015-07-12 14:26 ` [PATCH v2 09/13] PCI: " Rob Herring
2015-07-12 14:26   ` Rob Herring
2015-07-12 14:26   ` Rob Herring
2015-07-12 14:34   ` Jingoo Han
2015-07-12 14:34     ` Jingoo Han
2015-07-12 14:34     ` Jingoo Han
2015-07-12 14:26 ` [PATCH v2 10/13] pinctrl: " Rob Herring
2015-07-12 14:26   ` Rob Herring
2015-07-12 15:45   ` Tomasz Figa
2015-07-12 15:45     ` Tomasz Figa
2015-07-12 14:26 ` [PATCH v2 11/13] sh: " Rob Herring
2015-07-12 14:26   ` Rob Herring
2015-07-12 14:26   ` Rob Herring
2015-07-12 14:26 ` Rob Herring [this message]
2015-07-12 14:26   ` [PATCH v2 12/13] ARM: remove ununsed set_irq_flags Rob Herring
2015-07-12 14:26 ` [PATCH v2 13/13] arm64: " Rob Herring
2015-07-12 14:26   ` Rob Herring
2015-07-12 16:49 ` [PATCH v2 00/13] Kill off set_irq_flags Thomas Gleixner
2015-07-12 16:49   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436711211-18223-13-git-send-email-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.