From: Koro Chen <koro.chen@mediatek.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
srv_heupstream <srv_heupstream@mediatek.com>,
linux-mediatek@lists.infradead.org,
Sascha Hauer <s.hauer@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
alsa-devel@alsa-project.org,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: mt8173: Add afe device node
Date: Mon, 13 Jul 2015 15:19:29 +0800 [thread overview]
Message-ID: <1436771969.15768.6.camel@mtksdaap41> (raw)
In-Reply-To: <CAGS+omBqO6Zcw9KuN6p9YDvRD=UfmOnokUPeRo-iv6ruTBChwg@mail.gmail.com>
On Thu, 2015-07-09 at 18:45 +0800, Daniel Kurtz wrote:
> On Thu, Jul 9, 2015 at 11:32 AM, Koro Chen <koro.chen@mediatek.com> wrote:
> > This adds afe (audio front end) device node to the MT8173 dtsi file.
> >
> > Signed-off-by: Koro Chen <koro.chen@mediatek.com>
>
> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
>
> I believe this patch depends on the fix in:
> https://patchwork.kernel.org/patch/6752521/
>
> If so, I think it would have been better to upload them together and
> mention the dependency in the cover letter.
> However, now that they are both on the list, we just need to ensure
> they are merged together.
The above patch was already merged, so now it is OK to merge this one
(If there is no problem for this patch, of course)
>
> -Dan
>
>
> > ---
> > This patch is based on Matthias's tree:
> > https://github.com/mbgg/linux-mediatek
> > branch: v4.2-next/arm64
> >
> > Changes since v1:
> > - change node name to afe: audio-controller@11220000
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 32 ++++++++++++++++++++++++++++++++
> > 1 file changed, 32 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 0696f8f..ce9255a 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -14,6 +14,7 @@
> > #include <dt-bindings/clock/mt8173-clk.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +#include <dt-bindings/power/mt8173-power.h>
> > #include <dt-bindings/reset-controller/mt8173-resets.h>
> > #include "mt8173-pinfunc.h"
> >
> > @@ -393,6 +394,37 @@
> > #size-cells = <0>;
> > status = "disabled";
> > };
> > +
> > + afe: audio-controller@11220000 {
> > + compatible = "mediatek,mt8173-afe-pcm";
> > + reg = <0 0x11220000 0 0x1000>;
> > + interrupts = <GIC_SPI 134 IRQ_TYPE_EDGE_FALLING>;
> > + power-domains = <&scpsys MT8173_POWER_DOMAIN_AUDIO>;
> > + clocks = <&infracfg CLK_INFRA_AUDIO>,
> > + <&topckgen CLK_TOP_AUDIO_SEL>,
> > + <&topckgen CLK_TOP_AUD_INTBUS_SEL>,
> > + <&topckgen CLK_TOP_APLL1_DIV0>,
> > + <&topckgen CLK_TOP_APLL2_DIV0>,
> > + <&topckgen CLK_TOP_I2S0_M_SEL>,
> > + <&topckgen CLK_TOP_I2S1_M_SEL>,
> > + <&topckgen CLK_TOP_I2S2_M_SEL>,
> > + <&topckgen CLK_TOP_I2S3_M_SEL>,
> > + <&topckgen CLK_TOP_I2S3_B_SEL>;
> > + clock-names = "infra_sys_audio_clk",
> > + "top_pdn_audio",
> > + "top_pdn_aud_intbus",
> > + "bck0",
> > + "bck1",
> > + "i2s0_m",
> > + "i2s1_m",
> > + "i2s2_m",
> > + "i2s3_m",
> > + "i2s3_b";
> > + assigned-clocks = <&topckgen CLK_TOP_AUD_1_SEL>,
> > + <&topckgen CLK_TOP_AUD_2_SEL>;
> > + assigned-clock-parents = <&topckgen CLK_TOP_APLL1>,
> > + <&topckgen CLK_TOP_APLL2>;
> > + };
> > };
> > };
> >
> > --
> > 1.8.1.1.dirty
> >
WARNING: multiple messages have this Message-ID (diff)
From: koro.chen@mediatek.com (Koro Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: dts: mt8173: Add afe device node
Date: Mon, 13 Jul 2015 15:19:29 +0800 [thread overview]
Message-ID: <1436771969.15768.6.camel@mtksdaap41> (raw)
In-Reply-To: <CAGS+omBqO6Zcw9KuN6p9YDvRD=UfmOnokUPeRo-iv6ruTBChwg@mail.gmail.com>
On Thu, 2015-07-09 at 18:45 +0800, Daniel Kurtz wrote:
> On Thu, Jul 9, 2015 at 11:32 AM, Koro Chen <koro.chen@mediatek.com> wrote:
> > This adds afe (audio front end) device node to the MT8173 dtsi file.
> >
> > Signed-off-by: Koro Chen <koro.chen@mediatek.com>
>
> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
>
> I believe this patch depends on the fix in:
> https://patchwork.kernel.org/patch/6752521/
>
> If so, I think it would have been better to upload them together and
> mention the dependency in the cover letter.
> However, now that they are both on the list, we just need to ensure
> they are merged together.
The above patch was already merged, so now it is OK to merge this one
(If there is no problem for this patch, of course)
>
> -Dan
>
>
> > ---
> > This patch is based on Matthias's tree:
> > https://github.com/mbgg/linux-mediatek
> > branch: v4.2-next/arm64
> >
> > Changes since v1:
> > - change node name to afe: audio-controller at 11220000
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 32 ++++++++++++++++++++++++++++++++
> > 1 file changed, 32 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 0696f8f..ce9255a 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -14,6 +14,7 @@
> > #include <dt-bindings/clock/mt8173-clk.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +#include <dt-bindings/power/mt8173-power.h>
> > #include <dt-bindings/reset-controller/mt8173-resets.h>
> > #include "mt8173-pinfunc.h"
> >
> > @@ -393,6 +394,37 @@
> > #size-cells = <0>;
> > status = "disabled";
> > };
> > +
> > + afe: audio-controller at 11220000 {
> > + compatible = "mediatek,mt8173-afe-pcm";
> > + reg = <0 0x11220000 0 0x1000>;
> > + interrupts = <GIC_SPI 134 IRQ_TYPE_EDGE_FALLING>;
> > + power-domains = <&scpsys MT8173_POWER_DOMAIN_AUDIO>;
> > + clocks = <&infracfg CLK_INFRA_AUDIO>,
> > + <&topckgen CLK_TOP_AUDIO_SEL>,
> > + <&topckgen CLK_TOP_AUD_INTBUS_SEL>,
> > + <&topckgen CLK_TOP_APLL1_DIV0>,
> > + <&topckgen CLK_TOP_APLL2_DIV0>,
> > + <&topckgen CLK_TOP_I2S0_M_SEL>,
> > + <&topckgen CLK_TOP_I2S1_M_SEL>,
> > + <&topckgen CLK_TOP_I2S2_M_SEL>,
> > + <&topckgen CLK_TOP_I2S3_M_SEL>,
> > + <&topckgen CLK_TOP_I2S3_B_SEL>;
> > + clock-names = "infra_sys_audio_clk",
> > + "top_pdn_audio",
> > + "top_pdn_aud_intbus",
> > + "bck0",
> > + "bck1",
> > + "i2s0_m",
> > + "i2s1_m",
> > + "i2s2_m",
> > + "i2s3_m",
> > + "i2s3_b";
> > + assigned-clocks = <&topckgen CLK_TOP_AUD_1_SEL>,
> > + <&topckgen CLK_TOP_AUD_2_SEL>;
> > + assigned-clock-parents = <&topckgen CLK_TOP_APLL1>,
> > + <&topckgen CLK_TOP_APLL2>;
> > + };
> > };
> > };
> >
> > --
> > 1.8.1.1.dirty
> >
WARNING: multiple messages have this Message-ID (diff)
From: Koro Chen <koro.chen@mediatek.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
srv_heupstream <srv_heupstream@mediatek.com>,
<linux-mediatek@lists.infradead.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
<alsa-devel@alsa-project.org>,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: mt8173: Add afe device node
Date: Mon, 13 Jul 2015 15:19:29 +0800 [thread overview]
Message-ID: <1436771969.15768.6.camel@mtksdaap41> (raw)
In-Reply-To: <CAGS+omBqO6Zcw9KuN6p9YDvRD=UfmOnokUPeRo-iv6ruTBChwg@mail.gmail.com>
On Thu, 2015-07-09 at 18:45 +0800, Daniel Kurtz wrote:
> On Thu, Jul 9, 2015 at 11:32 AM, Koro Chen <koro.chen@mediatek.com> wrote:
> > This adds afe (audio front end) device node to the MT8173 dtsi file.
> >
> > Signed-off-by: Koro Chen <koro.chen@mediatek.com>
>
> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
>
> I believe this patch depends on the fix in:
> https://patchwork.kernel.org/patch/6752521/
>
> If so, I think it would have been better to upload them together and
> mention the dependency in the cover letter.
> However, now that they are both on the list, we just need to ensure
> they are merged together.
The above patch was already merged, so now it is OK to merge this one
(If there is no problem for this patch, of course)
>
> -Dan
>
>
> > ---
> > This patch is based on Matthias's tree:
> > https://github.com/mbgg/linux-mediatek
> > branch: v4.2-next/arm64
> >
> > Changes since v1:
> > - change node name to afe: audio-controller@11220000
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 32 ++++++++++++++++++++++++++++++++
> > 1 file changed, 32 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 0696f8f..ce9255a 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -14,6 +14,7 @@
> > #include <dt-bindings/clock/mt8173-clk.h>
> > #include <dt-bindings/interrupt-controller/irq.h>
> > #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +#include <dt-bindings/power/mt8173-power.h>
> > #include <dt-bindings/reset-controller/mt8173-resets.h>
> > #include "mt8173-pinfunc.h"
> >
> > @@ -393,6 +394,37 @@
> > #size-cells = <0>;
> > status = "disabled";
> > };
> > +
> > + afe: audio-controller@11220000 {
> > + compatible = "mediatek,mt8173-afe-pcm";
> > + reg = <0 0x11220000 0 0x1000>;
> > + interrupts = <GIC_SPI 134 IRQ_TYPE_EDGE_FALLING>;
> > + power-domains = <&scpsys MT8173_POWER_DOMAIN_AUDIO>;
> > + clocks = <&infracfg CLK_INFRA_AUDIO>,
> > + <&topckgen CLK_TOP_AUDIO_SEL>,
> > + <&topckgen CLK_TOP_AUD_INTBUS_SEL>,
> > + <&topckgen CLK_TOP_APLL1_DIV0>,
> > + <&topckgen CLK_TOP_APLL2_DIV0>,
> > + <&topckgen CLK_TOP_I2S0_M_SEL>,
> > + <&topckgen CLK_TOP_I2S1_M_SEL>,
> > + <&topckgen CLK_TOP_I2S2_M_SEL>,
> > + <&topckgen CLK_TOP_I2S3_M_SEL>,
> > + <&topckgen CLK_TOP_I2S3_B_SEL>;
> > + clock-names = "infra_sys_audio_clk",
> > + "top_pdn_audio",
> > + "top_pdn_aud_intbus",
> > + "bck0",
> > + "bck1",
> > + "i2s0_m",
> > + "i2s1_m",
> > + "i2s2_m",
> > + "i2s3_m",
> > + "i2s3_b";
> > + assigned-clocks = <&topckgen CLK_TOP_AUD_1_SEL>,
> > + <&topckgen CLK_TOP_AUD_2_SEL>;
> > + assigned-clock-parents = <&topckgen CLK_TOP_APLL1>,
> > + <&topckgen CLK_TOP_APLL2>;
> > + };
> > };
> > };
> >
> > --
> > 1.8.1.1.dirty
> >
next prev parent reply other threads:[~2015-07-13 7:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 3:32 [PATCH v2] arm64: dts: mt8173: Add afe device node Koro Chen
2015-07-09 3:32 ` Koro Chen
2015-07-09 3:32 ` Koro Chen
[not found] ` <1436412725-55129-1-git-send-email-koro.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-07-09 10:45 ` Daniel Kurtz
2015-07-09 10:45 ` Daniel Kurtz
2015-07-09 10:45 ` Daniel Kurtz
2015-07-13 7:19 ` Koro Chen [this message]
2015-07-13 7:19 ` Koro Chen
2015-07-13 7:19 ` Koro Chen
2015-07-17 21:42 ` Matthias Brugger
2015-07-17 21:42 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436771969.15768.6.camel@mtksdaap41 \
--to=koro.chen@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.