From: Dario Faggioli <dario.faggioli@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2 10/10] libxl: fix caller of libxl_cpupool functions
Date: Tue, 14 Jul 2015 11:37:43 +0200 [thread overview]
Message-ID: <1436866663.13522.71.camel@citrix.com> (raw)
In-Reply-To: <1436804541-12965-11-git-send-email-wei.liu2@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 888 bytes --]
On Mon, 2015-07-13 at 17:22 +0100, Wei Liu wrote:
> Coverity complains cpupool_info leaks a string in failure path. Instead
> of fixing that path, we rely on the callers (two public APIs at the
> moment) of cpupool_info correctly call libxl_cpupoolinfo_dispose in
> their failure path to dispose of any resources.
>
> That involves:
> 1. Call _init and _dispose in libxl_list_cpupool
> 2. Call _init in numa_place_domain
>
> Fix numa_place_domain to use goto style to make things more clearer.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2015-07-14 9:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 16:22 [PATCH v2 00/10] xl/libxl: fix issues discovered by coverity Wei Liu
2015-07-13 16:22 ` [PATCH v2 01/10] libxl: make libxl__abs_path correctly handle NULL argument Wei Liu
2015-07-13 16:22 ` [PATCH v2 02/10] libxl: turn two malloc's to libxl__malloc Wei Liu
2015-07-13 17:15 ` Ian Jackson
2015-07-13 16:22 ` [PATCH v2 03/10] libxl: json string object can be NULL Wei Liu
2015-07-13 16:22 ` [PATCH v2 04/10] libxl: dispose dominfo to avoid leaking resource Wei Liu
2015-07-13 16:22 ` [PATCH v2 05/10] libxl: localtime(3) can return NULL Wei Liu
2015-07-13 16:22 ` [PATCH v2 06/10] libxl: qmp_init_handler " Wei Liu
2015-07-13 16:22 ` [PATCH v2 07/10] xl: correct handling of extra_config in main_cpupoolcreate Wei Liu
2015-07-13 16:22 ` [PATCH v2 08/10] xl: correctly handle null extra config in main_config_update Wei Liu
2015-07-13 16:22 ` [PATCH v2 09/10] xl: fix a typo in error string in create_domain Wei Liu
2015-07-13 16:22 ` [PATCH v2 10/10] libxl: fix caller of libxl_cpupool functions Wei Liu
2015-07-14 9:37 ` Dario Faggioli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436866663.13522.71.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.