From: Ian Campbell <ian.campbell@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH for 4.6] tools/python: Correct the install path of the python scripts
Date: Wed, 15 Jul 2015 12:43:28 +0100 [thread overview]
Message-ID: <1436960608.32371.14.camel@citrix.com> (raw)
In-Reply-To: <1436958580-2842-1-git-send-email-andrew.cooper3@citrix.com>
On Wed, 2015-07-15 at 12:09 +0100, Andrew Cooper wrote:
> c/s 74a7c7a was actually written long before c/s 2c96ecb "Use
> configure --libexecdir=BASEDIR to set LIBEXEC", and I didn't notice
> during development because of the method I was using to run a legacy
> and migration v2 libxl toolstack side-by-side.
>
> The result is that the conversion script gets installed in the root of
> the output tree, rather than in the location libxl is expecting to
> find it.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Ian Campbell <Ian.Campbell@citrix.com>
and applied.
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> ---
> tools/python/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/python/Makefile b/tools/python/Makefile
> index df942a7..8d2c7dd 100644
> --- a/tools/python/Makefile
> +++ b/tools/python/Makefile
> @@ -17,12 +17,12 @@ build: genwrap.py $(XEN_ROOT)/tools/libxl/libxl_types.idl \
>
> .PHONY: install
> install:
> - $(INSTALL_DIR) $(DESTDIR)$(PRIVATE_BINDIR)
> + $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
>
> CC="$(CC)" CFLAGS="$(PY_CFLAGS)" $(PYTHON) setup.py install \
> $(PYTHON_PREFIX_ARG) --root="$(DESTDIR)" --force
>
> - $(INSTALL_PROG) scripts/convert-legacy-stream $(DESTDIR)$(PRIVATE_BINDIR)
> + $(INSTALL_PROG) scripts/convert-legacy-stream $(DESTDIR)$(LIBEXEC_BIN)
>
> .PHONY: test
> test:
prev parent reply other threads:[~2015-07-15 11:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 11:09 [PATCH for 4.6] tools/python: Correct the install path of the python scripts Andrew Cooper
2015-07-15 11:43 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436960608.32371.14.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.