From: Ian Campbell <ian.campbell@citrix.com>
To: Jason Andryuk <jason.p.andryuk@aero.org>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH XEN v2 08/15] tools: Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab.
Date: Thu, 16 Jul 2015 15:56:20 +0100 [thread overview]
Message-ID: <1437058580.32371.224.camel@citrix.com> (raw)
In-Reply-To: <55A7C446.3050308@aero.org>
On Thu, 2015-07-16 at 10:48 -0400, Jason Andryuk wrote:
> Ian,
>
> I'm not subscribed to xen-devel and read your patch from the gmane.org
> web interface.
No problem, I'm recopying the list for you now.
> > After this change libxenvchan no longer needs to link against
> > libxenctrl. It still needs xenctrl.h in one file for xen_mb and
> > friends.
>
> @@ -109,7 +119,7 @@ LDLIBS_libxenstat = $(SHDEPS_libxenstat) $(XEN_LIBXENSTAT)/libxenstat$(libexten
> SHLIB_libxenstat = $(SHDEPS_libxenstat) -Wl,-rpath-link=$(XEN_LIBXENSTAT)
>
> CFLAGS_libxenvchan = -I$(XEN_LIBVCHAN)
> -SHDEPS_libxenvchan = $(SHLIB_libxenctrl) $(SHLIB_libxenstore) $(SHLIB_libxenevtchn)
> +SHDEPS_libxenvchan = $(SHLIB_libxenctrl) $(SHLIB_libxenstore) $(SHLIB_libxenevtchn) $(SHLIB_libxengnttab) $(SHLIB_libxengntshr)
> LDLIBS_libxenvchan = $(SHDEPS_libxenvchan) $(XEN_LIBVCHAN)/libxenvchan$(libextension)
> SHLIB_libxenvchan = $(SHDEPS_libxenvchan) -Wl,-rpath-link=$(XEN_LIBVCHAN)
>
> I see in tools/libvchan/Makefile you removed $(LDLIBS_libxenctrl), but
> did you want to remove $(SHLIB_libxenctrl) here?
I think I did, yes, thanks.
Ian.
next parent reply other threads:[~2015-07-16 14:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <55A7C446.3050308@aero.org>
2015-07-16 14:56 ` Ian Campbell [this message]
2015-07-15 15:46 [PATCH v2 0/15+5+5] Begin to disentangle libxenctrl and provide some stable libraries Ian Campbell
2015-07-15 15:46 ` [PATCH XEN v2 08/15] tools: Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab Ian Campbell
2015-09-22 11:25 ` Ian Campbell
2015-09-22 11:36 ` Andrew Cooper
2015-09-22 12:41 ` Ian Jackson
2015-09-22 12:51 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437058580.32371.224.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=jason.p.andryuk@aero.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.