[OSSTEST PATCH] cri-bisect: Provide --html-dir= option introducer

[OSSTEST PATCH] cri-bisect: Provide --html-dir= option introducer

[Ian Jackson]

Since 0caf39e6 "Reporting: Make HTML reports for bisection flights too"
we have been running
  ./sg-report-flight /home/logs/logs/59620/ 59620
which is no good.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 cri-bisect |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cri-bisect b/cri-bisect
index 2ce9945..c1d0d92 100644
--- a/cri-bisect
+++ b/cri-bisect
@@ -111,7 +111,7 @@ END
         if $flight_executed; then
                 echo >&3 ----------------------------------------
 		if [ "x$OSSTEST_HTMLPUB_DIR" != x ]; then
-			sgr_args+="$OSSTEST_HTMLPUB_DIR/$flight/"
+			sgr_args+=" --html-dir=$OSSTEST_HTMLPUB_DIR/$flight/"
 		fi
                 ./sg-report-flight $sgr_args >&3 $flight
                 ./cr-publish-flight-logs --push-harness $flight
-- 
1.7.10.4

Re: [OSSTEST PATCH] cri-bisect: Provide --html-dir= option introducer

[Ian Campbell]

On Thu, 2015-07-16 at 15:54 +0100, Ian Jackson wrote:
> Since 0caf39e6 "Reporting: Make HTML reports for bisection flights too"
> we have been running
>   ./sg-report-flight /home/logs/logs/59620/ 59620
> which is no good.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Worth a force push? Maybe not, but an immediate push pretest perhaps?

> ---
>  cri-bisect |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cri-bisect b/cri-bisect
> index 2ce9945..c1d0d92 100644
> --- a/cri-bisect
> +++ b/cri-bisect
> @@ -111,7 +111,7 @@ END
>          if $flight_executed; then
>                  echo >&3 ----------------------------------------
>  		if [ "x$OSSTEST_HTMLPUB_DIR" != x ]; then
> -			sgr_args+="$OSSTEST_HTMLPUB_DIR/$flight/"
> +			sgr_args+=" --html-dir=$OSSTEST_HTMLPUB_DIR/$flight/"
>  		fi
>                  ./sg-report-flight $sgr_args >&3 $flight
>                  ./cr-publish-flight-logs --push-harness $flight

Re: [OSSTEST PATCH] cri-bisect: Provide --html-dir= option introducer

[Ian Jackson]

Ian Campbell writes ("Re: [OSSTEST PATCH] cri-bisect: Provide --html-dir= option introducer"):
> On Thu, 2015-07-16 at 15:54 +0100, Ian Jackson wrote:
> > Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Worth a force push? Maybe not, but an immediate push pretest perhaps?

Thanks.  I'll throw it into pretest with the Windows VM since
increase.  I'm having a look through my inbox for anything else that
seems like it should go in now.

It's not critical because it happens after the bisection flight it
affects has been blessed, so the bisector continues to work.

Ian.

Re: [OSSTEST PATCH] cri-bisect: Provide --html-dir= option introducer

[Ian Campbell]

On Thu, 2015-07-16 at 17:09 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [OSSTEST PATCH] cri-bisect: Provide --html-dir= option introducer"):
> > On Thu, 2015-07-16 at 15:54 +0100, Ian Jackson wrote:
> > > Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > 
> > Worth a force push? Maybe not, but an immediate push pretest perhaps?
> 
> Thanks.  I'll throw it into pretest with the Windows VM since
> increase.  I'm having a look through my inbox for anything else that
> seems like it should go in now.

"mg-list-all-branches: Sort branches according to any embedded version"
would be Nice To Have and is harmless I think.

> It's not critical because it happens after the bisection flight it
> affects has been blessed, so the bisector continues to work.

Right.