* [PATCH] xen/arm: gicv3: Update comment for ICC_CTLR_EL1
@ 2015-07-15 19:47 Julien Grall
2015-07-16 15:52 ` Ian Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Julien Grall @ 2015-07-15 19:47 UTC (permalink / raw)
To: xen-devel; +Cc: Julien Grall, stefano.stabellini, ian.campbell
Xen is using EOImode 1 which means that EOI drops the priority and DIR
deactivates the interrupt.
Signed-off-by: Julien Grall <julien.grall@citrix.com>
---
xen/arch/arm/gic-v3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index 2033951..d1db1ce 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -719,7 +719,7 @@ static int __cpuinit gicv3_cpu_init(void)
/* Set priority mask register */
WRITE_SYSREG32(DEFAULT_PMR_VALUE, ICC_PMR_EL1);
- /* EOI drops priority too (mode 0) */
+ /* EOI drops priority, DIR deactivates the interrupt (mode 1) */
WRITE_SYSREG32(GICC_CTLR_EL1_EOImode_drop, ICC_CTLR_EL1);
/* Enable Group1 interrupts */
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-16 15:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-15 19:47 [PATCH] xen/arm: gicv3: Update comment for ICC_CTLR_EL1 Julien Grall
2015-07-16 15:52 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.