From: Joakim Tjernlund <joakim.tjernlund@transmode.se>
To: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"madalin.bucur@freescale.com" <madalin.bucur@freescale.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC 02/10] dpaa_eth: add support for DPAA Ethernet
Date: Mon, 20 Jul 2015 07:57:06 +0000 [thread overview]
Message-ID: <1437379026.10831.14.camel@transmode.se> (raw)
In-Reply-To: <1437378870.10831.12.camel@transmode.se>
On Mon, 2015-07-20 at 09:54 +0200, Joakim Tjernlund wrote:
> On Wed, 2015-04-01 at 19:19 +0300, Madalin Bucur wrote:
> > This introduces the Freescale Data Path Acceleration Architecture
> > (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan,
> > BMan, PAMU and FMan drivers to deliver Ethernet connectivity on
> > the Freescale DPAA QorIQ platforms.
> >=20
> > Signed-off-by: Madalin Bucur <madalin.bucur@freescale.com>
> > ---
> ....
> > + net_dev =3D alloc_etherdev_mq(sizeof(*priv), DPAA_ETH_TX_QUEUES);
> > + if (!net_dev) {
> > + dev_err(dev, "alloc_etherdev_mq() failed\n");
> > + goto alloc_etherdev_mq_failed;
> > + }
> > +
> > + snprintf(net_dev->name, IFNAMSIZ, "fm%d-mac%d",
> > + dpa_mac_fman_index_get(pdev),
> > + dpa_mac_hw_index_get(pdev));
>=20
> Should ethernet drivers dictate interface name in user space nowadays?
> I would prefer if you didn't.
>=20
> I am trying these patches on a custom T1042 board using Linux 4.1 but
> I cannot get Fixed PHY to work:
> libphy: PHY fixed-0:00 not found
> fsl_dpa dpaa-ethernet.2 eth2: Could not connect to PHY fixed-0:00
> fsl_dpa dpaa-ethernet.2 eth2: init_phy() =3D -19
>=20
> Not sure what I have missed here, any ideas?
I meant I am using http://git.freescale.com/git/cgit.cgi/ppc/upstream/linux=
.git/
on top of 4.1
Jocke
WARNING: multiple messages have this Message-ID (diff)
From: Joakim Tjernlund <joakim.tjernlund@transmode.se>
To: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"madalin.bucur@freescale.com" <madalin.bucur@freescale.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC 02/10] dpaa_eth: add support for DPAA Ethernet
Date: Mon, 20 Jul 2015 07:57:06 +0000 [thread overview]
Message-ID: <1437379026.10831.14.camel@transmode.se> (raw)
In-Reply-To: <1437378870.10831.12.camel@transmode.se>
On Mon, 2015-07-20 at 09:54 +0200, Joakim Tjernlund wrote:
> On Wed, 2015-04-01 at 19:19 +0300, Madalin Bucur wrote:
> > This introduces the Freescale Data Path Acceleration Architecture
> > (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan,
> > BMan, PAMU and FMan drivers to deliver Ethernet connectivity on
> > the Freescale DPAA QorIQ platforms.
> >
> > Signed-off-by: Madalin Bucur <madalin.bucur@freescale.com>
> > ---
> ....
> > + net_dev = alloc_etherdev_mq(sizeof(*priv), DPAA_ETH_TX_QUEUES);
> > + if (!net_dev) {
> > + dev_err(dev, "alloc_etherdev_mq() failed\n");
> > + goto alloc_etherdev_mq_failed;
> > + }
> > +
> > + snprintf(net_dev->name, IFNAMSIZ, "fm%d-mac%d",
> > + dpa_mac_fman_index_get(pdev),
> > + dpa_mac_hw_index_get(pdev));
>
> Should ethernet drivers dictate interface name in user space nowadays?
> I would prefer if you didn't.
>
> I am trying these patches on a custom T1042 board using Linux 4.1 but
> I cannot get Fixed PHY to work:
> libphy: PHY fixed-0:00 not found
> fsl_dpa dpaa-ethernet.2 eth2: Could not connect to PHY fixed-0:00
> fsl_dpa dpaa-ethernet.2 eth2: init_phy() = -19
>
> Not sure what I have missed here, any ideas?
I meant I am using http://git.freescale.com/git/cgit.cgi/ppc/upstream/linux.git/
on top of 4.1
Jocke
next prev parent reply other threads:[~2015-07-20 8:06 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 16:19 [PATCH RFC 02/10] dpaa_eth: add support for DPAA Ethernet Madalin Bucur
2015-04-01 16:19 ` Madalin Bucur
2015-04-01 16:19 ` [PATCH RFC 03/10] dpaa_eth: add configurable bpool thresholds Madalin Bucur
2015-04-01 16:19 ` Madalin Bucur
2015-04-01 16:19 ` [PATCH RFC 04/10] dpaa_eth: add support for S/G frames Madalin Bucur
2015-04-01 16:19 ` Madalin Bucur
2015-04-01 16:19 ` [PATCH RFC 05/10] dpaa_eth: add driver's Tx queue selection mechanism Madalin Bucur
2015-04-01 16:19 ` Madalin Bucur
2015-04-01 16:19 ` [PATCH RFC 06/10] dpaa_eth: add ethtool functionality Madalin Bucur
2015-04-01 16:19 ` Madalin Bucur
2015-04-01 16:19 ` [PATCH RFC 07/10] dpaa_eth: add sysfs exports Madalin Bucur
2015-04-01 16:19 ` Madalin Bucur
2015-04-01 16:19 ` [PATCH RFC 08/10] dpaa_eth: add debugfs counters Madalin Bucur
2015-04-01 16:19 ` Madalin Bucur
2015-04-01 16:19 ` [PATCH RFC 09/10] dpaa_eth: add debugfs entries Madalin Bucur
2015-04-01 16:19 ` Madalin Bucur
2015-04-01 16:19 ` [PATCH RFC 10/10] dpaa_eth: add trace points Madalin Bucur
2015-04-01 16:19 ` Madalin Bucur
2015-04-03 16:47 ` Joe Perches
2015-04-03 16:47 ` Joe Perches
2015-04-03 17:29 ` Madalin-Cristian Bucur
2015-04-03 17:29 ` Madalin-Cristian Bucur
2015-04-03 17:53 ` Joe Perches
2015-04-03 17:53 ` Joe Perches
2015-04-03 18:36 ` [PATCH] checkpatch: Add #define foo "string" long line exception Joe Perches
2015-04-01 17:11 ` [PATCH RFC 06/10] dpaa_eth: add ethtool functionality Joe Perches
2015-04-01 17:11 ` [PATCH RFC 02/10] dpaa_eth: add support for DPAA Ethernet Joe Perches
2015-04-02 10:44 ` Paul Bolle
2015-04-03 8:58 ` Madalin-Cristian Bucur
2015-04-03 8:58 ` Madalin-Cristian Bucur
2015-04-03 8:58 ` Madalin-Cristian Bucur
2015-07-20 7:54 ` Joakim Tjernlund
2015-07-20 7:54 ` Joakim Tjernlund
2015-07-20 7:57 ` Joakim Tjernlund [this message]
2015-07-20 7:57 ` Joakim Tjernlund
2015-07-20 12:18 ` Madalin-Cristian Bucur
2015-07-20 12:18 ` Madalin-Cristian Bucur
2015-07-20 12:46 ` Joakim Tjernlund
2015-07-20 12:46 ` Joakim Tjernlund
-- strict thread matches above, loose matches on Subject: below --
2015-04-03 8:37 Madalin-Cristian Bucur
2015-04-03 8:37 ` Madalin-Cristian Bucur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437379026.10831.14.camel@transmode.se \
--to=joakim.tjernlund@transmode.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@freescale.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.