* [PATCH] data_smart: Use deepcopy for overridedata
@ 2015-07-21 11:17 Richard Purdie
0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2015-07-21 11:17 UTC (permalink / raw)
To: bitbake-devel
dbus sets RDEPENDS_dbus-ptest_class-target = "X". nativesdk as
BBCLASSEXTEND was expanding and setting various RDEPENDS variables
which were clearing overrides queued against RDEPENDS. The problem
was that this was leaking into other data contexts such as the
target case. This was because overridedata was a shallow copy.
Replacing the shallow copy with a deep copy avoids this problem of
leakage between the data stores at a small performance penalty.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
diff --git a/bitbake/lib/bb/data_smart.py b/bitbake/lib/bb/data_smart.py
index dcf082d..86cdeb5 100644
--- a/bitbake/lib/bb/data_smart.py
+++ b/bitbake/lib/bb/data_smart.py
@@ -806,7 +806,7 @@ class DataSmart(MutableMapping):
data.overrides = None
data.overridevars = copy.copy(self.overridevars)
- data.overridedata = copy.copy(self.overridedata)
+ data.overridedata = copy.deepcopy(self.overridedata)
return data
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-07-21 11:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-21 11:17 [PATCH] data_smart: Use deepcopy for overridedata Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.