All of lore.kernel.org
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hp.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org,
	travis@sgi.com, roland@purestorage.com, dan.j.williams@intel.com,
	mcgrof@suse.com, x86@kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH RESEND 2/3] mm, x86: Remove region_is_ram() call from ioremap
Date: Tue, 21 Jul 2015 09:07:21 -0600	[thread overview]
Message-ID: <1437491241.3214.211.camel@hp.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1507211620250.18576@nanos>

On Tue, 2015-07-21 at 16:31 +0200, Thomas Gleixner wrote:
> On Thu, 16 Jul 2015, Toshi Kani wrote:
> > Note, removing the call to region_is_ram() is also necessary to
> > fix bugs in region_is_ram().  walk_system_ram_range() requires
> > RAM ranges be page-aligned in the iomem_resource table to work
> > properly.  This restriction has allowed multiple ioremaps to RAM
> > (setup_data) which are page-unaligned.  Using fixed region_is_ram()
> > will cause these callers to start failing.
> 
> Which callers? 

They are the callers I noticed.

 - Multiple ioremap calls from arch/x86/kernel/kdebugfs.c.
 - Multiple ioremap calls from arch/x86/kernel/ksysfs.c.
 - pcibios_add_device()

Thanks,
-Toshi


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hp.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org,
	travis@sgi.com, roland@purestorage.com, dan.j.williams@intel.com,
	mcgrof@suse.com, x86@kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH RESEND 2/3] mm, x86: Remove region_is_ram() call from ioremap
Date: Tue, 21 Jul 2015 09:07:21 -0600	[thread overview]
Message-ID: <1437491241.3214.211.camel@hp.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1507211620250.18576@nanos>

On Tue, 2015-07-21 at 16:31 +0200, Thomas Gleixner wrote:
> On Thu, 16 Jul 2015, Toshi Kani wrote:
> > Note, removing the call to region_is_ram() is also necessary to
> > fix bugs in region_is_ram().  walk_system_ram_range() requires
> > RAM ranges be page-aligned in the iomem_resource table to work
> > properly.  This restriction has allowed multiple ioremaps to RAM
> > (setup_data) which are page-unaligned.  Using fixed region_is_ram()
> > will cause these callers to start failing.
> 
> Which callers? 

They are the callers I noticed.

 - Multiple ioremap calls from arch/x86/kernel/kdebugfs.c.
 - Multiple ioremap calls from arch/x86/kernel/ksysfs.c.
 - pcibios_add_device()

Thanks,
-Toshi



  reply	other threads:[~2015-07-21 15:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 23:23 [PATCH RESEND 0/3] mm, x86: Fix ioremap RAM check interfaces Toshi Kani
2015-07-16 23:23 ` Toshi Kani
2015-07-16 23:23 ` [PATCH RESEND 1/3] mm, x86: Fix warning in ioremap RAM check Toshi Kani
2015-07-16 23:23   ` Toshi Kani
2015-07-22 15:25   ` [tip:x86/urgent] x86/mm: Move warning from __ioremap_check_ram() to the call site tip-bot for Toshi Kani
2015-07-22 15:36     ` Toshi Kani
2015-07-22 16:44       ` Thomas Gleixner
2015-07-22 16:56         ` Toshi Kani
2015-07-16 23:23 ` [PATCH RESEND 2/3] mm, x86: Remove region_is_ram() call from ioremap Toshi Kani
2015-07-16 23:23   ` Toshi Kani
2015-07-21 14:31   ` Thomas Gleixner
2015-07-21 14:31     ` Thomas Gleixner
2015-07-21 15:07     ` Toshi Kani [this message]
2015-07-21 15:07       ` Toshi Kani
2015-07-22 15:25   ` [tip:x86/urgent] x86/mm: " tip-bot for Toshi Kani
2015-07-16 23:23 ` [PATCH RESEND 3/3] mm: Fix bugs in region_is_ram() Toshi Kani
2015-07-16 23:23   ` Toshi Kani
2015-07-22 15:26   ` [tip:x86/urgent] " tip-bot for Toshi Kani
2015-07-18  1:23 ` [PATCH RESEND 0/3] mm, x86: Fix ioremap RAM check interfaces Dan Williams
2015-07-18  1:23   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437491241.3214.211.camel@hp.com \
    --to=toshi.kani@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=dan.j.williams@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mcgrof@suse.com \
    --cc=mingo@redhat.com \
    --cc=roland@purestorage.com \
    --cc=tglx@linutronix.de \
    --cc=travis@sgi.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.