All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: cs42l73: Fix mask for setting CS42L73_SP_3ST bit
@ 2015-07-23  0:26 Axel Lin
  2015-07-23 10:36 ` Austin, Brian
  2015-07-23 15:04 ` Applied "ASoC: cs42l73: Fix mask for setting CS42L73_SP_3ST bit" to the asoc tree Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2015-07-23  0:26 UTC (permalink / raw)
  To: Mark Brown; +Cc: Brian Austin, alsa-devel, Liam Girdwood, Paul Handrigan

CS42L73_SP_3ST is BIT(7), so the mask field is wrong. Fix it.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 sound/soc/codecs/cs42l73.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/cs42l73.c b/sound/soc/codecs/cs42l73.c
index 7cb1d70..be6477f 100644
--- a/sound/soc/codecs/cs42l73.c
+++ b/sound/soc/codecs/cs42l73.c
@@ -1236,8 +1236,8 @@ static int cs42l73_set_tristate(struct snd_soc_dai *dai, int tristate)
 	struct snd_soc_codec *codec = dai->codec;
 	int id = dai->id;
 
-	return snd_soc_update_bits(codec, CS42L73_SPC(id),
-					0x7F, tristate << 7);
+	return snd_soc_update_bits(codec, CS42L73_SPC(id), CS42L73_SP_3ST,
+				   tristate << 7);
 }
 
 static const struct snd_pcm_hw_constraint_list constraints_12_24 = {
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: cs42l73: Fix mask for setting CS42L73_SP_3ST bit
  2015-07-23  0:26 [PATCH] ASoC: cs42l73: Fix mask for setting CS42L73_SP_3ST bit Axel Lin
@ 2015-07-23 10:36 ` Austin, Brian
  2015-07-23 15:04 ` Applied "ASoC: cs42l73: Fix mask for setting CS42L73_SP_3ST bit" to the asoc tree Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Austin, Brian @ 2015-07-23 10:36 UTC (permalink / raw)
  To: Axel Lin
  Cc: alsa-devel@alsa-project.org, Mark Brown, Liam Girdwood,
	Handrigan, Paul



> On Jul 22, 2015, at 19:27, Axel Lin <axel.lin@ingics.com> wrote:
> 
> CS42L73_SP_3ST is BIT(7), so the mask field is wrong. Fix it.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Brian Austin <brian.austin@cirrus.com>

Thanks 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Applied "ASoC: cs42l73: Fix mask for setting CS42L73_SP_3ST bit" to the asoc tree
  2015-07-23  0:26 [PATCH] ASoC: cs42l73: Fix mask for setting CS42L73_SP_3ST bit Axel Lin
  2015-07-23 10:36 ` Austin, Brian
@ 2015-07-23 15:04 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2015-07-23 15:04 UTC (permalink / raw)
  To: Axel Lin, Brian Austin, Mark Brown; +Cc: alsa-devel

The patch

   ASoC: cs42l73: Fix mask for setting CS42L73_SP_3ST bit

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 8626e5eb6c33b78ba7a5eb7cfbc5109896f443ef Mon Sep 17 00:00:00 2001
From: Axel Lin <axel.lin@ingics.com>
Date: Thu, 23 Jul 2015 08:26:57 +0800
Subject: [PATCH] ASoC: cs42l73: Fix mask for setting CS42L73_SP_3ST bit

CS42L73_SP_3ST is BIT(7), so the mask field is wrong. Fix it.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Brian Austin <brian.austin@cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/cs42l73.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/cs42l73.c b/sound/soc/codecs/cs42l73.c
index b7853b9d3a60..efd924ae384c 100644
--- a/sound/soc/codecs/cs42l73.c
+++ b/sound/soc/codecs/cs42l73.c
@@ -1236,8 +1236,8 @@ static int cs42l73_set_tristate(struct snd_soc_dai *dai, int tristate)
 	struct snd_soc_codec *codec = dai->codec;
 	int id = dai->id;
 
-	return snd_soc_update_bits(codec, CS42L73_SPC(id),
-					0x7F, tristate << 7);
+	return snd_soc_update_bits(codec, CS42L73_SPC(id), CS42L73_SP_3ST,
+				   tristate << 7);
 }
 
 static const struct snd_pcm_hw_constraint_list constraints_12_24 = {
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-07-23 15:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-23  0:26 [PATCH] ASoC: cs42l73: Fix mask for setting CS42L73_SP_3ST bit Axel Lin
2015-07-23 10:36 ` Austin, Brian
2015-07-23 15:04 ` Applied "ASoC: cs42l73: Fix mask for setting CS42L73_SP_3ST bit" to the asoc tree Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.