From: Spencer Baugh <sbaugh@catern.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
David Rientjes <rientjes@google.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Mike Kravetz <mike.kravetz@oracle.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
open list <linux-kernel@vger.kernel.org>
Cc: Joern Engel <joern@purestorage.com>,
Spencer Baugh <Spencer.baugh@purestorage.com>,
Joern Engel <joern@logfs.org>, Spencer Baugh <sbaugh@catern.com>
Subject: [PATCH] hugetlb: cond_resched for set_max_huge_pages and follow_hugetlb_page
Date: Thu, 23 Jul 2015 14:54:31 -0700 [thread overview]
Message-ID: <1437688476-3399-1-git-send-email-sbaugh@catern.com> (raw)
From: Joern Engel <joern@logfs.org>
~150ms scheduler latency for both observed in the wild.
Signed-off-by: Joern Engel <joern@logfs.org>
Signed-off-by: Spencer Baugh <sbaugh@catern.com>
---
mm/hugetlb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index a8c3087..2eb6919 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1836,6 +1836,7 @@ static unsigned long set_max_huge_pages(struct hstate *h, unsigned long count,
ret = alloc_fresh_gigantic_page(h, nodes_allowed);
else
ret = alloc_fresh_huge_page(h, nodes_allowed);
+ cond_resched();
spin_lock(&hugetlb_lock);
if (!ret)
goto out;
@@ -3521,6 +3522,7 @@ long follow_hugetlb_page(struct mm_struct *mm, struct vm_area_struct *vma,
spin_unlock(ptl);
ret = hugetlb_fault(mm, vma, vaddr,
(flags & FOLL_WRITE) ? FAULT_FLAG_WRITE : 0);
+ cond_resched();
if (!(ret & VM_FAULT_ERROR))
continue;
--
2.5.0.rc3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Spencer Baugh <sbaugh@catern.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
David Rientjes <rientjes@google.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Mike Kravetz <mike.kravetz@oracle.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
linux-mm@kvack.org (open list:MEMORY MANAGEMENT),
linux-kernel@vger.kernel.org (open list)
Cc: Joern Engel <joern@purestorage.com>,
Spencer Baugh <Spencer.baugh@purestorage.com>,
Joern Engel <joern@logfs.org>, Spencer Baugh <sbaugh@catern.com>
Subject: [PATCH] hugetlb: cond_resched for set_max_huge_pages and follow_hugetlb_page
Date: Thu, 23 Jul 2015 14:54:31 -0700 [thread overview]
Message-ID: <1437688476-3399-1-git-send-email-sbaugh@catern.com> (raw)
From: Joern Engel <joern@logfs.org>
~150ms scheduler latency for both observed in the wild.
Signed-off-by: Joern Engel <joern@logfs.org>
Signed-off-by: Spencer Baugh <sbaugh@catern.com>
---
mm/hugetlb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index a8c3087..2eb6919 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1836,6 +1836,7 @@ static unsigned long set_max_huge_pages(struct hstate *h, unsigned long count,
ret = alloc_fresh_gigantic_page(h, nodes_allowed);
else
ret = alloc_fresh_huge_page(h, nodes_allowed);
+ cond_resched();
spin_lock(&hugetlb_lock);
if (!ret)
goto out;
@@ -3521,6 +3522,7 @@ long follow_hugetlb_page(struct mm_struct *mm, struct vm_area_struct *vma,
spin_unlock(ptl);
ret = hugetlb_fault(mm, vma, vaddr,
(flags & FOLL_WRITE) ? FAULT_FLAG_WRITE : 0);
+ cond_resched();
if (!(ret & VM_FAULT_ERROR))
continue;
--
2.5.0.rc3
next reply other threads:[~2015-07-23 21:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 21:54 Spencer Baugh [this message]
2015-07-23 21:54 ` [PATCH] hugetlb: cond_resched for set_max_huge_pages and follow_hugetlb_page Spencer Baugh
2015-07-23 22:08 ` David Rientjes
2015-07-23 22:08 ` David Rientjes
2015-07-23 22:36 ` Jörn Engel
2015-07-23 22:36 ` Jörn Engel
2015-07-23 22:54 ` David Rientjes
2015-07-23 22:54 ` David Rientjes
2015-07-23 23:09 ` Jörn Engel
2015-07-23 23:09 ` Jörn Engel
2015-07-24 19:49 ` David Rientjes
2015-07-24 19:49 ` David Rientjes
2015-07-24 20:49 ` Jörn Engel
2015-07-24 20:49 ` Jörn Engel
2015-07-24 6:59 ` Michal Hocko
2015-07-24 6:59 ` Michal Hocko
2015-07-24 17:12 ` Jörn Engel
2015-07-24 17:12 ` Jörn Engel
2015-07-24 20:28 ` Davidlohr Bueso
2015-07-24 20:28 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437688476-3399-1-git-send-email-sbaugh@catern.com \
--to=sbaugh@catern.com \
--cc=Spencer.baugh@purestorage.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=joern@logfs.org \
--cc=joern@purestorage.com \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.