From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH for-4.6 v2 8/8] libxl: remove dead code libxl__domain_shutdown_reason
Date: Tue, 28 Jul 2015 11:52:24 +0100 [thread overview]
Message-ID: <1438080744.11600.127.camel@citrix.com> (raw)
In-Reply-To: <1438019109-31997-9-git-send-email-wei.liu2@citrix.com>
On Mon, 2015-07-27 at 18:45 +0100, Wei Liu wrote:
> There is no user in tree.
git log -S libxl__domain_shutdown_reason
git log -S get_shutdown_reason
(the later being a rename that the former picks up on) suggests it has
_never_ been used!
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
> ---
> tools/libxl/libxl_dom.c | 17 -----------------
> tools/libxl/libxl_internal.h | 1 -
> 2 files changed, 18 deletions(-)
>
> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> index b3ae5b5..5555fea 100644
> --- a/tools/libxl/libxl_dom.c
> +++ b/tools/libxl/libxl_dom.c
> @@ -42,23 +42,6 @@ libxl_domain_type libxl__domain_type(libxl__gc *gc,
> uint32_t domid)
> return LIBXL_DOMAIN_TYPE_PV;
> }
>
> -int libxl__domain_shutdown_reason(libxl__gc *gc, uint32_t domid)
> -{
> - libxl_ctx *ctx = libxl__gc_owner(gc);
> - xc_domaininfo_t info;
> - int ret;
> -
> - ret = xc_domain_getinfolist(ctx->xch, domid, 1, &info);
> - if (ret != 1)
> - return -1;
> - if (info.domain != domid)
> - return -1;
> - if (!(info.flags & XEN_DOMINF_shutdown))
> - return -1;
> -
> - return (info.flags >> XEN_DOMINF_shutdownshift) &
> XEN_DOMINF_shutdownmask;
> -}
> -
> int libxl__domain_cpupool(libxl__gc *gc, uint32_t domid)
> {
> xc_domaininfo_t info;
> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index f2466dc..c7e4709 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -1042,7 +1042,6 @@ _hidden int
> libxl__file_reference_unmap(libxl__file_reference *f);
>
> /* from xl_dom */
> _hidden libxl_domain_type libxl__domain_type(libxl__gc *gc, uint32_t
> domid);
> -_hidden int libxl__domain_shutdown_reason(libxl__gc *gc, uint32_t
> domid);
> _hidden int libxl__domain_cpupool(libxl__gc *gc, uint32_t domid);
> _hidden libxl_scheduler libxl__domain_scheduler(libxl__gc *gc, uint32_t
> domid);
> _hidden int libxl__sched_set_params(libxl__gc *gc, uint32_t domid,
next prev parent reply other threads:[~2015-07-28 10:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 17:45 [PATCH for-4.6 v2 0/8] tools: fixes inspired by Coverity scan Wei Liu
2015-07-27 17:45 ` [PATCH for-4.6 v2 1/8] libxl: properly clean up array in libxl_list_cpupool failure path Wei Liu
2015-07-28 8:39 ` Dario Faggioli
2015-07-28 10:27 ` Ian Campbell
2015-07-27 17:45 ` [PATCH for-4.6 v2 2/8] xl: lockdir should be lockfile in error message Wei Liu
2015-07-28 10:27 ` Ian Campbell
2015-07-27 17:45 ` [PATCH for-4.6 v2 3/8] xl: call libxl_dominfo_init in main_list Wei Liu
2015-07-28 10:28 ` Ian Campbell
2015-07-27 17:45 ` [PATCH for-4.6 v2 4/8] xl: valid fd can be 0 in main_loadpolicy Wei Liu
2015-07-28 10:28 ` Ian Campbell
2015-07-27 17:45 ` [PATCH for-4.6 v2 5/8] xl: call libxl_dominfo_{init, dispose} in main_cpupoolnumasplit Wei Liu
2015-07-28 9:49 ` Dario Faggioli
2015-07-28 10:33 ` Ian Campbell
2015-07-27 17:45 ` [PATCH for-4.6 v2 6/8] libxlu: free buffer in failure path for PCI related functions Wei Liu
2015-07-28 10:35 ` Ian Campbell
2015-07-27 17:45 ` [PATCH for-4.6 v2 7/8] python/xc: reinstate original implementation of next_bdf Wei Liu
2015-07-27 22:58 ` Andrew Cooper
2015-07-28 1:06 ` Chen, Tiejun
2015-07-28 10:38 ` Ian Campbell
2015-07-28 10:44 ` Wei Liu
2015-07-27 17:45 ` [PATCH for-4.6 v2 8/8] libxl: remove dead code libxl__domain_shutdown_reason Wei Liu
2015-07-28 10:52 ` Ian Campbell [this message]
2015-07-28 11:08 ` [PATCH for-4.6 v2 0/8] tools: fixes inspired by Coverity scan Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438080744.11600.127.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.