Re: Patch "hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead" has been added to the 3.10-stable tree

[Joe Perches <joe@perches.com>]

On Fri, 2015-07-31 at 23:27 +0200, Mikulas Patocka wrote:
> On Fri, 31 Jul 2015, Joe Perches wrote:
> 
> > On Fri, 2015-07-31 at 13:03 -0700, Greg KH wrote:
> > > On Fri, Jul 31, 2015 at 12:42:35PM -0700, Joe Perches wrote:
> > > > On Fri, 2015-07-31 at 12:37 -0700,  
> gregkh@linuxfoundation.orgwrote:
> > > > > This is a note to let you know that I've just added the 
> patch 
> > > > > titled
> > > > > 
> > > > >     hpfs: hpfs_error: Remove static buffer, use vsprintf 
> > > > > extension %pV instead
> > > > > 
> > > > > to the 3.10-stable tree which can be found at:
> > > > >     
> > > > > 
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > > > 
> > > > While I know this patch reduces some code and text,
> > > > it's not correcting any defect in the code, it's
> > > > only a minor optimization.
> > > > 
> > > > Is it really appropriate for stable?
> > > 
> > > I agree, why was it marked that way?  I assumed it was due to 
> the 
> > > patch
> > > after it needed it, but maybe not.  Any objection to me just 
> dropping
> > > it?
> > 
> > Not from me.
> > 
> > I think Mikulas marked it for stable.
> > 
> > Mikulas?
> 
> The bug corrected by the patch is - if hpfs_error is called 
> concurrently 
> on multiple filesystems, it could corrupt the string because the 
> text 
> buffer is shared. That's why I marked the patch for stable.

OK then.  If you noticed that when you marked it
for stable, it would have been nicer to update the
commit message to show a bug fix too.

cheers, Joe