From: Joe Perches <joe@perches.com>
To: Tomer Barletz <barletz@gmail.com>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
clemens@ladisch.de, tiwai@suse.com
Subject: Re: [PATCH] Fix logical-not-parentheses warning
Date: Sun, 02 Aug 2015 07:16:25 -0700 [thread overview]
Message-ID: <1438524985.1301.26.camel@perches.com> (raw)
In-Reply-To: <1438506537-26743-1-git-send-email-barletz@gmail.com>
On Sun, 2015-08-02 at 02:08 -0700, Tomer Barletz wrote:
> This fixes the following warning, that is seen with gcc 5.1:
> warning: logical not is only applied to the left hand side of
> comparison [-Wlogical-not-parentheses].
[]
> diff --git a/sound/pci/oxygen/oxygen_mixer.c
[]
>
@@ -88,7 +88,7 @@ static int dac_mute_put(struct snd_kcontrol *ctl,
> int changed;
>
> mutex_lock(&chip->mutex);
> - changed = !value->value.integer.value[0] != chip->dac_mute;
> + changed = (!value->value.integer.value[0]) != chip->dac_mute;
It seems this is because dac_mute's value is inverted
0 means true, 1 is false.
I think it'd be simpler if dac_mute was converted to a
standard bool (or perhaps renamed to not_muted) and
this test was rewritten.
Using !!value->value.integer.value[0] would also be
more readable and intelligible.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Tomer Barletz <barletz@gmail.com>
Cc: clemens@ladisch.de, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix logical-not-parentheses warning
Date: Sun, 02 Aug 2015 07:16:25 -0700 [thread overview]
Message-ID: <1438524985.1301.26.camel@perches.com> (raw)
In-Reply-To: <1438506537-26743-1-git-send-email-barletz@gmail.com>
On Sun, 2015-08-02 at 02:08 -0700, Tomer Barletz wrote:
> This fixes the following warning, that is seen with gcc 5.1:
> warning: logical not is only applied to the left hand side of
> comparison [-Wlogical-not-parentheses].
[]
> diff --git a/sound/pci/oxygen/oxygen_mixer.c
[]
>
@@ -88,7 +88,7 @@ static int dac_mute_put(struct snd_kcontrol *ctl,
> int changed;
>
> mutex_lock(&chip->mutex);
> - changed = !value->value.integer.value[0] != chip->dac_mute;
> + changed = (!value->value.integer.value[0]) != chip->dac_mute;
It seems this is because dac_mute's value is inverted
0 means true, 1 is false.
I think it'd be simpler if dac_mute was converted to a
standard bool (or perhaps renamed to not_muted) and
this test was rewritten.
Using !!value->value.integer.value[0] would also be
more readable and intelligible.
next prev parent reply other threads:[~2015-08-02 14:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-02 5:43 [PATCH] Fix logical-not-parentheses warning Tomer Barletz
2015-08-02 7:10 ` Takashi Iwai
2015-08-02 7:10 ` Takashi Iwai
2015-08-02 9:08 ` Tomer Barletz
2015-08-02 14:16 ` Joe Perches [this message]
2015-08-02 14:16 ` Joe Perches
2015-08-03 8:15 ` Takashi Iwai
2015-08-03 8:15 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438524985.1301.26.camel@perches.com \
--to=joe@perches.com \
--cc=alsa-devel@alsa-project.org \
--cc=barletz@gmail.com \
--cc=clemens@ladisch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.