From: Ian Campbell <ian.campbell@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH for-4.6 v2 1/6] tools/libxl: Make libxl__conversion_helper_abort() safe to use
Date: Tue, 4 Aug 2015 10:30:03 +0100 [thread overview]
Message-ID: <1438680603.31129.64.camel@citrix.com> (raw)
In-Reply-To: <1438617395-20329-2-git-send-email-andrew.cooper3@citrix.com>
On Mon, 2015-08-03 at 16:56 +0100, Andrew Cooper wrote:
> Previously, in the case of an error causing a call to
> libxl__conversion_helper_abort() on a stream without legacy conversion,
> libxl would fall over a NULL pointer because chs->ao was not set up.
>
> Arrange for all ->ao's to be set up at _init() time, by having each
> _init() function assert that their caller has done the right thing.
> While doing so, introduce a previously-missing save_helper_init() in
> stream_read_init().
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
>
> v2: Make sure ->ao is always valid
I believe this + the extra comment in libxl__conversion_helper_state
addresses Ian J's feedback from the previous round, so:
Acked-by: Ian Campbell <ian.campbell@citrix.com>
next prev parent reply other threads:[~2015-08-04 9:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 15:56 [PATCH for-4.6 v2 0/6] Fix libxl TOOLSTACK records for migration v2 Andrew Cooper
2015-08-03 15:56 ` [PATCH for-4.6 v2 1/6] tools/libxl: Make libxl__conversion_helper_abort() safe to use Andrew Cooper
2015-08-04 9:30 ` Ian Campbell [this message]
2015-08-03 15:56 ` [PATCH for-4.6 v2 2/6] docs/libxl: Re-specify XENSTORE_DATA as EMULATOR_XENSTORE_DATA Andrew Cooper
2015-08-04 9:40 ` Ian Campbell
2015-08-04 9:42 ` Andrew Cooper
2015-08-04 10:06 ` Ian Campbell
2015-08-04 10:16 ` Andrew Cooper
2015-08-03 15:56 ` [PATCH for-4.6 v2 3/6] tools/libxl: Save and restore EMULATOR_XENSTORE_DATA content Andrew Cooper
2015-08-04 9:55 ` Ian Campbell
2015-08-03 15:56 ` [PATCH for-4.6 v2 4/6] tools/libxl: Prepare to write multiple records with EMULATOR headers Andrew Cooper
2015-08-04 9:59 ` Ian Campbell
2015-08-03 15:56 ` [PATCH for-4.6 v2 5/6] libxl/save&restore&convert: Switch to new EMULATOR_XENSTORE_DATA records Andrew Cooper
2015-08-03 15:56 ` [PATCH for-4.6 v2 6/6] tools/libxl: Drop all legacy "toolstack" record infrastructure Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438680603.31129.64.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.