[PATCH for-4.6] libxl: increase hotplug timeout to 40s

[PATCH for-4.6] libxl: increase hotplug timeout to 40s

[Roger Pau Monne]

The default libxl timeout for hotplug scripts execution is too low, when
launching 40 HVM guests in parallel, all using the same file as disk,
execution times of ~20s are expected. Increase the timeout to 40s in order
to be sure hotplug scripts have enough time to execute.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
 tools/libxl/libxl_internal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index 911de2d..0e79cde 100644
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -86,7 +86,7 @@
 
 #define LIBXL_INIT_TIMEOUT 10
 #define LIBXL_DESTROY_TIMEOUT 10
-#define LIBXL_HOTPLUG_TIMEOUT 10
+#define LIBXL_HOTPLUG_TIMEOUT 40
 /* QEMU may be slow to load and start due to a bug in Linux where the I/O
  * subsystem sometime produce high latency under load. */
 #define LIBXL_DEVICE_MODEL_START_TIMEOUT 60
-- 
1.9.5 (Apple Git-50.3)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH for-4.6] libxl: increase hotplug timeout to 40s

[Wei Liu]

On Tue, Aug 04, 2015 at 12:02:55PM +0200, Roger Pau Monne wrote:
> The default libxl timeout for hotplug scripts execution is too low, when
> launching 40 HVM guests in parallel, all using the same file as disk,
> execution times of ~20s are expected. Increase the timeout to 40s in order
> to be sure hotplug scripts have enough time to execute.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>

As I understand this from the discussion in the other thread, there is
no regression in hotplug scripts. Increasing the timeout is a reasonable
solution for 4.6.

Acked-by: Wei Liu <wei.liu2@citrix.com>

Might be worth mentioning this is short term solution in commit message
though.

> ---
>  tools/libxl/libxl_internal.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index 911de2d..0e79cde 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -86,7 +86,7 @@
>  
>  #define LIBXL_INIT_TIMEOUT 10
>  #define LIBXL_DESTROY_TIMEOUT 10
> -#define LIBXL_HOTPLUG_TIMEOUT 10
> +#define LIBXL_HOTPLUG_TIMEOUT 40
>  /* QEMU may be slow to load and start due to a bug in Linux where the I/O
>   * subsystem sometime produce high latency under load. */
>  #define LIBXL_DEVICE_MODEL_START_TIMEOUT 60
> -- 
> 1.9.5 (Apple Git-50.3)

Re: [PATCH for-4.6] libxl: increase hotplug timeout to 40s

[Ian Campbell]

On Tue, 2015-08-04 at 11:26 +0100, Wei Liu wrote:
> On Tue, Aug 04, 2015 at 12:02:55PM +0200, Roger Pau Monne wrote:
> > The default libxl timeout for hotplug scripts execution is too low, 
> > when
> > launching 40 HVM guests in parallel, all using the same file as disk,
> > execution times of ~20s are expected. Increase the timeout to 40s in 
> > order
> > to be sure hotplug scripts have enough time to execute.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > ---
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Wei Liu <wei.liu2@citrix.com>
> 
> As I understand this from the discussion in the other thread, there is
> no regression in hotplug scripts. Increasing the timeout is a reasonable
> solution for 4.6.
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>
> 
> Might be worth mentioning this is short term solution in commit message
> though.

After consultation on IRC I added "This is a short term solution" and
applied, thanks.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel