From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 09/16] mtd/nand/tegra: alignment workaround
Date: Wed, 5 Aug 2015 22:12:40 +0000 [thread overview]
Message-ID: <1438812758.2747.22.camel@toradex.com> (raw)
In-Reply-To: <050699AD-D04F-45D7-9BAF-B03A7FA97652@ziswiler.com>
On Tue, 2015-07-28 at 03:55 +0200, Marcel Ziswiler wrote:
>
> On 27 July 2015 21:57:14 CEST, Scott Wood <scottwood@freescale.com>
> wrote:
> > > - writel(virt_to_phys(buf), &info->reg->data_block_ptr);
> > > + writel((u32)bbstate.bounce_buffer, &info->reg
> > > ->data_block_ptr);
> >
> > Why are you converting usage of virt_to_phys() into a u32 cast?
>
> Good question. I believe this I took straight from the MMC driver but
> will double check it again for a v3.
Yes, the MMC driver actually even does a double cast. Don't knowexactly what that should bring but that's how it looks there:
writel((u32)(unsigned long)bbstate->bounce_buffer, &host->reg->sysad);
http://git.denx.de/?p=u-boot.git;a=blob;f=drivers/mmc/tegra_mmc.c;hb=HEAD#l70
Nonetheless I changed it back to using virt_to_phys() for the v3 to beposted soon.
next prev parent reply other threads:[~2015-08-05 22:12 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 22:35 [U-Boot] [PATCH v2 00/16] assortment of tegra fixes/enhancements Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 01/16] ARM: tegra: allow custom usb manufacturer/product/vendor ids/strings Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 02/16] ARM: tegra: allow reading recovery mode boot type Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 03/16] apalis/colibri_t20/t30: integrate recovery mode detection Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 04/16] colibri_t20: fix device-tree compatible node Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 05/16] colibri_t20: add lcd display support Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 06/16] colibri_t20: add i2c support Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 07/16] colibri_t20: disable PMIC sleep mode on low supply voltage Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 08/16] tegra: nand: fix read_byte required for proper onfi detection Marcel Ziswiler
2015-07-27 20:00 ` Scott Wood
2015-07-28 2:05 ` Marcel Ziswiler
2015-07-28 2:17 ` Scott Wood
2015-07-20 22:35 ` [U-Boot] [PATCH v2 09/16] mtd/nand/tegra: alignment workaround Marcel Ziswiler
2015-07-27 19:57 ` Scott Wood
2015-07-27 23:28 ` Simon Glass
2015-07-27 23:32 ` Scott Wood
2015-07-28 2:09 ` Marcel Ziswiler
2015-07-28 1:55 ` Marcel Ziswiler
2015-07-28 2:15 ` Scott Wood
2015-08-05 22:12 ` Marcel Ziswiler [this message]
2015-08-05 22:16 ` Scott Wood
2015-07-20 22:35 ` [U-Boot] [PATCH v2 10/16] colibri_t20: enable mtdparts support Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 11/16] colibri_t20: enable ubi/ubifs support Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 12/16] apalis/colibri_t20/t30: enable raw initrd support Marcel Ziswiler
2015-07-27 19:45 ` Stephen Warren
2015-07-28 1:27 ` Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 13/16] apalis/colibri_t20/t30: increase tftp blocksize Marcel Ziswiler
2015-07-27 19:46 ` Stephen Warren
2015-07-28 1:38 ` Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 14/16] apalis/colibri_t20/30: clean-up Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 15/16] colibri_t20: fix reset out pin Marcel Ziswiler
2015-07-20 22:35 ` [U-Boot] [PATCH v2 16/16] apalis/colibri_t30: fix usb dm regression Marcel Ziswiler
2015-07-27 19:48 ` Stephen Warren
2015-07-28 1:44 ` Marcel Ziswiler
2015-07-27 19:49 ` [U-Boot] [PATCH v2 00/16] assortment of tegra fixes/enhancements Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438812758.2747.22.camel@toradex.com \
--to=marcel.ziswiler@toradex.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.