All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: julien.grall@citrix.com, stefano.stabellini@eu.citrix.com,
	ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH for-4.6] libxl: use correct command line for arm guests.
Date: Thu, 6 Aug 2015 13:58:40 +0100	[thread overview]
Message-ID: <1438865920.9747.152.camel@citrix.com> (raw)
In-Reply-To: <20150806111059.GL15719@zion.uk.xensource.com>

On Thu, 2015-08-06 at 12:10 +0100, Wei Liu wrote:
> On Thu, Aug 06, 2015 at 11:55:57AM +0100, Ian Campbell wrote:
> > We need to use libxl__domain_build_state.pv_cmdline in order to pickup
> > the correct args when using pygrub. libxl_domain_build_info.cmdline is
> > any args statically configured by the user.
> > 
> > This is consistent with the call to xc_domain_allocate, which takes
> > the cmdline too (in that case for x86/PV usage).
> > 
> > state->pv_cmdline is also set for non-pygrub guests, since
> > libxl_bootloader_run propagates info->cmdline if no bootloader is
> 
> libxl__bootloader_run

Fixed.

> > condfigured.

... and this.

> > 
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>

Thanks.
> 
> > ---
> > For 4.6: This makes pygrub work on ARM.
> > 
> 
> It's very low risk. Apply as you see fit.

Done, thanks.

      reply	other threads:[~2015-08-06 12:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-06 10:55 [PATCH for-4.6] libxl: use correct command line for arm guests Ian Campbell
2015-08-06 11:10 ` Wei Liu
2015-08-06 12:58   ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438865920.9747.152.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=julien.grall@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.