From: Alexander Aring <alex.aring@gmail.com>
To: linux-wpan@vger.kernel.org
Cc: kernel@pengutronix.de, Alexander Aring <alex.aring@gmail.com>
Subject: [PATCH bluetooth-next 3/8] mac802154: fix wpan mac setting while lowpan is there
Date: Mon, 10 Aug 2015 21:15:54 +0200 [thread overview]
Message-ID: <1439234159-11630-4-git-send-email-alex.aring@gmail.com> (raw)
In-Reply-To: <1439234159-11630-1-git-send-email-alex.aring@gmail.com>
If we currently change the mac address inside the wpan interface while
we have a lowpan interface on top of the wpan interface, the mac address
setting doesn't reach the lowpan interface. The effect would be that the
IPv6 lowpan interface has the old SLAAC address and isn't working
anymore because the lowpan interface use in internal mechanism sometimes
dev->addr which is the old mac address of the wpan interface.
This patch checks if a wpan interface belongs to lowpan interface, if
yes then we need to check if the lowpan interface is down and change the
mac address also at the lowpan interface. When the lowpan interface will
be set up afterwards, it will use the correct SLAAC address which based
on the updated mac address setting.
Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
Tested-by: Stefan Schmidt <stefan@osg.samsung.com>
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
net/mac802154/iface.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/net/mac802154/iface.c b/net/mac802154/iface.c
index 416de90..ff99055 100644
--- a/net/mac802154/iface.c
+++ b/net/mac802154/iface.c
@@ -125,6 +125,14 @@ static int mac802154_wpan_mac_addr(struct net_device *dev, void *p)
if (netif_running(dev))
return -EBUSY;
+ /* lowpan need to be down for update
+ * SLAAC address after ifup
+ */
+ if (sdata->wpan_dev.lowpan_dev) {
+ if (netif_running(sdata->wpan_dev.lowpan_dev))
+ return -EBUSY;
+ }
+
ieee802154_be64_to_le64(&extended_addr, addr->sa_data);
if (!ieee802154_is_valid_extended_unicast_addr(extended_addr))
return -EINVAL;
@@ -132,6 +140,13 @@ static int mac802154_wpan_mac_addr(struct net_device *dev, void *p)
memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
sdata->wpan_dev.extended_addr = extended_addr;
+ /* update lowpan interface mac address when
+ * wpan mac has been changed
+ */
+ if (sdata->wpan_dev.lowpan_dev)
+ memcpy(sdata->wpan_dev.lowpan_dev->dev_addr, dev->dev_addr,
+ dev->addr_len);
+
return mac802154_wpan_update_llsec(dev);
}
--
2.5.0
next prev parent reply other threads:[~2015-08-10 17:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 19:15 [PATCH bluetooth-next 0/8] ieee802154: pending patches Alexander Aring
2015-08-10 19:15 ` [PATCH bluetooth-next 1/8] 6lowpan: Fix extraction of flow label field Alexander Aring
2015-08-10 19:15 ` [PATCH bluetooth-next 2/8] ieee802154: 6lowpan: remove multiple lowpan per wpan support Alexander Aring
2015-08-10 19:15 ` Alexander Aring [this message]
2015-08-10 19:15 ` [PATCH bluetooth-next 4/8] mac802154: cfg: remove test and set checks Alexander Aring
2015-08-10 19:15 ` [PATCH bluetooth-next 5/8] mac802154: change frame_retries behaviour Alexander Aring
2015-08-10 19:15 ` [PATCH bluetooth-next 6/8] at86rf230: use STATE_TX_ARET mode only Alexander Aring
2015-08-10 19:15 ` [PATCH bluetooth-next 7/8] ieee802154: add ack request default handling Alexander Aring
2015-08-10 19:15 ` [PATCH bluetooth-next 8/8] ieee802154: 6lowpan: fix error frag handling Alexander Aring
2015-08-10 19:30 ` [PATCH bluetooth-next 0/8] ieee802154: pending patches Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439234159-11630-4-git-send-email-alex.aring@gmail.com \
--to=alex.aring@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-wpan@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.