From: Alexander Aring <alex.aring@gmail.com>
To: linux-wpan@vger.kernel.org
Cc: kernel@pengutronix.de, Alexander Aring <alex.aring@gmail.com>
Subject: [PATCH bluetooth-next 4/8] mac802154: cfg: remove test and set checks
Date: Mon, 10 Aug 2015 21:15:55 +0200 [thread overview]
Message-ID: <1439234159-11630-5-git-send-email-alex.aring@gmail.com> (raw)
In-Reply-To: <1439234159-11630-1-git-send-email-alex.aring@gmail.com>
This patch removes several checks if a value is really changed. This
makes only sense if we have another layer call e.g. calling the
driver_ops which is done by callbacks like "set_channel".
For MAC settings which need to be set by phy registers (if the phy
supports that handling) this is set by doing an interface up currently
and are not direct driver_ops calls, so we remove the checks from these
configuration callbacks.
Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
Suggested-by: Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
net/mac802154/cfg.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/net/mac802154/cfg.c b/net/mac802154/cfg.c
index f7ba51e..cecfcda 100644
--- a/net/mac802154/cfg.c
+++ b/net/mac802154/cfg.c
@@ -209,10 +209,6 @@ ieee802154_set_backoff_exponent(struct wpan_phy *wpan_phy,
{
ASSERT_RTNL();
- if (wpan_dev->min_be == min_be &&
- wpan_dev->max_be == max_be)
- return 0;
-
wpan_dev->min_be = min_be;
wpan_dev->max_be = max_be;
return 0;
@@ -224,9 +220,6 @@ ieee802154_set_short_addr(struct wpan_phy *wpan_phy, struct wpan_dev *wpan_dev,
{
ASSERT_RTNL();
- if (wpan_dev->short_addr == short_addr)
- return 0;
-
wpan_dev->short_addr = short_addr;
return 0;
}
@@ -238,9 +231,6 @@ ieee802154_set_max_csma_backoffs(struct wpan_phy *wpan_phy,
{
ASSERT_RTNL();
- if (wpan_dev->csma_retries == max_csma_backoffs)
- return 0;
-
wpan_dev->csma_retries = max_csma_backoffs;
return 0;
}
@@ -252,9 +242,6 @@ ieee802154_set_max_frame_retries(struct wpan_phy *wpan_phy,
{
ASSERT_RTNL();
- if (wpan_dev->frame_retries == max_frame_retries)
- return 0;
-
wpan_dev->frame_retries = max_frame_retries;
return 0;
}
@@ -265,9 +252,6 @@ ieee802154_set_lbt_mode(struct wpan_phy *wpan_phy, struct wpan_dev *wpan_dev,
{
ASSERT_RTNL();
- if (wpan_dev->lbt == mode)
- return 0;
-
wpan_dev->lbt = mode;
return 0;
}
--
2.5.0
next prev parent reply other threads:[~2015-08-10 17:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 19:15 [PATCH bluetooth-next 0/8] ieee802154: pending patches Alexander Aring
2015-08-10 19:15 ` [PATCH bluetooth-next 1/8] 6lowpan: Fix extraction of flow label field Alexander Aring
2015-08-10 19:15 ` [PATCH bluetooth-next 2/8] ieee802154: 6lowpan: remove multiple lowpan per wpan support Alexander Aring
2015-08-10 19:15 ` [PATCH bluetooth-next 3/8] mac802154: fix wpan mac setting while lowpan is there Alexander Aring
2015-08-10 19:15 ` Alexander Aring [this message]
2015-08-10 19:15 ` [PATCH bluetooth-next 5/8] mac802154: change frame_retries behaviour Alexander Aring
2015-08-10 19:15 ` [PATCH bluetooth-next 6/8] at86rf230: use STATE_TX_ARET mode only Alexander Aring
2015-08-10 19:15 ` [PATCH bluetooth-next 7/8] ieee802154: add ack request default handling Alexander Aring
2015-08-10 19:15 ` [PATCH bluetooth-next 8/8] ieee802154: 6lowpan: fix error frag handling Alexander Aring
2015-08-10 19:30 ` [PATCH bluetooth-next 0/8] ieee802154: pending patches Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439234159-11630-5-git-send-email-alex.aring@gmail.com \
--to=alex.aring@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-wpan@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.