Re: [PATCH OSSTEST] Toolstack/libvirt: use URI in migration command

[Ian Campbell <ian.campbell@citrix.com>]

On Tue, 2015-08-11 at 16:07 -0600, Jim Fehlig wrote:
> Wei Liu wrote:
> > Virsh migrate expects an URI, not a host. We don't actually care what
> > kind of transport it uses, the main objective is to test migration, so
> > use xen+ssh for the time being.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > ---
> > Cc: Jim Fehlig <jfehlig@suse.com>
> > 
> > I once had email exchange with Jim and he said xen+ssh was a commonly
> > use configuration.
> > 
> > Jim, I hope I got the URI right. The constructed command will be like
> > 
> >    virsh migrate guest xen+ssh://dst-host
> >   
> 
> Yes, that is correct. Note you will need a '--live' option if live
> migration is what you are after
> 
>   virsh migrate --live guest xen+ssh://dst-host

I think we probably do want live (xl does it by default).

I suggest we also do
    my $duri = "xen+ssh://$dst";
else the line is probably going to get a bit long.

So I propose to fold in this:

diff --git a/Osstest/Toolstack/libvirt.pm b/Osstest/Toolstack/libvirt.pm
index 477ebee..776432d 100644
--- a/Osstest/Toolstack/libvirt.pm
+++ b/Osstest/Toolstack/libvirt.pm
@@ -108,7 +108,8 @@ sub migrate ($$$$) {
     my $sho = $self->{Host};
     my $dst = $dho->{Name};
     my $gn = $gho->{Name};
-    target_cmd_root($sho, "virsh migrate $gn xen+ssh://$dst", $timeout);
+    my $duri = "xen+ssh://$dst";
+    target_cmd_root($sho, "virsh migrate --live $gn $duri", $timeout);
 }
 
 sub save ($$$$) {

Ian.