All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chen, Yu C" <yu.c.chen@intel.com>
To: "joeyli.kernel@gmail.com" <joeyli.kernel@gmail.com>
Cc: "matthew.garrett@nebula.com" <matthew.garrett@nebula.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"jlee@suse.com" <jlee@suse.com>,
	"vojtech@suse.cz" <vojtech@suse.cz>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"pavel@ucw.cz" <pavel@ucw.cz>,
	"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
	"jkosina@suse.cz" <jkosina@suse.cz>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	"Brown, Len" <len.brown@intel.com>,
	"jwboyer@redhat.com" <jwboyer@redhat.com>,
	"Fleming, Matt" <matt.fleming@intel.com>
Subject: Re: [PATCH v2 09/16] PM / hibernate: Reserve hibernation key and erase footprints
Date: Thu, 13 Aug 2015 02:45:32 +0000	[thread overview]
Message-ID: <1439434143.15722.12.camel@localhost> (raw)
In-Reply-To: <1439273796-25359-10-git-send-email-jlee@suse.com>

Hi Chun-yi,
On Tue, 2015-08-11 at 14:16 +0800, Lee, Chun-Yi wrote:

> +/* A page used to keep hibernation keys */
> +static struct hibernation_keys *hibernation_keys;
> +
> +void __init parse_hibernation_keys(u64 phys_addr, u32 data_len)
> +{
> +	struct setup_data *hibernation_setup_data;
> +
> +	/* Reserve keys memory, will copy and erase in init_hibernation_keys() */
> +	keys_phys_addr = phys_addr + sizeof(struct setup_data);
> +	memblock_reserve(keys_phys_addr, sizeof(struct hibernation_keys));
> +
> +	/* clear hibernation_data */
> +	hibernation_setup_data = early_memremap(phys_addr, data_len);
> +	if (!hibernation_setup_data)
> +		return;
> +
should we invoke memblock_free if early_memremap failed?

Best Regards,
Yu



WARNING: multiple messages have this Message-ID (diff)
From: "Chen, Yu C" <yu.c.chen@intel.com>
To: "joeyli.kernel@gmail.com" <joeyli.kernel@gmail.com>
Cc: "matthew.garrett@nebula.com" <matthew.garrett@nebula.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"jlee@suse.com" <jlee@suse.com>,
	"vojtech@suse.cz" <vojtech@suse.cz>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"pavel@ucw.cz" <pavel@ucw.cz>,
	"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
	"jkosina@suse.cz" <jkosina@suse.cz>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	"Brown, Len" <len.brown@intel.com>,
	"jwboyer@redhat.com" <jwboyer@redhat.com>,
	"Fleming, Matt" <matt.fleming@intel.com>
Subject: Re: [PATCH v2 09/16] PM / hibernate: Reserve hibernation key and erase footprints
Date: Thu, 13 Aug 2015 02:45:32 +0000	[thread overview]
Message-ID: <1439434143.15722.12.camel@localhost> (raw)
In-Reply-To: <1439273796-25359-10-git-send-email-jlee@suse.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 893 bytes --]

Hi Chun-yi,
On Tue, 2015-08-11 at 14:16 +0800, Lee, Chun-Yi wrote:

> +/* A page used to keep hibernation keys */
> +static struct hibernation_keys *hibernation_keys;
> +
> +void __init parse_hibernation_keys(u64 phys_addr, u32 data_len)
> +{
> +	struct setup_data *hibernation_setup_data;
> +
> +	/* Reserve keys memory, will copy and erase in init_hibernation_keys() */
> +	keys_phys_addr = phys_addr + sizeof(struct setup_data);
> +	memblock_reserve(keys_phys_addr, sizeof(struct hibernation_keys));
> +
> +	/* clear hibernation_data */
> +	hibernation_setup_data = early_memremap(phys_addr, data_len);
> +	if (!hibernation_setup_data)
> +		return;
> +
should we invoke memblock_free if early_memremap failed?

Best Regards,
Yu


ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  reply	other threads:[~2015-08-13  2:45 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11  6:16 [PATCH v2 00/16] Signature verification of hibernate snapshot Lee, Chun-Yi
2015-08-11  6:16 ` [PATCH v2 01/16] PM / hibernate: define HMAC algorithm and digest size of hibernation Lee, Chun-Yi
2015-08-11  6:16 ` [PATCH v2 02/16] x86/efi: Add get and set variable to EFI services pointer table Lee, Chun-Yi
     [not found]   ` <1439273796-25359-3-git-send-email-jlee-IBi9RG/b67k@public.gmane.org>
2015-08-19 16:35     ` Matt Fleming
2015-08-19 16:35       ` Matt Fleming
2015-08-11  6:16 ` [PATCH v2 03/16] x86/boot: Public getting random boot function Lee, Chun-Yi
2015-08-11  6:16 ` [PATCH v2 04/16] x86/efi: Generating random number in EFI stub Lee, Chun-Yi
2015-08-20 14:12   ` Matt Fleming
     [not found]     ` <20150820141221.GC2567-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-08-27  4:06       ` joeyli
2015-08-27  4:06         ` joeyli
2015-08-11  6:16 ` [PATCH v2 05/16] x86/efi: Get entropy through EFI random number generator protocol Lee, Chun-Yi
2015-08-20 14:47   ` Matt Fleming
2015-08-27  4:51     ` joeyli
     [not found]   ` <1439273796-25359-6-git-send-email-jlee-IBi9RG/b67k@public.gmane.org>
2015-08-20 20:26     ` Matt Fleming
2015-08-20 20:26       ` Matt Fleming
     [not found]       ` <20150820202620.GF2567-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-08-27  6:17         ` joeyli
2015-08-27  6:17           ` joeyli
2015-08-11  6:16 ` [PATCH v2 06/16] x86/efi: Generating random HMAC key for siging hibernate image Lee, Chun-Yi
2015-08-20 20:40   ` Matt Fleming
2015-08-27  9:04     ` joeyli
     [not found]       ` <20150827090452.GB27415-empE8CJ7fzk2xCFIczX1Fw@public.gmane.org>
2015-09-09 12:15         ` Matt Fleming
2015-09-09 12:15           ` Matt Fleming
2015-09-13  2:47           ` joeyli
2015-08-11  6:16 ` [PATCH v2 07/16] efi: Make efi_status_to_err() public Lee, Chun-Yi
2015-08-20 15:07   ` Matt Fleming
     [not found]     ` <20150820150706.GE2567-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-08-27  9:06       ` joeyli
2015-08-27  9:06         ` joeyli
2015-08-11  6:16 ` [PATCH v2 08/16] x86/efi: Carrying hibernation key by setup data Lee, Chun-Yi
     [not found]   ` <1439273796-25359-9-git-send-email-jlee-IBi9RG/b67k@public.gmane.org>
2015-08-15 17:07     ` Pavel Machek
2015-08-15 17:07       ` Pavel Machek
2015-08-16  5:28       ` joeyli
2015-08-16  5:28         ` joeyli
2015-08-16 21:23       ` Jiri Kosina
2015-08-16 21:23         ` Jiri Kosina
2015-08-17  6:54         ` Nigel Cunningham
2015-08-21 12:40   ` Matt Fleming
2015-08-27  9:28     ` joeyli
2015-08-11  6:16 ` [PATCH v2 09/16] PM / hibernate: Reserve hibernation key and erase footprints Lee, Chun-Yi
2015-08-13  2:45   ` Chen, Yu C [this message]
2015-08-13  2:45     ` Chen, Yu C
2015-08-13  3:25     ` joeyli
2015-08-13  3:25       ` joeyli
2015-08-13 14:33   ` joeyli
2015-08-13 14:33     ` joeyli
     [not found]   ` <1439273796-25359-10-git-send-email-jlee-IBi9RG/b67k@public.gmane.org>
2015-08-21 13:27     ` Matt Fleming
2015-08-21 13:27       ` Matt Fleming
2015-08-27 10:21       ` joeyli
2015-09-09 12:24         ` Matt Fleming
     [not found]           ` <20150909122408.GE4973-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2015-09-13  2:58             ` joeyli
2015-09-13  2:58               ` joeyli
2015-08-11  6:16 ` [PATCH v2 10/16] PM / hibernate: Generate and verify signature of hibernate snapshot Lee, Chun-Yi
2015-08-11  6:16 ` [PATCH v2 11/16] PM / hibernate: Avoid including hibernation key to hibernate image Lee, Chun-Yi
2015-08-11  6:16 ` [PATCH v2 12/16] PM / hibernate: Forward signature verifying result and key to image kernel Lee, Chun-Yi
2015-08-11  6:16 ` [PATCH v2 13/16] PM / hibernate: Add configuration to enforce signature verification Lee, Chun-Yi
2015-08-11  6:16 ` [PATCH v2 14/16] PM / hibernate: Allow user trigger hibernation key re-generating Lee, Chun-Yi
2015-08-11  6:16 ` [PATCH v2 15/16] PM / hibernate: Bypass verification logic on legacy BIOS Lee, Chun-Yi
2015-08-11  6:16 ` [PATCH v2 16/16] PM / hibernate: Document signature verification of hibernate snapshot Lee, Chun-Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439434143.15722.12.camel@localhost \
    --to=yu.c.chen@intel.com \
    --cc=hpa@zytor.com \
    --cc=jkosina@suse.cz \
    --cc=jlee@suse.com \
    --cc=joeyli.kernel@gmail.com \
    --cc=jwboyer@redhat.com \
    --cc=len.brown@intel.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=matthew.garrett@nebula.com \
    --cc=mingo@redhat.com \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.