From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Dario Faggioli <dario.faggioli@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH for-4.6 v3 1/3] xl: fix vNUMA vdistance parsing
Date: Thu, 20 Aug 2015 10:04:58 +0100 [thread overview]
Message-ID: <1440061498.3480.87.camel@citrix.com> (raw)
In-Reply-To: <1439837821-8930-2-git-send-email-wei.liu2@citrix.com>
On Mon, 2015-08-17 at 19:56 +0100, Wei Liu wrote:
> We should parse the output from splitting function, not the original
> string, otherwise the parsed result is wrong.
>
> For example:
>
> vnuma = [ [...,"vdistance=10,20",...],
> [...,"vdistance=20,10",...] ]
>
> Before this change, vdistance from node 0 to all nodes (including
> itself) was 10 and vdistance from node 1 to all nodes was 20.
>
> After this change, vdistance from node 0 to itself is 10, to node 1
> is
> 20 and vdistance from node 1 to node 0 is 20, to itself is 10. That's
> the correct vdistance settings we expect.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
next prev parent reply other threads:[~2015-08-20 9:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 18:56 [PATCH for-4.6 v3 0/3] More vNUMA fixes Wei Liu
2015-08-17 18:56 ` [PATCH for-4.6 v3 1/3] xl: fix vNUMA vdistance parsing Wei Liu
2015-08-20 9:04 ` Ian Campbell [this message]
2015-08-17 18:57 ` [PATCH for-4.6 v3 2/3] xl: error out if vNUMA specifies more vcpus than pcpus Wei Liu
2015-08-20 9:47 ` Ian Campbell
2015-08-17 18:57 ` [PATCH for-4.6 v3 3/3] libxc: fix vNUMA memory allocation Wei Liu
2015-08-20 9:47 ` Ian Campbell
2015-08-21 8:07 ` [PATCH for-4.6 v3 0/3] More vNUMA fixes Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440061498.3480.87.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.