* [PATCH] nvdimm: change to use generic kvfree()
@ 2015-08-20 10:00 ` yalin wang
0 siblings, 0 replies; 4+ messages in thread
From: yalin wang @ 2015-08-20 10:00 UTC (permalink / raw)
To: dan.j.williams, linux-nvdimm, linux-kernel; +Cc: yalin wang
Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
---
drivers/nvdimm/dimm_devs.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c
index c05eb80..651b8d1 100644
--- a/drivers/nvdimm/dimm_devs.c
+++ b/drivers/nvdimm/dimm_devs.c
@@ -241,10 +241,7 @@ void nvdimm_drvdata_release(struct kref *kref)
nvdimm_free_dpa(ndd, res);
nvdimm_bus_unlock(dev);
- if (ndd->data && is_vmalloc_addr(ndd->data))
- vfree(ndd->data);
- else
- kfree(ndd->data);
+ kvfree(ndd->data);
kfree(ndd);
put_device(dev);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] nvdimm: change to use generic kvfree()
@ 2015-08-20 10:00 ` yalin wang
0 siblings, 0 replies; 4+ messages in thread
From: yalin wang @ 2015-08-20 10:00 UTC (permalink / raw)
To: dan.j.williams, linux-nvdimm, linux-kernel; +Cc: yalin wang
Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
---
drivers/nvdimm/dimm_devs.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c
index c05eb80..651b8d1 100644
--- a/drivers/nvdimm/dimm_devs.c
+++ b/drivers/nvdimm/dimm_devs.c
@@ -241,10 +241,7 @@ void nvdimm_drvdata_release(struct kref *kref)
nvdimm_free_dpa(ndd, res);
nvdimm_bus_unlock(dev);
- if (ndd->data && is_vmalloc_addr(ndd->data))
- vfree(ndd->data);
- else
- kfree(ndd->data);
+ kvfree(ndd->data);
kfree(ndd);
put_device(dev);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] nvdimm: change to use generic kvfree()
2015-08-20 10:00 ` yalin wang
@ 2015-08-20 17:49 ` Ross Zwisler
-1 siblings, 0 replies; 4+ messages in thread
From: Ross Zwisler @ 2015-08-20 17:49 UTC (permalink / raw)
To: yalin wang; +Cc: dan.j.williams, linux-nvdimm, linux-kernel
On Thu, 2015-08-20 at 18:00 +0800, yalin wang wrote:
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> ---
> drivers/nvdimm/dimm_devs.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c
> index c05eb80..651b8d1 100644
> --- a/drivers/nvdimm/dimm_devs.c
> +++ b/drivers/nvdimm/dimm_devs.c
> @@ -241,10 +241,7 @@ void nvdimm_drvdata_release(struct kref *kref)
> nvdimm_free_dpa(ndd, res);
> nvdimm_bus_unlock(dev);
>
> - if (ndd->data && is_vmalloc_addr(ndd->data))
> - vfree(ndd->data);
> - else
> - kfree(ndd->data);
> + kvfree(ndd->data);
> kfree(ndd);
> put_device(dev);
> }
This seems fine. You're skipping the existing check to see if ndd->data is
NULL, but I think that is handled implicitly by is_vmalloc_addr() since NULL
won't be in the vmalloc address range.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvdimm: change to use generic kvfree()
@ 2015-08-20 17:49 ` Ross Zwisler
0 siblings, 0 replies; 4+ messages in thread
From: Ross Zwisler @ 2015-08-20 17:49 UTC (permalink / raw)
To: yalin wang; +Cc: dan.j.williams, linux-nvdimm, linux-kernel
On Thu, 2015-08-20 at 18:00 +0800, yalin wang wrote:
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> ---
> drivers/nvdimm/dimm_devs.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c
> index c05eb80..651b8d1 100644
> --- a/drivers/nvdimm/dimm_devs.c
> +++ b/drivers/nvdimm/dimm_devs.c
> @@ -241,10 +241,7 @@ void nvdimm_drvdata_release(struct kref *kref)
> nvdimm_free_dpa(ndd, res);
> nvdimm_bus_unlock(dev);
>
> - if (ndd->data && is_vmalloc_addr(ndd->data))
> - vfree(ndd->data);
> - else
> - kfree(ndd->data);
> + kvfree(ndd->data);
> kfree(ndd);
> put_device(dev);
> }
This seems fine. You're skipping the existing check to see if ndd->data is
NULL, but I think that is handled implicitly by is_vmalloc_addr() since NULL
won't be in the vmalloc address range.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-08-20 17:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-20 10:00 [PATCH] nvdimm: change to use generic kvfree() yalin wang
2015-08-20 10:00 ` yalin wang
2015-08-20 17:49 ` Ross Zwisler
2015-08-20 17:49 ` Ross Zwisler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.