From: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
To: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"rodrigo.vivi@gmail.com" <rodrigo.vivi@gmail.com>
Subject: Re: [PATCH 0/7] More PSR patches
Date: Fri, 21 Aug 2015 14:06:25 +0000 [thread overview]
Message-ID: <1440165984.2672.37.camel@intel.com> (raw)
In-Reply-To: <CABVU7+tOxOpE52FRr6xm+J-A_T7YSq9N0Jdq2SqH-v6iS12u_g@mail.gmail.com>
Em Sex, 2015-08-21 às 01:04 +0000, Rodrigo Vivi escreveu:
> This patch series brings stability to PSR on VLV, CHV, HSW and BDW.
>
> It fixes issues Matthew Garrett without causing the blank and frozen
> screens Ivan Mitev was facing.
>
> It also move the VLV/CHV workaround of that big delay from re-enable
> to the first enable after modeset that was the real issue.
> With this besides the stability this series brings more PSR
> residency to these platforms.
I hate to be "that guy", but: no new IGT tests for anything? At least
on my machine, all PSR tests pass without your series, so maybe we
could write some new tests.
Some commits mention bugs, but they don't even teach us how to
reproduce the bugs.
>
> However the enable by default is still out of this series and will
> come
> only after an intensive QA.
>
> Thanks,
> Rodrigo.
>
> Rodrigo Vivi (7):
> drm/i915: Remove duplicated dpcd write on hsw_psr_enable_sink.
> drm/i915: Fix PSR disable sequence on core platforms.
> drm/i915: PSR: Let's rely more on frontbuffer tracking.
> drm/i915: PSR: Mask LPSP hw tracking back again.
> drm/i915: Delay first PSR activation.
> drm/i915: Remove psr re-activation delay on HSW+.
> drm/i915: Reduce PSR re-activation time for VLV/CHV.
>
> drivers/gpu/drm/i915/i915_drv.h | 1 +
> drivers/gpu/drm/i915/intel_psr.c | 75 +++++++++++++++++++++++++-----
> ----------
> 2 files changed, 49 insertions(+), 27 deletions(-)
>
> --
> 2.4.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-08-21 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1440119053-26535-1-git-send-email-rodrigo.vivi@intel.com>
2015-08-21 1:04 ` [PATCH 0/7] More PSR patches Rodrigo Vivi
2015-08-21 14:06 ` Zanoni, Paulo R [this message]
2015-08-21 16:10 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440165984.2672.37.camel@intel.com \
--to=paulo.r.zanoni@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.