[PATCH 0/7] More PSR patches

[PATCH 0/7] More PSR patches

[Rodrigo Vivi]

[-- Attachment #1.1: Type: text/plain, Size: 1087 bytes --]

This patch series brings stability to PSR on VLV, CHV, HSW and BDW.

It fixes issues Matthew Garrett without causing the blank and frozen
screens Ivan Mitev was facing.

It also move the VLV/CHV workaround of that big delay from re-enable
to the first enable after modeset that was the real issue.
With this besides the stability this series brings more PSR
residency to these platforms.

However the enable by default is still out of this series and will come
only after an intensive QA.

Thanks,
Rodrigo.

Rodrigo Vivi (7):
  drm/i915: Remove duplicated dpcd write on hsw_psr_enable_sink.
  drm/i915: Fix PSR disable sequence on core platforms.
  drm/i915: PSR: Let's rely more on frontbuffer tracking.
  drm/i915: PSR: Mask LPSP hw tracking back again.
  drm/i915: Delay first PSR activation.
  drm/i915: Remove psr re-activation delay on HSW+.
  drm/i915: Reduce PSR re-activation time for VLV/CHV.

 drivers/gpu/drm/i915/i915_drv.h  |  1 +
 drivers/gpu/drm/i915/intel_psr.c | 75
+++++++++++++++++++++++++---------------
 2 files changed, 49 insertions(+), 27 deletions(-)

--
2.4.3

[-- Attachment #1.2: Type: text/html, Size: 1329 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/7] More PSR patches

[Zanoni, Paulo R]

Em Sex, 2015-08-21 às 01:04 +0000, Rodrigo Vivi escreveu:
> This patch series brings stability to PSR on VLV, CHV, HSW and BDW.
> 
> It fixes issues Matthew Garrett without causing the blank and frozen
> screens Ivan Mitev was facing.
> 
> It also move the VLV/CHV workaround of that big delay from re-enable
> to the first enable after modeset that was the real issue.
> With this besides the stability this series brings more PSR
> residency to these platforms.

I hate to be "that guy", but: no new IGT tests for anything? At least
on my machine, all PSR tests pass without your series, so maybe we
could write some new tests.

Some commits mention bugs, but they don't even teach us how to
reproduce the bugs.

> 
> However the enable by default is still out of this series and will 
> come
> only after an intensive QA.
> 
> Thanks,
> Rodrigo.
> 
> Rodrigo Vivi (7):
>   drm/i915: Remove duplicated dpcd write on hsw_psr_enable_sink.
>   drm/i915: Fix PSR disable sequence on core platforms.
>   drm/i915: PSR: Let's rely more on frontbuffer tracking.
>   drm/i915: PSR: Mask LPSP hw tracking back again.
>   drm/i915: Delay first PSR activation.
>   drm/i915: Remove psr re-activation delay on HSW+.
>   drm/i915: Reduce PSR re-activation time for VLV/CHV.
> 
>  drivers/gpu/drm/i915/i915_drv.h  |  1 +
>  drivers/gpu/drm/i915/intel_psr.c | 75 +++++++++++++++++++++++++-----
> ----------
>  2 files changed, 49 insertions(+), 27 deletions(-)
> 
> --
> 2.4.3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/7] More PSR patches

[Rodrigo Vivi]

[-- Attachment #1.1: Type: text/plain, Size: 2643 bytes --]

On Fri, Aug 21, 2015 at 7:06 AM Zanoni, Paulo R <paulo.r.zanoni@intel.com>
wrote:

>
> Em Sex, 2015-08-21 às 01:04 +0000, Rodrigo Vivi escreveu:
> > This patch series brings stability to PSR on VLV, CHV, HSW and BDW.
> >
> > It fixes issues Matthew Garrett without causing the blank and frozen
> > screens Ivan Mitev was facing.
> >
> > It also move the VLV/CHV workaround of that big delay from re-enable
> > to the first enable after modeset that was the real issue.
> > With this besides the stability this series brings more PSR
> > residency to these platforms.
>
> I hate to be "that guy",


no worries, you are absolutely right.


> but: no new IGT tests for anything?


Unfortunately no new test. I couldn't reproduce with igt neither of the 2
bugs this series fixes.


> At least
> on my machine, all PSR tests pass without your series, so maybe we
> could write some new tests.
>

yes, it was passing all ltests and are still passing, but I couldn't
reproduce with igt the new cases.


>
> Some commits mention bugs, but they don't even teach us how to
> reproduce the bugs.
>

1 is mentioned on the bugzilla, just right a new modeset when psr was
running already it get unrecoverable lock screen. On igt the combination
simple works, but on the distro flow, any screen off-on will trigger it.

2 is mentioned on the commit but also I coulnd't simulate that on igt,
right after modeset after dpms off-on keep moving your mouse fast and you
wont receive any screen update while you are moving your mouse... then you
stop moving and when you move again the screen is updated...


>
> >
> > However the enable by default is still out of this series and will
> > come
> > only after an intensive QA.
> >
> > Thanks,
> > Rodrigo.
> >
> > Rodrigo Vivi (7):
> >   drm/i915: Remove duplicated dpcd write on hsw_psr_enable_sink.
> >   drm/i915: Fix PSR disable sequence on core platforms.
> >   drm/i915: PSR: Let's rely more on frontbuffer tracking.
> >   drm/i915: PSR: Mask LPSP hw tracking back again.
> >   drm/i915: Delay first PSR activation.
> >   drm/i915: Remove psr re-activation delay on HSW+.
> >   drm/i915: Reduce PSR re-activation time for VLV/CHV.
> >
> >  drivers/gpu/drm/i915/i915_drv.h  |  1 +
> >  drivers/gpu/drm/i915/intel_psr.c | 75 +++++++++++++++++++++++++-----
> > ----------
> >  2 files changed, 49 insertions(+), 27 deletions(-)
> >
> > --
> > 2.4.3
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[-- Attachment #1.2: Type: text/html, Size: 3904 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx