From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: uniphier: add outer cache support
Date: Sun, 23 Aug 2015 19:29:19 -0700 [thread overview]
Message-ID: <1440383359.2670.15.camel@perches.com> (raw)
In-Reply-To: <1440382692-3855-2-git-send-email-yamada.masahiro@socionext.com>
On Mon, 2015-08-24 at 11:18 +0900, Masahiro Yamada wrote:
> This commit adds support for UniPhier outer cache controller.
> All the UniPhier SoCs are equipped with the L2 cache, while the L3
> cache is currently only integrated on PH1-Pro5 SoC.
style trivia:
You might add and use
#define pr_fmt(fmt) "uniphier: " fmt
before any other #include so all of the pr_<level>
uses are automatically prefixed.
> diff --git a/arch/arm/mm/cache-uniphier.c b/arch/arm/mm/cache-uniphier.c
[]
> +static int __init __uniphier_cache_init(void)
> +{
[]
> + if (uniphier_outer_levels == 0) {
> + ret = ret ?: -ENODEV;
> + pr_err("uniphier: failed to initialize outer cache\n");
So this becomes:
pr_err("failed to initialize outer cache\n");
> +int __init uniphier_cache_init(void)
> +{
[]
> + pr_info("uniphier: enabled outer cache (%s)\n",
> + uniphier_outer_levels >= 2 ? "L2 and L3" : "L2");
pr_info("enabled outer cache (%s)\n",
uniphier_outer_levels >= 2 ? "L2 and L3" : "L2");
etc...
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
To: Masahiro Yamada
<yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
Cc: arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
"Arnd Bergmann" <arnd-r2nGTMty4D4@public.gmane.org>,
"Jiri Slaby" <jslaby-IBi9RG/b67k@public.gmane.org>,
"Linus Walleij"
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Kumar Gala" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"Jungseung Lee"
<js07.lee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Ian Campbell"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Tejun Heo" <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Pawel Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
"Florian Fainelli"
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Maxime Coquelin"
<mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Andrew Morton"
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Mauro Carvalho Chehab"
<mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>,
"Russell King" <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
"Nathan Lynch"
<nathan_lynch-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>,
"Kees Cook" <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
"Paul Bolle" <pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>,
"Greg KH"
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Subject: Re: [PATCH 1/3] ARM: uniphier: add outer cache support
Date: Sun, 23 Aug 2015 19:29:19 -0700 [thread overview]
Message-ID: <1440383359.2670.15.camel@perches.com> (raw)
In-Reply-To: <1440382692-3855-2-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
On Mon, 2015-08-24 at 11:18 +0900, Masahiro Yamada wrote:
> This commit adds support for UniPhier outer cache controller.
> All the UniPhier SoCs are equipped with the L2 cache, while the L3
> cache is currently only integrated on PH1-Pro5 SoC.
style trivia:
You might add and use
#define pr_fmt(fmt) "uniphier: " fmt
before any other #include so all of the pr_<level>
uses are automatically prefixed.
> diff --git a/arch/arm/mm/cache-uniphier.c b/arch/arm/mm/cache-uniphier.c
[]
> +static int __init __uniphier_cache_init(void)
> +{
[]
> + if (uniphier_outer_levels == 0) {
> + ret = ret ?: -ENODEV;
> + pr_err("uniphier: failed to initialize outer cache\n");
So this becomes:
pr_err("failed to initialize outer cache\n");
> +int __init uniphier_cache_init(void)
> +{
[]
> + pr_info("uniphier: enabled outer cache (%s)\n",
> + uniphier_outer_levels >= 2 ? "L2 and L3" : "L2");
pr_info("enabled outer cache (%s)\n",
uniphier_outer_levels >= 2 ? "L2 and L3" : "L2");
etc...
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: arm@kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
"Jiri Slaby" <jslaby@suse.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Kumar Gala" <galak@codeaurora.org>,
"Jungseung Lee" <js07.lee@gmail.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Rob Herring" <robh+dt@kernel.org>, "Tejun Heo" <tj@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
devicetree@vger.kernel.org,
"Mauro Carvalho Chehab" <mchehab@osg.samsung.com>,
"Russell King" <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
"Nathan Lynch" <nathan_lynch@mentor.com>,
"Kees Cook" <keescook@chromium.org>,
"Paul Bolle" <pebolle@tiscali.nl>,
"Greg KH" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Mark Rutland" <mark.rutland@arm.com>
Subject: Re: [PATCH 1/3] ARM: uniphier: add outer cache support
Date: Sun, 23 Aug 2015 19:29:19 -0700 [thread overview]
Message-ID: <1440383359.2670.15.camel@perches.com> (raw)
In-Reply-To: <1440382692-3855-2-git-send-email-yamada.masahiro@socionext.com>
On Mon, 2015-08-24 at 11:18 +0900, Masahiro Yamada wrote:
> This commit adds support for UniPhier outer cache controller.
> All the UniPhier SoCs are equipped with the L2 cache, while the L3
> cache is currently only integrated on PH1-Pro5 SoC.
style trivia:
You might add and use
#define pr_fmt(fmt) "uniphier: " fmt
before any other #include so all of the pr_<level>
uses are automatically prefixed.
> diff --git a/arch/arm/mm/cache-uniphier.c b/arch/arm/mm/cache-uniphier.c
[]
> +static int __init __uniphier_cache_init(void)
> +{
[]
> + if (uniphier_outer_levels == 0) {
> + ret = ret ?: -ENODEV;
> + pr_err("uniphier: failed to initialize outer cache\n");
So this becomes:
pr_err("failed to initialize outer cache\n");
> +int __init uniphier_cache_init(void)
> +{
[]
> + pr_info("uniphier: enabled outer cache (%s)\n",
> + uniphier_outer_levels >= 2 ? "L2 and L3" : "L2");
pr_info("enabled outer cache (%s)\n",
uniphier_outer_levels >= 2 ? "L2 and L3" : "L2");
etc...
next prev parent reply other threads:[~2015-08-24 2:29 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 2:18 [PATCH 0/3] ARM: uniphier: add outer cache support and rework SMP operations Masahiro Yamada
2015-08-24 2:18 ` Masahiro Yamada
2015-08-24 2:18 ` Masahiro Yamada
2015-08-24 2:18 ` [PATCH 1/3] ARM: uniphier: add outer cache support Masahiro Yamada
2015-08-24 2:18 ` Masahiro Yamada
2015-08-24 2:18 ` Masahiro Yamada
2015-08-24 2:29 ` Joe Perches [this message]
2015-08-24 2:29 ` Joe Perches
2015-08-24 2:29 ` Joe Perches
2015-08-24 2:58 ` Masahiro Yamada
2015-08-24 2:58 ` Masahiro Yamada
2015-08-24 2:58 ` Masahiro Yamada
2015-08-24 19:59 ` Arnd Bergmann
2015-08-24 19:59 ` Arnd Bergmann
2015-08-24 19:59 ` Arnd Bergmann
2015-08-26 1:38 ` Masahiro Yamada
2015-08-26 1:38 ` Masahiro Yamada
2015-08-26 1:38 ` Masahiro Yamada
2015-08-26 12:52 ` Arnd Bergmann
2015-08-26 12:52 ` Arnd Bergmann
2015-08-26 12:52 ` Arnd Bergmann
2015-08-28 8:59 ` Masahiro Yamada
2015-08-28 8:59 ` Masahiro Yamada
2015-08-28 8:59 ` Masahiro Yamada
2015-08-28 9:44 ` Russell King - ARM Linux
2015-08-28 9:44 ` Russell King - ARM Linux
2015-08-28 9:44 ` Russell King - ARM Linux
2015-08-26 13:39 ` Linus Walleij
2015-08-26 13:39 ` Linus Walleij
2015-08-26 13:39 ` Linus Walleij
2015-08-28 10:24 ` Masahiro Yamada
2015-08-28 10:24 ` Masahiro Yamada
2015-08-28 10:24 ` Masahiro Yamada
2015-09-08 13:09 ` Linus Walleij
2015-09-08 13:09 ` Linus Walleij
2015-09-08 13:09 ` Linus Walleij
2015-09-09 0:06 ` Rob Herring
2015-09-09 0:06 ` Rob Herring
2015-09-09 0:06 ` Rob Herring
2015-08-24 2:18 ` [PATCH 2/3] ARM: uniphier: rework SMP operations to use trampoline code Masahiro Yamada
2015-08-24 2:18 ` Masahiro Yamada
2015-08-24 2:18 ` [PATCH 3/3] ARM: dts: uniphier: add outer cache controller nodes Masahiro Yamada
2015-08-24 2:18 ` Masahiro Yamada
2015-08-24 2:18 ` Masahiro Yamada
2015-08-24 21:47 ` [PATCH 0/3] ARM: uniphier: add outer cache support and rework SMP operations Olof Johansson
2015-08-24 21:47 ` Olof Johansson
2015-08-24 21:47 ` Olof Johansson
2015-08-25 1:50 ` Masahiro Yamada
2015-08-25 1:50 ` Masahiro Yamada
2015-08-25 1:50 ` Masahiro Yamada
2015-08-25 3:05 ` Olof Johansson
2015-08-25 3:05 ` Olof Johansson
2015-08-25 3:05 ` Olof Johansson
2015-08-25 3:19 ` Viresh Kumar
2015-08-25 3:19 ` Viresh Kumar
2015-08-25 3:19 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440383359.2670.15.camel@perches.com \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.