All of lore.kernel.org
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hp.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: hpa@zytor.com, mingo@redhat.com, akpm@linux-foundation.org,
	bp@alien8.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	x86@kernel.org, jgross@suse.com, konrad.wilk@oracle.com,
	elliott@hp.com
Subject: Re: [PATCH v3 3/10] x86/asm: Fix pud/pmd interfaces to handle large PAT bit
Date: Tue, 25 Aug 2015 08:15:46 -0600	[thread overview]
Message-ID: <1440512146.14237.15.camel@hp.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1508251015180.15006@nanos>

On Tue, 2015-08-25 at 10:16 +0200, Thomas Gleixner wrote:
> On Wed, 5 Aug 2015, Toshi Kani wrote:
> 
> > The PAT bit gets relocated to bit 12 when PUD and PMD mappings are
> > used.  This bit 12, however, is not covered by PTE_FLAGS_MASK, which
> > is corrently used for masking pfn and flags for all cases.
> > 
> > Fix pud/pmd interfaces to handle pfn and flags properly by using
> > P?D_PAGE_MASK when PUD/PMD mappings are used, i.e. PSE bit is set.
> 
> Can you please split that into a patch introducing and describing the
> new mask helper functions and a second one making use of it?

Will do.  I will send out v4 patchset today with this update (and the patch
01 update). 

Thanks,
-Toshi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hp.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: hpa@zytor.com, mingo@redhat.com, akpm@linux-foundation.org,
	bp@alien8.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	x86@kernel.org, jgross@suse.com, konrad.wilk@oracle.com,
	elliott@hp.com
Subject: Re: [PATCH v3 3/10] x86/asm: Fix pud/pmd interfaces to handle large PAT bit
Date: Tue, 25 Aug 2015 08:15:46 -0600	[thread overview]
Message-ID: <1440512146.14237.15.camel@hp.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1508251015180.15006@nanos>

On Tue, 2015-08-25 at 10:16 +0200, Thomas Gleixner wrote:
> On Wed, 5 Aug 2015, Toshi Kani wrote:
> 
> > The PAT bit gets relocated to bit 12 when PUD and PMD mappings are
> > used.  This bit 12, however, is not covered by PTE_FLAGS_MASK, which
> > is corrently used for masking pfn and flags for all cases.
> > 
> > Fix pud/pmd interfaces to handle pfn and flags properly by using
> > P?D_PAGE_MASK when PUD/PMD mappings are used, i.e. PSE bit is set.
> 
> Can you please split that into a patch introducing and describing the
> new mask helper functions and a second one making use of it?

Will do.  I will send out v4 patchset today with this update (and the patch
01 update). 

Thanks,
-Toshi

  reply	other threads:[~2015-08-25 14:18 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05 21:43 [PATCH v3 0/10] x86/mm: Handle large PAT bit in pud/pmd interfaces Toshi Kani
2015-08-05 21:43 ` Toshi Kani
2015-08-05 21:43 ` [PATCH v3 1/10] x86/vdso32: Define PGTABLE_LEVELS to 32bit VDSO Toshi Kani
2015-08-05 21:43   ` Toshi Kani
2015-08-20 19:46   ` Thomas Gleixner
2015-08-20 19:46     ` Thomas Gleixner
2015-08-20 23:04     ` Toshi Kani
2015-08-20 23:04       ` Toshi Kani
2015-08-24 21:48       ` Toshi Kani
2015-08-24 21:48         ` Toshi Kani
2015-08-05 21:43 ` [PATCH v3 2/10] x86/asm: Move PUD_PAGE macros to page_types.h Toshi Kani
2015-08-05 21:43   ` Toshi Kani
2015-08-05 21:43 ` [PATCH v3 3/10] x86/asm: Fix pud/pmd interfaces to handle large PAT bit Toshi Kani
2015-08-05 21:43   ` Toshi Kani
2015-08-25  8:16   ` Thomas Gleixner
2015-08-25  8:16     ` Thomas Gleixner
2015-08-25 14:15     ` Toshi Kani [this message]
2015-08-25 14:15       ` Toshi Kani
2015-08-05 21:43 ` [PATCH v3 4/10] x86/asm: Add pud_pgprot() and pmd_pgprot() Toshi Kani
2015-08-05 21:43   ` Toshi Kani
2015-08-05 21:43 ` [PATCH v3 5/10] x86/mm: Fix page table dump to show PAT bit Toshi Kani
2015-08-05 21:43   ` Toshi Kani
2015-08-05 21:43 ` [PATCH v3 6/10] x86/mm: Fix slow_virt_to_phys() to handle large " Toshi Kani
2015-08-05 21:43   ` Toshi Kani
2015-08-05 21:43 ` [PATCH v3 7/10] x86/mm: Fix gup_huge_p?d() " Toshi Kani
2015-08-05 21:43   ` Toshi Kani
2015-08-05 21:43 ` [PATCH v3 8/10] x86/mm: Fix try_preserve_large_page() " Toshi Kani
2015-08-05 21:43   ` Toshi Kani
2015-08-05 21:43 ` [PATCH v3 9/10] x86/mm: Fix __split_large_page() " Toshi Kani
2015-08-05 21:43   ` Toshi Kani
2015-08-05 21:43 ` [PATCH v3 10/10] x86/mm: Fix the same pgprot handling in try_preserve_large_page() Toshi Kani
2015-08-05 21:43   ` Toshi Kani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440512146.14237.15.camel@hp.com \
    --to=toshi.kani@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=elliott@hp.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.