[PATCH] backports: backport IFF_NO_QUEUE net_device flag

[PATCH] backports: backport IFF_NO_QUEUE net_device flag

[Emmanuel Grumbach]

commit fa8187c96471c49419c25d4ec3299d17d3f274b2
Author: Phil Sutter <phil@nwl.cc>
Date:   Thu Aug 13 19:01:06 2015 +0200

    net: declare new net_device priv_flag IFF_NO_QUEUE

    This private net_device flag can be set by drivers to inform that a
    device runs fine without a qdisc attached. This was formerly done by
    setting tx_queue_len to zero.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
---
 backport/backport-include/linux/netdevice.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/backport/backport-include/linux/netdevice.h b/backport/backport-include/linux/netdevice.h
index 95189be..94d8613 100644
--- a/backport/backport-include/linux/netdevice.h
+++ b/backport/backport-include/linux/netdevice.h
@@ -292,4 +292,9 @@ netdev_features_t passthru_features_check(struct sk_buff *skb,
 })
 #endif /* netdev_alloc_pcpu_stats */
 
+#if LINUX_VERSION_CODE < KERNEL_VERSION(4,2,0)
+#ifndef IFF_NO_QUEUE
+#define IFF_NO_QUEUE 1<<26
+#endif
+
 #endif /* __BACKPORT_NETDEVICE_H */
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe backports" in

Re: [PATCH] backports: backport IFF_NO_QUEUE net_device flag

[Johannes Berg]

On Tue, 2015-08-25 at 22:36 +0300, Emmanuel Grumbach wrote:
> commit fa8187c96471c49419c25d4ec3299d17d3f274b2
> Author: Phil Sutter <phil@nwl.cc>
> Date:   Thu Aug 13 19:01:06 2015 +0200
> 
>     net: declare new net_device priv_flag IFF_NO_QUEUE
> 
>     This private net_device flag can be set by drivers to inform that a
>     device runs fine without a qdisc attached. This was formerly done by
>     setting tx_queue_len to zero.
> 
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> ---
>  backport/backport-include/linux/netdevice.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/backport/backport-include/linux/netdevice.h 
> b/backport/backport-include/linux/netdevice.h
> index 95189be..94d8613 100644
> --- a/backport/backport-include/linux/netdevice.h
> +++ b/backport/backport-include/linux/netdevice.h
> @@ -292,4 +292,9 @@ netdev_features_t passthru_features_check(struct 
> sk_buff *skb,
>  })
>  #endif /* netdev_alloc_pcpu_stats */
>  
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(4,2,0)
> +#ifndef IFF_NO_QUEUE
> +#define IFF_NO_QUEUE 1<<26
> +#endif
> 
That doesn't really help, does it? Need to add a semantic patch to
backport this with an ifdef to set the tx_queue_len to 0 in the older
kernel case?

johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in

Re: [PATCH] backports: backport IFF_NO_QUEUE net_device flag

[Grumbach, Emmanuel]

On 08/26/2015 01:05 AM, Johannes Berg wrote:
> On Tue, 2015-08-25 at 22:36 +0300, Emmanuel Grumbach wrote:
>> commit fa8187c96471c49419c25d4ec3299d17d3f274b2
>> Author: Phil Sutter <phil@nwl.cc>
>> Date:   Thu Aug 13 19:01:06 2015 +0200
>>
>>     net: declare new net_device priv_flag IFF_NO_QUEUE
>>
>>     This private net_device flag can be set by drivers to inform that a
>>     device runs fine without a qdisc attached. This was formerly done by
>>     setting tx_queue_len to zero.
>>
>> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
>> ---
>>  backport/backport-include/linux/netdevice.h | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/backport/backport-include/linux/netdevice.h 
>> b/backport/backport-include/linux/netdevice.h
>> index 95189be..94d8613 100644
>> --- a/backport/backport-include/linux/netdevice.h
>> +++ b/backport/backport-include/linux/netdevice.h
>> @@ -292,4 +292,9 @@ netdev_features_t passthru_features_check(struct 
>> sk_buff *skb,
>>  })
>>  #endif /* netdev_alloc_pcpu_stats */
>>  
>> +#if LINUX_VERSION_CODE < KERNEL_VERSION(4,2,0)
>> +#ifndef IFF_NO_QUEUE
>> +#define IFF_NO_QUEUE 1<<26
>> +#endif
>>
> That doesn't really help, does it? Need to add a semantic patch to
> backport this with an ifdef to set the tx_queue_len to 0 in the older
> kernel case?
> 
You are most probably right. I had to admit I just checked that it
compiles and probably didn't take enough time to see what it really
does... :(
--
To unsubscribe from this list: send the line "unsubscribe backports" in