From: Scott Wood <scottwood@freescale.com>
To: "Horia Geantă" <horia.geanta@freescale.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, <linux-crypto@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Victoria Milhoan <vicki.milhoan@freescale.com>,
Steve Cornelius <steve.cornelius@freescale.com>,
Fabio Estevam <fabio.estevam@freescale.com>,
Alex Porosanu <alexandru.porosanu@freescale.com>
Subject: Re: [RFC][PATCH 2/2] crypto: caam - handle core endianness != caam endianness
Date: Mon, 31 Aug 2015 19:49:51 -0500 [thread overview]
Message-ID: <1441068591.4966.47.camel@freescale.com> (raw)
In-Reply-To: <1440762608-7866-1-git-send-email-horia.geanta@freescale.com>
On Fri, 2015-08-28 at 14:50 +0300, Horia Geantă wrote:
>
> -#ifdef __BIG_ENDIAN
> -#define wr_reg32(reg, data) out_be32(reg, data)
> -#define rd_reg32(reg) in_be32(reg)
> +#ifdef CONFIG_CRYPTO_DEV_FSL_CAAM_LE
> +#define caam16_to_cpu(value) le16_to_cpu(value)
> +#define cpu_to_caam16(value) cpu_to_le16(value)
> +#define caam32_to_cpu(value) le32_to_cpu(value)
> +#define cpu_to_caam32(value) cpu_to_le32(value)
> +#define caam64_to_cpu(value) le64_to_cpu(value)
> +#define cpu_to_caam64(value) cpu_to_le64(value)
What if we want to build a kernel that supports a chip with an LE CAAM and
another chip with a BE CAAM (e.g. ls1043a plus ls2080a)? This information
needs to come at runtime.
> +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
> +#ifdef CONFIG_SOC_IMX7D
Likewise, why is there an ifdef for a particular SoC type?
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: scottwood@freescale.com (Scott Wood)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH 2/2] crypto: caam - handle core endianness != caam endianness
Date: Mon, 31 Aug 2015 19:49:51 -0500 [thread overview]
Message-ID: <1441068591.4966.47.camel@freescale.com> (raw)
In-Reply-To: <1440762608-7866-1-git-send-email-horia.geanta@freescale.com>
On Fri, 2015-08-28 at 14:50 +0300, Horia Geant? wrote:
>
> -#ifdef __BIG_ENDIAN
> -#define wr_reg32(reg, data) out_be32(reg, data)
> -#define rd_reg32(reg) in_be32(reg)
> +#ifdef CONFIG_CRYPTO_DEV_FSL_CAAM_LE
> +#define caam16_to_cpu(value) le16_to_cpu(value)
> +#define cpu_to_caam16(value) cpu_to_le16(value)
> +#define caam32_to_cpu(value) le32_to_cpu(value)
> +#define cpu_to_caam32(value) cpu_to_le32(value)
> +#define caam64_to_cpu(value) le64_to_cpu(value)
> +#define cpu_to_caam64(value) cpu_to_le64(value)
What if we want to build a kernel that supports a chip with an LE CAAM and
another chip with a BE CAAM (e.g. ls1043a plus ls2080a)? This information
needs to come at runtime.
> +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
> +#ifdef CONFIG_SOC_IMX7D
Likewise, why is there an ifdef for a particular SoC type?
-Scott
next prev parent reply other threads:[~2015-09-01 0:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 11:45 [RFC][PATCH 0/2] crypto: caam - Revamp I/O accessors Horia Geantă
2015-08-28 11:45 ` Horia Geantă
2015-08-28 11:49 ` [RFC][PATCH 1/2] arm64: add ioread64be and iowrite64be macros Horia Geantă
2015-08-28 11:49 ` Horia Geantă
2015-09-02 10:38 ` Will Deacon
2015-09-02 10:38 ` Will Deacon
2015-08-28 11:50 ` [RFC][PATCH 2/2] crypto: caam - handle core endianness != caam endianness Horia Geantă
2015-08-28 11:50 ` Horia Geantă
2015-09-01 0:49 ` Scott Wood [this message]
2015-09-01 0:49 ` Scott Wood
2015-09-02 6:25 ` Porosanu Alexandru
2015-09-02 6:25 ` Porosanu Alexandru
2015-09-02 6:25 ` Porosanu Alexandru
2015-09-02 22:33 ` Scott Wood
2015-09-02 22:33 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441068591.4966.47.camel@freescale.com \
--to=scottwood@freescale.com \
--cc=alexandru.porosanu@freescale.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steve.cornelius@freescale.com \
--cc=vicki.milhoan@freescale.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.