From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>, Yu Zhang <yu.c.zhang@linux.intel.com>
Cc: kevin.tian@intel.com, keir@xen.org,
stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
Paul.Durrant@citrix.com, zhiyuan.lv@intel.com, jbeulich@suse.com
Subject: Re: [PATCH v8 2/3] Differentiate IO/mem resources tracked by ioreq server
Date: Tue, 1 Sep 2015 16:38:44 +0100 [thread overview]
Message-ID: <1441121924.26292.66.camel@citrix.com> (raw)
In-Reply-To: <20150825094002.GL29776@zion.uk.xensource.com>
On Tue, 2015-08-25 at 10:40 +0100, Wei Liu wrote:
> On Sun, Aug 23, 2015 at 05:33:17PM +0800, Yu Zhang wrote:
> > Currently in ioreq server, guest write-protected ram pages are
> > tracked in the same rangeset with device mmio resources. Yet
> > unlike device mmio, which can be in big chunks, the guest write-
> > protected pages may be discrete ranges with 4K bytes each. This
> > patch uses a seperate rangeset for the guest ram pages.
> >
> > Note: Previously, a new hypercall or subop was suggested to map
> > write-protected pages into ioreq server. However, it turned out
> > handler of this new hypercall would be almost the same with the
> > existing pair - HVMOP_[un]map_io_range_to_ioreq_server, and there's
> > already a type parameter in this hypercall. So no new hypercall
> > defined, only a new type is introduced.
> >
> > Signed-off-by: Yu Zhang <yu.c.zhang@linux.intel.com>
> > ---
> > tools/libxc/include/xenctrl.h | 31 ++++++++++++++++++++
> > tools/libxc/xc_domain.c | 61
> > ++++++++++++++++++++++++++++++++++++++++
>
> For tools bits:
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
I looked at it before I saw this and as a binding for the hypercall it LGTM
as well:
Acked-by: Ian Campbell <ian.campbell@citrix.com>
There appear to be no callers of these new interfaces, are those to come
later?
Given the trivial nature of the tools side here I'm likely not going to pay
much attention to this series from now on, please drop me an explicit ping
if something changes which requires my attention.
Ian.
next prev parent reply other threads:[~2015-09-01 15:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-23 9:33 [PATCH v8 0/3] Refactor ioreq server for better performance Yu Zhang
2015-08-23 9:33 ` [PATCH v8 1/3] Remove identical relationship between ioreq type and rangeset type Yu Zhang
2015-08-31 12:06 ` Jan Beulich
2015-08-23 9:33 ` [PATCH v8 2/3] Differentiate IO/mem resources tracked by ioreq server Yu Zhang
2015-08-25 9:40 ` Wei Liu
2015-08-28 3:11 ` Yu, Zhang
2015-08-28 8:38 ` Jan Beulich
2015-08-28 9:55 ` Yu, Zhang
2015-09-01 15:38 ` Ian Campbell [this message]
2015-08-31 12:18 ` Jan Beulich
2015-08-23 9:33 ` [PATCH v8 3/3] Refactor rangeset structure for better performance Yu Zhang
2015-08-31 12:29 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441121924.26292.66.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=yu.c.zhang@linux.intel.com \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.